-
-
Notifications
You must be signed in to change notification settings - Fork 34.6k
Fix commented out part of test_body_encode in test_email #149916
Copy link
Copy link
Closed
Labels
3.13bugs and security fixesbugs and security fixes3.14bugs and security fixesbugs and security fixes3.15pre-release feature fixes, bugs and security fixespre-release feature fixes, bugs and security fixes3.16new features, bugs and security fixesnew features, bugs and security fixestestsTests in the Lib/test dirTests in the Lib/test dirtopic-email
Metadata
Metadata
Assignees
Labels
3.13bugs and security fixesbugs and security fixes3.14bugs and security fixesbugs and security fixes3.15pre-release feature fixes, bugs and security fixespre-release feature fixes, bugs and security fixes3.16new features, bugs and security fixesnew features, bugs and security fixestestsTests in the Lib/test dirTests in the Lib/test dirtopic-email
It was commented out in bef9d21. The test was broken because:
Charset.body_encode()now only takes one argument (see 9604e66).Charset.body_encode()must be Unicode string for encoding taking place. The test used a 8-bit string in Python 2.So the test can only be restored partially, but it was the only test with different input and output codecs, so it is better to enable it.
Linked PRs