Skip to content

Why .devcontainer/setup.sh downloads and runs https://bootstrap.pypa.io/get-pip.py #13

@kroleg

Description

@kroleg

Information

  • None of the other issue templates apply

Description

Thanks for this repo. 🙇 Finally there is a way to build keymaps without installing ton of stuff on my machine.

I noticed that ghcr.io/qmk/qmk_cli image already has latest pip https://github.com/qmk/qmk_cli/blob/d3917b10e7621632098028a68982727b10ec83f5/Dockerfile#L8, so why is there a need to download get-pip.py?
And if there is a need for latest pip why not do python3 -m pip install --upgrade pip like qmk_cli does?

Also downloading .py file with blobs looks suspicious. It even has a comment in the start of the file:
Screenshot 2024-04-18 at 10 01 43

But that's exactly what i would say if i was up for something nefarious :D

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions