Fix JSON pretty print (#11)

* Add (failing) pretty json print test

* Make FileWrapper respect the pretty printing setting

---------

Co-authored-by: Lilly Tempest <46890129+rainbowdashlabs@users.noreply.github.com>

Author: Strokkur424

src/main/java/dev/chojo/ocular/components/FileWrapper.java

@@ -24,6 +24,10 @@ public record FileWrapper<T>(Format<?, ?> format, T file) {
      * @throws JsonProcessingException if an error occurs during serialization
      */
     public String asString() throws JsonProcessingException {
+        if (format.format().enablePrettyPrint()) {
+            return format.writer().writerWithDefaultPrettyPrinter().writeValueAsString(file);
+        }
+
         return format.writer().writeValueAsString(file);
     }
 }

src/main/java/dev/chojo/ocular/dataformats/DataFormat.java

@@ -22,6 +22,7 @@
  * @param <B> the type of MapperBuilder used to configure the associated ObjectMapper
  */
 public interface DataFormat<M extends ObjectMapper, B extends MapperBuilder<M, B>> extends Configurator<M, B> {
+    
     /**
      * Creates and returns a new instance of the mapper builder associated with the data format.
      * This method is used to initialize the builder for configuring the ObjectMapper for
@@ -40,6 +41,13 @@ public interface DataFormat<M extends ObjectMapper, B extends MapperBuilder<M, B
      */
     String type();
 
+    /**
+     * Used to determine whether the default pretty printer should be used explicitly
+     */
+    default boolean enablePrettyPrint() {
+        return false;
+    }
+
     /**
      * Checks whether the specified key matches the type or any of the type aliases of the current data format.
      *

src/main/java/dev/chojo/ocular/dataformats/JsonDataFormat.java

@@ -33,6 +33,11 @@ public void assertInstalled() {
         // json should be always installed
     }
 
+    @Override
+    public boolean enablePrettyPrint() {
+        return prettyPrint;
+    }
+
     @Override
     public void configure(JsonMapper mapper) {
         if (prettyPrint) {

src/test/java/dev/chojo/ocular/ConfigurationsTest.java

@@ -138,6 +138,42 @@ void migrate() {
         Assertions.assertTrue(Files.exists(BASE.resolve(YML.path())));
     }
 
+    @Test
+    void checkPrettyJsonFormat() throws IOException {
+        Configurations<MyClass> conf = Configurations.builder(JSON, new JsonDataFormat(true))
+            .setBase(BASE)
+            .build();
+
+        conf.main();
+        conf.save();
+
+        Assertions.assertTrue(BASE.resolve(JSON.path()).toFile().exists());
+        String json = Files.readString(BASE.resolve(JSON.path()));
+
+        // The reason we use .lines() here is because of OS specific differences in line separators (LF & CRLF) 
+        Assertions.assertLinesMatch("""
+            {
+              "name" : "Lilly",
+              "age" : 20
+            }
+            """.trim().lines(), json.lines());
+    }
+
+    @Test
+    void checkNonPrettyJsonFormat() throws IOException {
+        Configurations<MyClass> conf = Configurations.builder(JSON, new JsonDataFormat(false))
+            .setBase(BASE)
+            .build();
+
+        conf.main();
+        conf.save();
+
+        Assertions.assertTrue(BASE.resolve(JSON.path()).toFile().exists());
+        String json = Files.readString(BASE.resolve(JSON.path()));
+        
+        Assertions.assertEquals("{\"name\":\"Lilly\",\"age\":20}", json);
+    }
+
 //    void example() {
 //        Key<MyClass> mainConfig = Key.builder(Path.of("config.json"), MyClass::new).build();
 //        Configurations<MyClass> conf = Configurations.builder(
@@ -154,7 +190,7 @@ void migrate() {
 //                                                     .build();
 //    }
 
-    void exampleJacksonBukkit(){
+    void exampleJacksonBukkit() {
         Key<MyClass> mainConfig = Key.builder(Path.of("config.yml"), MyClass::new).build();
         Configurations.builder(mainConfig, new YamlDataFormat())
                 .withClassLoader(this.getClass().getClassLoader()) // For minecraft its important to pass the classloader