[gui,graf] fix off-by-one docu mistakes (#21460)

Avoid Doxygen documentation errors without disturbing transient I/O mark

Author: ferdymercury

documentation/primer/macros/MySelector.h

@@ -17,7 +17,7 @@
 
 class MySelector : public TSelector {
 public :
-   TTree          *fChain;   //!pointer to the analyzed TTree or TChain
+   TTree          *fChain;   ///<!pointer to the analyzed TTree or TChain
 
 // Fixed size dimensions of array or collections stored in the TTree if any.
 
@@ -28,10 +28,10 @@ public :
    Float_t         Pressure;
 
    // List of branches
-   TBranch        *b_Potential;   //!
-   TBranch        *b_Current;   //!
-   TBranch        *b_Temperature;   //!
-   TBranch        *b_Pressure;   //!
+   TBranch        *b_Potential;   ///<!
+   TBranch        *b_Current;   ///<!
+   TBranch        *b_Temperature;   ///<!
+   TBranch        *b_Pressure;   ///<!
 
    MySelector(TTree * /*tree*/ =0) : fChain(0) { }
    virtual ~MySelector() { }

documentation/users-guide/AddingaClass.md

@@ -600,9 +600,9 @@ in this chapter.
 #include "TObject.h"
 class SClass : public TObject {
    private:
-      Float_t   fX;         //x position in centimeters
-      Float_t   fY;         //y position in centimeters
-      Int_t     fTempValue; //! temporary state value
+      Float_t   fX;         ///<x position in centimeters
+      Float_t   fY;         ///<y position in centimeters
+      Int_t     fTempValue; ///<! temporary state value
    public:
       SClass()             { fX = fY = -1; }
       void Print() const;
@@ -637,7 +637,7 @@ Interpreter". The `ShowMembers` and `Streamer` method, as well as the
 add a `!` as the first character in the comments of the field:
 
 ``` {.cpp}
-Int_t     fTempValue; //! temporary state value
+Int_t     fTempValue; ///<! temporary state value
 ```
 
 ### The LinkDef.h File

documentation/users-guide/InputOutput.md

@@ -1188,8 +1188,8 @@ simple example of a class with diverse data members.
 ``` {.cpp}
 class Event : public TObject {
 private:
-   TDirectory    *fTransient;            //! current directory
-   Float_t     fPt;                   //! transient value
+   TDirectory    *fTransient;            ///<! current directory
+   Float_t     fPt;                   ///<! transient value
 char           fType[20];
 Int_t          fNtrack;
 Int_t          fNseg;
@@ -1238,6 +1238,7 @@ object.
 
 
 To prevent a data member from being written to the file, insert a "`!`"
+To make it compatible with Doxygen, write `///<!` instead of `//!`.
 as the first character after the comment marks. It tells ROOT not to
 save that data member in a root file when saving the class. For example,
 in this version of Event, the `fPt` and `fTransient` data members are
@@ -1246,8 +1247,8 @@ not persistent.
 ``` {.cpp}
 class Event : public TObject {
 private:
-   TDirectory    *fTransient; //! current directory
-   Float_t fPt;               //! transient value
+   TDirectory    *fTransient; ///<! current directory
+   Float_t fPt;               ///<! transient value
 ...
 ```
 
@@ -1895,7 +1896,7 @@ a "`!`" after the comment marks. For example the pointer \*`fPainter` of
 a **`TH1`** is not persistent:
 
 ``` {.cpp}
-   TVirtualHistPainter* fPainter //!pointer to histogram painter
+   TVirtualHistPainter* fPainter ///<!pointer to histogram painter
 ```
 
 ### The TStreamerElement Class

graf2d/cocoa/inc/TGCocoa.h

@@ -441,7 +441,7 @@ class TGCocoa : public TVirtualX {
 
    Drawable_t fSelectedDrawable;
 
-   std::unique_ptr<ROOT::MacOSX::Details::CocoaPrivate> fPimpl; //!
+   std::unique_ptr<ROOT::MacOSX::Details::CocoaPrivate> fPimpl; ///<!
    Int_t fCocoaDraw;
 
    EDrawMode fDrawMode;

graf2d/gpad/src/TInspectCanvas.cxx

@@ -47,8 +47,8 @@ class TInspectorObject : public TObject
    TClass *IsA() const override { return fClass; }
 
 private:
-   void     *fObj{nullptr};   //! pointer to the foreign object
-   TClass   *fClass{nullptr}; //! pointer to class of the foreign object
+   void     *fObj{nullptr};   ///<! pointer to the foreign object
+   TClass   *fClass{nullptr}; ///<! pointer to class of the foreign object
 
 };
 

graf2d/graf/inc/TMathText.h

@@ -21,7 +21,7 @@ class TMathText : public TText, public TAttFill {
 
    friend class TMathTextRenderer;
 
-   TMathTextRenderer *fRenderer{nullptr}; //!TMathText Painter
+   TMathTextRenderer *fRenderer{nullptr}; ///<!TMathText Painter
    TMathText &operator=(const TMathText &);
 
    void Render(const Double_t x, const Double_t y,

graf3d/eve/inc/TEveCaloLegoOverlay.h

@@ -50,7 +50,7 @@ class TEveCaloLegoOverlay : public TGLCameraOverlay
    Char_t         fFrameBgTransp;
 
    // move of scales
-   Int_t             fMouseX, fMouseY; //! last mouse position
+   Int_t             fMouseX, fMouseY; ///<! last mouse position
    Bool_t            fInDrag;
 
    // text top right corner

graf3d/eve/inc/TEveDigitSet.h

@@ -63,8 +63,8 @@ class TEveDigitSet : public TEveElement,
    Bool_t            fAntiFlick;      // Make extra render pass to avoid flickering when quads are too small.
    Bool_t            fOwnIds;         //  Flag specifying if id-objects are owned by the TEveDigitSet.
    TEveChunkManager  fPlex;           //  Container of digit data.
-   DigitBase_t*      fLastDigit;      //! The last / current digit added to collection.
-   Int_t             fLastIdx;        //! The last / current idx added to collection.
+   DigitBase_t*      fLastDigit;      ///<! The last / current digit added to collection.
+   Int_t             fLastIdx;        ///<! The last / current idx added to collection.
 
    Color_t           fColor;          //  Color used for frame (or all digis with single-color).
    TEveFrameBox*     fFrame;          //  Pointer to frame structure.
@@ -76,8 +76,8 @@ class TEveDigitSet : public TEveElement,
    Bool_t            fHistoButtons;   //  Show histogram buttons in object editor.
 
    Bool_t            fEmitSignals;    //  Emit signals on secondary-select.
-   Callback_foo      fCallbackFoo;    //! Additional function to call on secondary-select.
-   TooltipCB_foo     fTooltipCBFoo;   //! Function providing highlight tooltips when always-sec-select is active.
+   Callback_foo      fCallbackFoo;    ///<! Additional function to call on secondary-select.
+   TooltipCB_foo     fTooltipCBFoo;   ///<! Function providing highlight tooltips when always-sec-select is active.
 
    DigitBase_t* NewDigit();
    void         ReleaseIds();

graf3d/eve/inc/TEveElement.h

@@ -80,13 +80,13 @@ class TEveElement
    List_t           fParents;              //  List of parents.
    List_t           fChildren;             //  List of children.
    TEveCompound    *fCompound;             //  Compound this object belongs to.
-   TEveElement     *fVizModel;             //! Element used as model from VizDB.
+   TEveElement     *fVizModel;             ///<! Element used as model from VizDB.
    TString          fVizTag;               //  Tag used to query VizDB for model element.
 
-   Int_t            fNumChildren;          //!
-   Int_t            fParentIgnoreCnt;      //! Counter for parents that are ignored in ref-counting.
-   Int_t            fTopItemCnt;           //! Counter for top-level list-tree items that prevent automatic destruction.
-   Int_t            fDenyDestroy;          //! Deny-destroy count.
+   Int_t            fNumChildren;          ///<!
+   Int_t            fParentIgnoreCnt;      ///<! Counter for parents that are ignored in ref-counting.
+   Int_t            fTopItemCnt;           ///<! Counter for top-level list-tree items that prevent automatic destruction.
+   Int_t            fDenyDestroy;          ///<! Deny-destroy count.
    Bool_t           fDestroyOnZeroRefCnt;  //  Auto-destruct when ref-count reaches zero.
 
    Bool_t           fRnrSelf;                 //  Render this element.
@@ -99,10 +99,10 @@ class TEveElement
    Color_t         *fMainColorPtr;         //  Pointer to main-color variable.
    TEveTrans       *fMainTrans;            //  Pointer to main transformation matrix.
 
-   sLTI_t           fItems;                //! Set of list-tree-items.
+   sLTI_t           fItems;                ///<! Set of list-tree-items.
 
    TRef             fSource;               //  External object that is represented by this element.
-   void            *fUserData;             //! Externally assigned and controlled user data.
+   void            *fUserData;             ///<! Externally assigned and controlled user data.
 
    virtual void PreDeleteElement();
    virtual void RemoveElementsInternal();
@@ -310,10 +310,10 @@ class TEveElement
 
 protected:
    Bool_t  fPickable;
-   Bool_t  fSelected;             //!
-   Bool_t  fHighlighted;          //!
-   Short_t fImpliedSelected;      //!
-   Short_t fImpliedHighlighted;   //!
+   Bool_t  fSelected;             ///<!
+   Bool_t  fHighlighted;          ///<!
+   Short_t fImpliedSelected;      ///<!
+   Short_t fImpliedHighlighted;   ///<!
 
    enum ECompoundSelectionColorBits
    {
@@ -398,8 +398,8 @@ class TEveElement
    };
 
 protected:
-   UChar_t      fChangeBits;  //!
-   Char_t       fDestructing; //!
+   UChar_t      fChangeBits;  ///<!
+   Char_t       fDestructing; ///<!
 
 public:
    void StampColorSelection() { AddStamp(kCBColorSelection); }

graf3d/eve/inc/TEveGeoNode.h

@@ -37,8 +37,8 @@ class TEveGeoNode : public TEveElement,
    TGeoNode *fNode;
    TEveGeoShapeExtract* DumpShapeTree(TEveGeoNode* geon, TEveGeoShapeExtract* parent=nullptr, Bool_t leafs_only=kFALSE);
 
-   static Int_t                  fgCSGExportNSeg;  //!
-   static std::list<TGeoShape*>  fgTemporaryStore; //!
+   static Int_t                  fgCSGExportNSeg;  ///<!
+   static std::list<TGeoShape*>  fgTemporaryStore; ///<!
 
 public:
    TEveGeoNode(TGeoNode* node);