BCPC Index Table Contains Duplicate and Inflated Entries

[stitam]

While reviewing PR #439 I noticed that the integrity of the BCPC index table could be improved. Some rows are duplicated (e.g. name == "63935-38-6"), some entries are inflated due to multiple linknames (e.g. links == "trichlorfon.html") and there may be other opportunities for improvement as well.

[stitam]

On second thought, I think removing duplicates is fine, but other than that there is probably not much to gain from tweaking the index table. A link can belong to multiple compound names and/or multiple CAS registry numbers and that is fine. As long as each name or registry number belongs to a single link, routing will be non-ambiguous.

I checked this. All registry numbers are associated with unique links but there are 13 cases where the linkname is associated with multiple links, e.g. "zinc thiazole" has three separate links. However, these links ultimately resolve to the same endpoint at BCPC so there no real issue. On the other hand, inconsistencies "could" be introduced in the future, so I wonder whether we should add checks to ensure if an ambiguity is introduced, we are alerted.

[jranke]

I have to admit, I would be inclined to just trust them to get it right just as I trust them to give the correct chemical information for the name queries. But I am glad you checked and did not find inconsistencies in the table!