Skip to content

docs: make Rc::into_raw clickable in Rc::increment_strong_count doc#156783

Open
MingweiSamuel wants to merge 1 commit into
rust-lang:mainfrom
MingweiSamuel:patch-2
Open

docs: make Rc::into_raw clickable in Rc::increment_strong_count doc#156783
MingweiSamuel wants to merge 1 commit into
rust-lang:mainfrom
MingweiSamuel:patch-2

Conversation

@MingweiSamuel
Copy link
Copy Markdown
Contributor

adds doc link

Copilot AI review requested due to automatic review settings May 20, 2026 17:50
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 20, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 20, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 7 candidates

This comment was marked as low quality.

Comment thread library/alloc/src/rc.rs
/// # Safety
///
/// The pointer must have been obtained through `Rc::into_raw` and must satisfy the
/// The pointer must have been obtained through [`Rc::into_raw`][into_raw] and must satisfy the
Copy link
Copy Markdown
Member

@joboet joboet May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rustdoc automatically figures these things out, so

Suggested change
/// The pointer must have been obtained through [`Rc::into_raw`][into_raw] and must satisfy the
/// The pointer must have been obtained through [`Rc::into_raw`] and must satisfy the

is enough for the link to work.

View changes since the review

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, although it should also be changed below for into_raw_in for that reason as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants