Skip to content

Commit ea0ea75

Browse files
committed
error: lift out certificate error mapping
For consistency with other many-variant sub-error mappings.
1 parent 04ca997 commit ea0ea75

1 file changed

Lines changed: 21 additions & 15 deletions

File tree

librustls/src/error.rs

Lines changed: 21 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -571,21 +571,7 @@ pub(crate) fn map_error(input: Error) -> rustls_result {
571571
Error::NoApplicationProtocol => NoApplicationProtocol,
572572
Error::BadMaxFragmentSize => BadMaxFragmentSize,
573573

574-
Error::InvalidCertificate(e) => match e {
575-
CertificateError::BadEncoding => CertEncodingBad,
576-
CertificateError::Expired => CertExpired,
577-
CertificateError::NotValidYet => CertNotYetValid,
578-
CertificateError::Revoked => CertRevoked,
579-
CertificateError::UnhandledCriticalExtension => CertUnhandledCriticalExtension,
580-
CertificateError::UnknownIssuer => CertUnknownIssuer,
581-
CertificateError::UnknownRevocationStatus => CertUnknownRevocationStatus,
582-
CertificateError::ExpiredRevocationList => CertExpiredRevocationList,
583-
CertificateError::BadSignature => CertBadSignature,
584-
CertificateError::NotValidForName => CertNotValidForName,
585-
CertificateError::InvalidPurpose => CertInvalidPurpose,
586-
CertificateError::ApplicationVerificationFailure => CertApplicationVerificationFailure,
587-
_ => CertOtherError,
588-
},
574+
Error::InvalidCertificate(e) => map_invalid_certificate_error(e),
589575

590576
Error::General(_) => General,
591577

@@ -733,6 +719,26 @@ fn map_invalid_message_error(err: InvalidMessage) -> rustls_result {
733719
}
734720
}
735721

722+
fn map_invalid_certificate_error(err: CertificateError) -> rustls_result {
723+
use rustls_result::*;
724+
725+
match err {
726+
CertificateError::BadEncoding => CertEncodingBad,
727+
CertificateError::Expired => CertExpired,
728+
CertificateError::NotValidYet => CertNotYetValid,
729+
CertificateError::Revoked => CertRevoked,
730+
CertificateError::UnhandledCriticalExtension => CertUnhandledCriticalExtension,
731+
CertificateError::UnknownIssuer => CertUnknownIssuer,
732+
CertificateError::UnknownRevocationStatus => CertUnknownRevocationStatus,
733+
CertificateError::ExpiredRevocationList => CertExpiredRevocationList,
734+
CertificateError::BadSignature => CertBadSignature,
735+
CertificateError::NotValidForName => CertNotValidForName,
736+
CertificateError::InvalidPurpose => CertInvalidPurpose,
737+
CertificateError::ApplicationVerificationFailure => CertApplicationVerificationFailure,
738+
_ => CertOtherError,
739+
}
740+
}
741+
736742
fn map_ech_error(err: EncryptedClientHelloError) -> rustls_result {
737743
use rustls_result::*;
738744

0 commit comments

Comments
 (0)