Use precise type for x in case x @ (_: A, _: B), take 2#26161
Merged
Conversation
SolalPirelli
commented
May 27, 2026
| local1 => val local inObj: Obj[In] & Repr[In] | ||
| local2 => val local outObj: Obj[Out] & Repr[Out] | ||
| local1 => val local inObj: Obj[In] | ||
| local2 => val local outObj: Obj[Out] |
Contributor
Author
There was a problem hiding this comment.
the source is case (inObj: Obj[In], outObj: Obj[Out]) so this makes sense to me
SolalPirelli
commented
May 27, 2026
| val newSelArgs = unadaptedArgs.zip(selArgs).map: | ||
| case (Typed(_, tpt: AppliedTypeTree), t) => | ||
| // However, we can't do that if the args changed, e.g., if the args were patterns | ||
| typed(tpt) match |
Contributor
Author
There was a problem hiding this comment.
compared to take 1, we at least use the result of this, and no longer need to check hasType
noti0na1
approved these changes
Jun 3, 2026
Member
noti0na1
left a comment
noti0na1
left a comment
There was a problem hiding this comment.
LGTM. Hope we will have a more clean desugar in the future~
SolalPirelli
added
the
backport:nominated
Contributor
Author
|
Nominating for backport because it fixes a regression |
WojciechMazur
added
backport:accepted
WojciechMazur
added
backport:done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25544
Alternate for #25734
How much have you relied on LLM-based tools in this contribution?
Not at all
How was the solution tested?
New automated tests (including the issue's reproducer, if applicable)