Stop capturing a Context in ScalaPrimitives#26177
Merged
Merged
Conversation
SolalPirelli
commented
May 28, 2026
|
|
||
| /** Initialize the primitive map */ | ||
| private def init: ReadOnlyMap[Symbol, Int] = { | ||
| private def init(using Context): ReadOnlyMap[Symbol, Int] = atPhase(Phases.flattenPhase) { |
Contributor
Author
There was a problem hiding this comment.
Note the necessary time travel. I think what used to happen is that since primitives was lazy, it would happen to be initialized at the "right" time for the context to be in the right phase.
lrytz
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Could cause trouble when parallelizing the backend, and is anyway not how the rest of the backend works.
How much have you relied on LLM-based tools in this contribution?
Not at all
How was the solution tested?
Covered by existing tests (this is a refactoring)