feat: shared storage does not require zone labels for Kubernetes nodes

It can be accessed from multiple nodes regardless of their region assignment.
This simplifies configuration and eliminates the need for zone topology-based scheduling

Signed-off-by: Mrton0121 <gombimarci@gmail.com>
Signed-off-by: Serge Logvinov <serge.logvinov@sinextra.dev>

Author: Mrton0121

README.md

@@ -79,7 +79,7 @@ It is very important to use disk controller `VirtIO SCSI single` with `iothread`
 ### Kubernetes Topology Labels
 
 Proxmox CSI Plugin uses the well-known node labels/spec to define the disk location
-* `topology.kubernetes.io/region` - proxmox cluster name, the name must be the same as in cloud config region name
+* `topology.kubernetes.io/region` - the name must be the same as in cloud config region name
 * `topology.kubernetes.io/zone` - proxmox node name
 * `Spec.ProviderID` - providerID magic string `proxmox://$REGION/$VMID` to help define the virtual machine ID, it cannot be changed after the first update. If it not exists, the plugin will find the VM by the name or UUID.
 

pkg/csi/controller.go

@@ -582,8 +582,8 @@ func (d *ControllerService) GetCapacity(_ context.Context, request *csi.GetCapac
 		zone := topology.GetSegments()[corev1.LabelTopologyZone]
 		storageID := request.GetParameters()[StorageIDKey]
 
-		if region == "" || zone == "" || storageID == "" {
-			return nil, status.Error(codes.InvalidArgument, "region, zone and storageName must be provided")
+		if region == "" || storageID == "" {
+			return nil, status.Error(codes.InvalidArgument, "region and storage must be provided")
 		}
 
 		klog.V(3).InfoS("GetCapacity", "region", region, "zone", zone, "storageID", storageID)
@@ -595,6 +595,13 @@ func (d *ControllerService) GetCapacity(_ context.Context, request *csi.GetCapac
 			return nil, status.Error(codes.Internal, err.Error())
 		}
 
+		if zone == "" {
+			zone, err = getNodeWithStorage(cl, storageID)
+			if err != nil {
+				return nil, status.Error(codes.Internal, err.Error())
+			}
+		}
+
 		vmr := pxapi.NewVmRef(vmID)
 		vmr.SetNode(zone)
 		vmr.SetVmType("qemu")

pkg/csi/controller_test.go

@@ -1111,7 +1111,7 @@ func (ts *configuredTestSuite) TestGetCapacity() {
 			request: &proto.GetCapacityRequest{
 				AccessibleTopology: &proto.Topology{},
 			},
-			expectedError: status.Error(codes.InvalidArgument, "region, zone and storageName must be provided"),
+			expectedError: status.Error(codes.InvalidArgument, "region and storage must be provided"),
 		},
 		{
 			msg: "TopologyRegion",
@@ -1125,7 +1125,7 @@ func (ts *configuredTestSuite) TestGetCapacity() {
 					csi.StorageIDKey: "storage",
 				},
 			},
-			expectedError: status.Error(codes.InvalidArgument, "region, zone and storageName must be provided"),
+			expectedError: status.Error(codes.Internal, "proxmox cluster region not found"),
 		},
 		{
 			msg: "TopologyZone",
@@ -1139,7 +1139,7 @@ func (ts *configuredTestSuite) TestGetCapacity() {
 					csi.StorageIDKey: "storage",
 				},
 			},
-			expectedError: status.Error(codes.InvalidArgument, "region, zone and storageName must be provided"),
+			expectedError: status.Error(codes.InvalidArgument, "region and storage must be provided"),
 		},
 		{
 			msg: "TopologyStorageName",
@@ -1151,7 +1151,7 @@ func (ts *configuredTestSuite) TestGetCapacity() {
 					},
 				},
 			},
-			expectedError: status.Error(codes.InvalidArgument, "region, zone and storageName must be provided"),
+			expectedError: status.Error(codes.InvalidArgument, "region and storage must be provided"),
 		},
 		{
 			msg: "Topology",