Skip to content

Commit 78aae1b

Browse files
justin808claude
andcommitted
Address PR review: fix skill file inclusion and README install
- Replace broken shell expansion (`$(dirname "$0")`) in SKILL.md with explicit Read instructions for reference files. The previous approach silently failed because $0 resolves to the shell binary, not the skill file path. - Remove misleading skills cp block from Quick Install in README. Skills require --add-dir registration, not a file copy to ~/.claude/skills/. Closes review threads on PR #17. ShakaCode-specific content tracked in #19 and #20 for follow-up in project repos. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 175bca1 commit 78aae1b

2 files changed

Lines changed: 5 additions & 13 deletions

File tree

README.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,6 @@ cp commands/*.md ~/.claude/commands/
1919
mkdir -p ~/.claude/agents
2020
cp agents/*.md ~/.claude/agents/
2121

22-
# Install all skills
23-
mkdir -p ~/.claude/skills
24-
cp -r skills/* ~/.claude/skills/
25-
2622
# Or install specific ones
2723
cp commands/self-review.md ~/.claude/commands/
2824
cp commands/merge-commit-msg.md ~/.claude/commands/

skills/docs/SKILL.md

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,17 +7,13 @@ description: Generate, audit, or update project documentation to a professional
77

88
Generate and maintain documentation that meets or exceeds the standard set by the best open-source Rails/JS projects (Inertia Rails, Vite Ruby, Rails itself).
99

10-
## Reference: Quality Standard
10+
## Before You Start
1111

12-
!`cat "$(dirname "$0")/references/quality-standard.md"`
12+
Read these reference files (located in the `references/` subdirectory next to this SKILL.md file) before proceeding:
1313

14-
## Reference: Documentation Templates
15-
16-
!`cat "$(dirname "$0")/references/templates.md"`
17-
18-
## Reference: Competitive Landscape
19-
20-
!`cat "$(dirname "$0")/references/competitive-landscape.md"`
14+
1. **Quality Standard**`references/quality-standard.md` — tiered audit checklist (Must-Have / Expected / Differentiator)
15+
2. **Documentation Templates**`references/templates.md` — structural skeletons for each doc type
16+
3. **Competitive Landscape**`references/competitive-landscape.md` — benchmarks against peer projects
2117

2218
## Workflow
2319

0 commit comments

Comments
 (0)