Decouple dump warning flags for env-label fallback (#25)

* Decouple dump warning suppression flags

* Add combined-flag test and clarify --no-warn-env-label scope

- Add test verifying --no-warn-sensitive and --no-warn-env-label work
  independently when used together
- Clarify in help text that --no-warn-env-label only applies in
  build-matrix mode and is ignored for single-file dumps

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: justin808

CHANGELOG.md

@@ -12,6 +12,10 @@ Release and review helpers:
 
 ## [Unreleased]
 
+### Changed
+
+- Decoupled dump warning controls: `--no-warn-sensitive` now only suppresses sensitive-output warnings, and new `--no-warn-env-label` suppresses build-matrix `NODE_ENV` environment-label notes. [Issue #23](https://github.com/shakacode/pack-config-diff/issues/23)
+
 ## [v1.0.0] - 2026-03-15
 
 ### Added

README.md

@@ -93,6 +93,7 @@ pack-config-diff dump webpack.config.js --format=yaml --mode=development --outpu
 
 > Security note: `dump` output without `--clean` may include sensitive plugin/env values. Use `--clean` when sharing snapshots.
 > For trusted internal automation, add `--no-warn-sensitive` to suppress the warning.
+> For build-matrix dumps, add `--no-warn-env-label` to suppress only the `NODE_ENV` fallback environment-label note.
 
 ### More examples
 
@@ -133,6 +134,9 @@ pack-config-diff dump --build=prod --config-file=config/pack-config-diff-builds.
 
 # Dump every build in the matrix
 pack-config-diff dump --all-builds --config-file=config/pack-config-diff-builds.yml
+
+# Keep sensitive warning but suppress build NODE_ENV label note
+pack-config-diff dump --build=dev --config-file=config/pack-config-diff-builds.yml --no-warn-env-label
 ```
 
 ## What can `--left` and `--right` be?

docs/cli-reference.md

@@ -188,6 +188,12 @@ Security note: dump output without `--clean` can include sensitive values from p
 ### `--no-warn-sensitive`
 
 Suppress the warning shown when running `dump` without `--clean`. Useful for trusted internal automation where warning noise is undesirable.
+This does not affect build-matrix environment-label notes.
+
+### `--no-warn-env-label`
+
+Suppress the build-matrix note shown when metadata `environment` falls back to `build.environment.NODE_ENV`.
+This does not suppress the sensitive-output warning from `dump` without `--clean`.
 
 ## Build matrix options (`dump`)
 

src/cli.ts

@@ -45,6 +45,7 @@ interface ParsedDumpArgs {
   env: string[];
   clean: boolean;
   warnSensitive: boolean;
+  warnEnvLabel: boolean;
   build?: string;
   allBuilds: boolean;
   listBuilds: boolean;
@@ -111,6 +112,7 @@ Dump Options:
   --env=<KEY=VALUE>             Set env var before loading config (repeatable)
   --clean                       Strip plugin internals and compact functions before dump (recommended for secrets safety)
   --no-warn-sensitive           Suppress the sensitive-output warning when running dump without --clean
+  --no-warn-env-label           Suppress the build NODE_ENV environment-label note (only applies in build-matrix mode; ignored for single-file dump)
 
 Build Matrix Options (dump):
   --config-file=<file>          Build config file (default: config/pack-config-diff-builds.yml)
@@ -320,6 +322,7 @@ function parseDumpArgs(args: string[]): ParsedDumpArgs {
     env: [],
     clean: false,
     warnSensitive: true,
+    warnEnvLabel: true,
     allBuilds: false,
     listBuilds: false,
     buildConfigFile: DEFAULT_BUILD_CONFIG_FILE,
@@ -438,6 +441,9 @@ function parseDumpArgs(args: string[]): ParsedDumpArgs {
       case "--no-warn-sensitive":
         parsed.warnSensitive = false;
         break;
+      case "--no-warn-env-label":
+        parsed.warnEnvLabel = false;
+        break;
       case "--config-file":
         if (!nextValue) {
           throw new Error("Missing value for --config-file");
@@ -741,7 +747,7 @@ function runDumpFromBuildConfig(parsed: ParsedDumpArgs): number {
     try {
       const resolvedEnvironment = resolveBuildEnvironmentLabel(build, parsed);
       const envLabel = resolvedEnvironment.label;
-      if (resolvedEnvironment.source === "build-node-env" && parsed.warnSensitive) {
+      if (resolvedEnvironment.source === "build-node-env" && parsed.warnEnvLabel) {
         console.error(
           `[pack-config-diff] Using build "${build.name}" NODE_ENV="${envLabel}" as dump environment label. Pass --environment to override.`,
         );

test/cli.integration.test.js

@@ -487,7 +487,7 @@ describe("CLI integration", () => {
     expect(errorOutput).not.toContain("Warning: dump output without --clean");
   });
 
-  test("dump --build --no-warn-sensitive suppresses NODE_ENV label note", () => {
+  test("dump --build warns when metadata environment label falls back to build NODE_ENV", () => {
     const configPath = path.join(tempDir, "webpack.config.js");
     const buildConfig = path.join(tempDir, "pack-config-diff-builds.yml");
 
@@ -504,33 +504,109 @@ describe("CLI integration", () => {
       "utf8",
     );
 
-    const defaultCode = run([
+    const code = run(["dump", "--build=dev", `--config-file=${buildConfig}`, "--format=json"]);
+
+    expect(code).toBe(0);
+    const errorOutput = errorSpy.mock.calls.map((args) => String(args[0])).join("\n");
+    expect(errorOutput).toContain('Using build "dev" NODE_ENV="development" as dump environment');
+  });
+
+  test("dump --build --no-warn-sensitive keeps NODE_ENV label note", () => {
+    const configPath = path.join(tempDir, "webpack.config.js");
+    const buildConfig = path.join(tempDir, "pack-config-diff-builds.yml");
+
+    fs.writeFileSync(configPath, "module.exports = { mode: 'production' }\n", "utf8");
+    fs.writeFileSync(
+      buildConfig,
+      [
+        "builds:",
+        "  dev:",
+        `    config: "${configPath}"`,
+        "    environment:",
+        "      NODE_ENV: development",
+      ].join("\n"),
+      "utf8",
+    );
+
+    const code = run([
       "dump",
       "--build=dev",
       `--config-file=${buildConfig}`,
       "--format=json",
+      "--no-warn-sensitive",
     ]);
 
-    expect(defaultCode).toBe(0);
-    let errorOutput = errorSpy.mock.calls.map((args) => String(args[0])).join("\n");
+    expect(code).toBe(0);
+    const errorOutput = errorSpy.mock.calls.map((args) => String(args[0])).join("\n");
     expect(errorOutput).toContain('Using build "dev" NODE_ENV="development" as dump environment');
+    expect(errorOutput).not.toContain("Warning: dump output without --clean");
+  });
+
+  test("dump --build --no-warn-env-label suppresses NODE_ENV label note", () => {
+    const configPath = path.join(tempDir, "webpack.config.js");
+    const buildConfig = path.join(tempDir, "pack-config-diff-builds.yml");
+
+    fs.writeFileSync(configPath, "module.exports = { mode: 'production' }\n", "utf8");
+    fs.writeFileSync(
+      buildConfig,
+      [
+        "builds:",
+        "  dev:",
+        `    config: "${configPath}"`,
+        "    environment:",
+        "      NODE_ENV: development",
+      ].join("\n"),
+      "utf8",
+    );
+
+    const code = run([
+      "dump",
+      "--build=dev",
+      `--config-file=${buildConfig}`,
+      "--format=json",
+      "--no-warn-env-label",
+    ]);
 
-    logSpy.mockClear();
-    errorSpy.mockClear();
+    expect(code).toBe(0);
+    const errorOutput = errorSpy.mock.calls.map((args) => String(args[0])).join("\n");
+    expect(errorOutput).not.toContain(
+      'Using build "dev" NODE_ENV="development" as dump environment',
+    );
+    expect(errorOutput).toContain("Warning: dump output without --clean");
+  });
 
-    const suppressedCode = run([
+  test("dump --build --no-warn-sensitive --no-warn-env-label suppresses both warnings independently", () => {
+    const configPath = path.join(tempDir, "webpack.config.js");
+    const buildConfig = path.join(tempDir, "pack-config-diff-builds.yml");
+
+    fs.writeFileSync(configPath, "module.exports = { mode: 'production' }\n", "utf8");
+    fs.writeFileSync(
+      buildConfig,
+      [
+        "builds:",
+        "  dev:",
+        `    config: "${configPath}"`,
+        "    environment:",
+        "      NODE_ENV: development",
+      ].join("\n"),
+      "utf8",
+    );
+
+    const code = run([
       "dump",
       "--build=dev",
       `--config-file=${buildConfig}`,
       "--format=json",
       "--no-warn-sensitive",
+      "--no-warn-env-label",
     ]);
 
-    expect(suppressedCode).toBe(0);
-    errorOutput = errorSpy.mock.calls.map((args) => String(args[0])).join("\n");
+    expect(code).toBe(0);
+    const errorOutput = errorSpy.mock.calls.map((args) => String(args[0])).join("\n");
     expect(errorOutput).not.toContain(
       'Using build "dev" NODE_ENV="development" as dump environment',
     );
+    expect(errorOutput).not.toContain("Warning: dump output without --clean");
   });
 
   test("dump --annotate injects inline docs for known keys", () => {