test(integration): add above/below threshold command tests

- Add system stats fixture (CPU, memory, disk usage)
- Add 3 integration tests for above command (OK, WARNING, CRITICAL)
- Add 3 integration tests for below command (OK, WARNING, CRITICAL)

All threshold tests use realistic system metrics and validate
end-to-end behavior with HTTP mock server.

16 integration tests total now.

Author: slauger

tests/mocks/fixtures/stat/system.json

@@ -0,0 +1,15 @@
+{
+  "errorcode": 0,
+  "message": "Done",
+  "severity": "NONE",
+  "system": {
+    "cpuusagepcnt": 15.5,
+    "memoryusagepcnt": 45.2,
+    "disk0perusage": 60.8,
+    "disk1perusage": 25.3,
+    "numcpus": 4,
+    "mgmtcpuusagepcnt": 10.2,
+    "pktcpuusagepcnt": 5.3,
+    "rescpuusagepcnt": 0.0
+  }
+}

tests/test_integration_with_mock_api.py

@@ -237,6 +237,187 @@ def test_ntp_check_with_thresholds(self, mock_nitro_server):
             assert "WARNING" in result.message
 
 
+class TestAboveCommandWithMockAPI:
+    """Test above (threshold) command against mock API"""
+
+    def test_above_check_ok(self, mock_nitro_server):
+        """Test above check when value is below threshold (OK)"""
+        with NITROClient(
+            hostname=mock_nitro_server.host,
+            port=mock_nitro_server.port,
+            username="nsroot",
+            password="nsroot",
+            ssl=False,
+        ) as client:
+            # system stats have cpuusagepcnt=15.5
+            args = Namespace(
+                command="above",
+                objecttype="system",
+                objectname="cpuusagepcnt",  # Field name to check
+                warning="50",
+                critical="80",
+                filter=None,
+                limit=None,
+            )
+
+            from check_netscaler.commands.threshold import ThresholdCommand
+
+            command = ThresholdCommand(client, args)
+            result = command.execute()
+
+            assert result.status == STATE_OK
+            assert "cpuusagepcnt" in result.message
+            assert "15.5" in result.message
+
+    def test_above_check_warning(self, mock_nitro_server):
+        """Test above check when value exceeds warning threshold"""
+        with NITROClient(
+            hostname=mock_nitro_server.host,
+            port=mock_nitro_server.port,
+            username="nsroot",
+            password="nsroot",
+            ssl=False,
+        ) as client:
+            # system stats have memoryusagepcnt=45.2
+            args = Namespace(
+                command="above",
+                objecttype="system",
+                objectname="memoryusagepcnt",
+                warning="40",  # 45.2 exceeds this
+                critical="80",
+                filter=None,
+                limit=None,
+            )
+
+            from check_netscaler.commands.threshold import ThresholdCommand
+
+            command = ThresholdCommand(client, args)
+            result = command.execute()
+
+            assert result.status == STATE_WARNING
+            assert "WARNING" in result.message
+            assert "memoryusagepcnt" in result.message
+
+    def test_above_check_critical(self, mock_nitro_server):
+        """Test above check when value exceeds critical threshold"""
+        with NITROClient(
+            hostname=mock_nitro_server.host,
+            port=mock_nitro_server.port,
+            username="nsroot",
+            password="nsroot",
+            ssl=False,
+        ) as client:
+            # system stats have disk0perusage=60.8
+            args = Namespace(
+                command="above",
+                objecttype="system",
+                objectname="disk0perusage",
+                warning="40",
+                critical="59",  # 60.8 exceeds this
+                filter=None,
+                limit=None,
+            )
+
+            from check_netscaler.commands.threshold import ThresholdCommand
+
+            command = ThresholdCommand(client, args)
+            result = command.execute()
+
+            assert result.status == STATE_CRITICAL
+            assert "CRITICAL" in result.message
+            assert "disk0perusage" in result.message
+
+
+class TestBelowCommandWithMockAPI:
+    """Test below (threshold) command against mock API"""
+
+    def test_below_check_ok(self, mock_nitro_server):
+        """Test below check when value is above threshold (OK)"""
+        with NITROClient(
+            hostname=mock_nitro_server.host,
+            port=mock_nitro_server.port,
+            username="nsroot",
+            password="nsroot",
+            ssl=False,
+        ) as client:
+            # system stats have disk1perusage=25.3
+            args = Namespace(
+                command="below",
+                objecttype="system",
+                objectname="disk1perusage",
+                warning="20",  # 25.3 is above this - OK
+                critical="10",
+                filter=None,
+                limit=None,
+            )
+
+            from check_netscaler.commands.threshold import ThresholdCommand
+
+            command = ThresholdCommand(client, args)
+            result = command.execute()
+
+            assert result.status == STATE_OK
+            assert "disk1perusage" in result.message
+
+    def test_below_check_warning(self, mock_nitro_server):
+        """Test below check when value falls below warning threshold"""
+        with NITROClient(
+            hostname=mock_nitro_server.host,
+            port=mock_nitro_server.port,
+            username="nsroot",
+            password="nsroot",
+            ssl=False,
+        ) as client:
+            # system stats have disk1perusage=25.3
+            args = Namespace(
+                command="below",
+                objecttype="system",
+                objectname="disk1perusage",
+                warning="30",  # 25.3 is below this - WARNING
+                critical="10",
+                filter=None,
+                limit=None,
+            )
+
+            from check_netscaler.commands.threshold import ThresholdCommand
+
+            command = ThresholdCommand(client, args)
+            result = command.execute()
+
+            assert result.status == STATE_WARNING
+            assert "WARNING" in result.message
+            assert "disk1perusage" in result.message
+
+    def test_below_check_critical(self, mock_nitro_server):
+        """Test below check when value falls below critical threshold"""
+        with NITROClient(
+            hostname=mock_nitro_server.host,
+            port=mock_nitro_server.port,
+            username="nsroot",
+            password="nsroot",
+            ssl=False,
+        ) as client:
+            # system stats have disk1perusage=25.3
+            args = Namespace(
+                command="below",
+                objecttype="system",
+                objectname="disk1perusage",
+                warning="30",
+                critical="26",  # 25.3 is below this - CRITICAL
+                filter=None,
+                limit=None,
+            )
+
+            from check_netscaler.commands.threshold import ThresholdCommand
+
+            command = ThresholdCommand(client, args)
+            result = command.execute()
+
+            assert result.status == STATE_CRITICAL
+            assert "CRITICAL" in result.message
+            assert "disk1perusage" in result.message
+
+
 class TestLicenseCommandWithMockAPI:
     """Test license command against mock API"""