Merge pull request #32 from beatrycze-volk/functions

beatrycze-volk · web-flow · commit e766aeac3a10 · 2026-06-24T11:50:36.000+02:00
[TEST] Add void return type declarations to test helpers
diff --git a/tests/Mods/Reader/AccessConditionReaderTest.php b/tests/Mods/Reader/AccessConditionReaderTest.php
@@ -128,7 +128,7 @@ public function getNoAccessConditionsByQueryForSerialDocument()
         self::assertEmpty($accessConditions);
     }
 
-    private static function assertAccessConditionForBookDocument(AccessCondition $accessCondition)
+    private static function assertAccessConditionForBookDocument(AccessCondition $accessCondition): void
     {
         self::assertNotEmpty($accessCondition->getValue());
         self::assertEquals('Use of this public-domain resource is unrestricted.', $accessCondition->getValue());
@@ -138,7 +138,7 @@ private static function assertAccessConditionForBookDocument(AccessCondition $ac
         self::assertEmpty($accessCondition->getXlinkHref());
     }
 
-    private static function assertAccessConditionForSerialDocument(AccessCondition $accessCondition)
+    private static function assertAccessConditionForSerialDocument(AccessCondition $accessCondition): void
     {
         self::assertNotEmpty($accessCondition->getValue());
         self::assertEquals('Open Access', $accessCondition->getValue());
diff --git a/tests/Mods/Reader/ClassificationReaderTest.php b/tests/Mods/Reader/ClassificationReaderTest.php
@@ -117,7 +117,7 @@ public function getNoClassificationsByQueryForSerialDocument()
         self::assertEmpty($classifications);
     }
 
-    private static function assertFirstClassificationForBookDocument(Classification $classification)
+    private static function assertFirstClassificationForBookDocument(Classification $classification): void
     {
         self::assertNotEmpty($classification->getValue());
         self::assertEquals('PN4888.P6 A48 1999', $classification->getValue());
@@ -127,7 +127,7 @@ private static function assertFirstClassificationForBookDocument(Classification
         self::assertEmpty($classification->getUsage());
     }
 
-    private static function assertSecondClassificationForBookDocument(Classification $classification)
+    private static function assertSecondClassificationForBookDocument(Classification $classification): void
     {
         self::assertNotEmpty($classification->getValue());
         self::assertEquals('071/.3', $classification->getValue());
@@ -137,7 +137,7 @@ private static function assertSecondClassificationForBookDocument(Classification
         self::assertEmpty($classification->getGenerator());
     }
 
-    private static function assertClassificationForSerialDocument(Classification $classification)
+    private static function assertClassificationForSerialDocument(Classification $classification): void
     {
         self::assertNotEmpty($classification->getValue());
         self::assertEquals('027.7/05', $classification->getValue());
diff --git a/tests/Mods/Reader/GenreReaderTest.php b/tests/Mods/Reader/GenreReaderTest.php
@@ -156,7 +156,7 @@ public function getNoGenresByQueryForSerialDocument()
         self::assertEmpty($genres);
     }
 
-    private static function assertGenreForBookDocument(Genre $genre)
+    private static function assertGenreForBookDocument(Genre $genre): void
     {
         self::assertNotEmpty($genre->getValue());
         self::assertEquals('bibliography', $genre->getValue());
@@ -166,7 +166,7 @@ private static function assertGenreForBookDocument(Genre $genre)
         self::assertEmpty($genre->getScript());
     }
 
-    private static function assertFirstGenreForSerialDocument(Genre $genre)
+    private static function assertFirstGenreForSerialDocument(Genre $genre): void
     {
         self::assertNotEmpty($genre->getValue());
         self::assertEquals('periodical', $genre->getValue());
@@ -176,7 +176,7 @@ private static function assertFirstGenreForSerialDocument(Genre $genre)
         self::assertEmpty($genre->getTransliteration());
     }
 
-    private static function assertSecondGenreForSerialDocument(Genre $genre)
+    private static function assertSecondGenreForSerialDocument(Genre $genre): void
     {
         self::assertNotEmpty($genre->getValue());
         self::assertEquals('series', $genre->getValue());
diff --git a/tests/Mods/Reader/IdentifierReaderTest.php b/tests/Mods/Reader/IdentifierReaderTest.php
@@ -198,7 +198,7 @@ public function getNoLastIdentifierByQueryForSerialDocument()
         self::assertNull($identifier);
     }
 
-    private static function assertFirstIdentifierForBookDocument(Identifier $identifier)
+    private static function assertFirstIdentifierForBookDocument(Identifier $identifier): void
     {
         self::assertNotEmpty($identifier->getValue());
         self::assertEquals('0801486394 (pbk. : acid-free, recycled paper)', $identifier->getValue());
@@ -209,7 +209,7 @@ private static function assertFirstIdentifierForBookDocument(Identifier $identif
         self::assertFalse($identifier->isInvalid());
     }
 
-    private static function assertSecondIdentifierForBookDocument(Identifier $identifier)
+    private static function assertSecondIdentifierForBookDocument(Identifier $identifier): void
     {
         self::assertNotEmpty($identifier->getValue());
         self::assertEquals('99042030', $identifier->getValue());
@@ -220,7 +220,7 @@ private static function assertSecondIdentifierForBookDocument(Identifier $identi
         self::assertFalse($identifier->isInvalid());
     }
 
-    private static function assertFirstIdentifierForSerialDocument(Identifier $identifier)
+    private static function assertFirstIdentifierForSerialDocument(Identifier $identifier): void
     {
         self::assertNotEmpty($identifier->getValue());
         self::assertEquals('1704-8532', $identifier->getValue());
@@ -231,7 +231,7 @@ private static function assertFirstIdentifierForSerialDocument(Identifier $ident
         self::assertFalse($identifier->isInvalid());
     }
 
-    private static function assertSecondIdentifierForSerialDocument(Identifier $identifier)
+    private static function assertSecondIdentifierForSerialDocument(Identifier $identifier): void
     {
         self::assertNotEmpty($identifier->getValue());
         self::assertEquals('1525-321X', $identifier->getValue());
@@ -242,7 +242,7 @@ private static function assertSecondIdentifierForSerialDocument(Identifier $iden
         self::assertTrue($identifier->isInvalid());
     }
 
-    private static function assertThirdIdentifierForSerialDocument(Identifier $identifier)
+    private static function assertThirdIdentifierForSerialDocument(Identifier $identifier): void
     {
         self::assertNotEmpty($identifier->getValue());
         self::assertEquals('cn2002301668', $identifier->getValue());
@@ -253,7 +253,7 @@ private static function assertThirdIdentifierForSerialDocument(Identifier $ident
         self::assertFalse($identifier->isInvalid());
     }
 
-    private static function assertFourthIdentifierForSerialDocument(Identifier $identifier)
+    private static function assertFourthIdentifierForSerialDocument(Identifier $identifier): void
     {
         self::assertNotEmpty($identifier->getValue());
         self::assertEquals('ocm51090366', $identifier->getValue());
diff --git a/tests/Mods/Reader/LanguageReaderTest.php b/tests/Mods/Reader/LanguageReaderTest.php
@@ -135,7 +135,7 @@ public function getNoLanguagesByQueryForSerialDocument()
         self::assertEmpty($languages);
     }
 
-    private static function assertFirstLanguageForBookDocument(Language $language)
+    private static function assertFirstLanguageForBookDocument(Language $language): void
     {
         self::assertEmpty($language->getObjectPart());
         self::assertNotEmpty($language->getValue());
@@ -154,7 +154,7 @@ private static function assertFirstLanguageForBookDocument(Language $language)
         self::assertEquals('Latn', $scriptTerms[0]->getValue());
     }
 
-    private static function assertSecondLanguageForBookDocument(Language $language)
+    private static function assertSecondLanguageForBookDocument(Language $language): void
     {
         self::assertNotEmpty($language->getObjectPart());
         self::assertEquals('summary', $language->getObjectPart());
@@ -168,13 +168,13 @@ private static function assertSecondLanguageForBookDocument(Language $language)
         self::assertEquals('spa', $languageTerms[0]->getValue());
 
         $scriptTerms = $language->getScriptTerms();
-        self::assertNotEmpty($language->getScriptTerms());
+        self::assertNotEmpty($scriptTerms);
         self::assertEquals('code', $scriptTerms[0]->getType());
         self::assertEquals('iso15924', $scriptTerms[0]->getAuthority());
         self::assertEquals('Latn', $scriptTerms[0]->getValue());
     }
 
-    private static function assertLanguageForSerialDocument(Language $language)
+    private static function assertLanguageForSerialDocument(Language $language): void
     {
         self::assertEmpty($language->getObjectPart());
         self::assertNotEmpty($language->getValue());
diff --git a/tests/Mods/Reader/LocationReaderTest.php b/tests/Mods/Reader/LocationReaderTest.php
@@ -139,7 +139,7 @@ public function getNoLocationsByQueryForSerialDocument()
         self::assertEmpty($locations);
     }
 
-    private static function assertFirstLocationForBookDocument(Location $location)
+    private static function assertFirstLocationForBookDocument(Location $location): void
     {
         self::assertNotEmpty($location->getValue());
 
@@ -161,7 +161,7 @@ private static function assertFirstLocationForBookDocument(Location $location)
         self::assertEquals('v.1-v.2 1999-2002', $copyInformation[0]->getEnumerationAndChronologies()[0]->getValue());
     }
 
-    private static function assertSecondLocationForBookDocument(Location $location)
+    private static function assertSecondLocationForBookDocument(Location $location): void
     {
         self::assertNotEmpty($location->getValue());
 
@@ -174,7 +174,7 @@ private static function assertSecondLocationForBookDocument(Location $location)
         self::assertEquals('http://www.slub-dresden.de/some-url/SLO-0000', $urls[1]->getValue());
     }
 
-    private static function assertLocationForSerialDocument(Location $location)
+    private static function assertLocationForSerialDocument(Location $location): void
     {
         $urls = $location->getUrls();
         self::assertNotEmpty($urls);
diff --git a/tests/Mods/Reader/NameReaderTest.php b/tests/Mods/Reader/NameReaderTest.php
@@ -135,7 +135,7 @@ public function getNoNamesByQueryForSerialDocument()
         self::assertEmpty($names);
     }
 
-    private static function assertFirstNameForBookDocument(Name $name)
+    private static function assertFirstNameForBookDocument(Name $name): void
     {
         self::assertNotEmpty($name->getType());
         self::assertEquals('personal', $name->getType());
@@ -157,7 +157,7 @@ private static function assertFirstNameForBookDocument(Name $name)
         self::assertEquals('creator', $roleTerms[0]->getValue());
     }
 
-    private static function assertSecondNameForBookDocument(Name $name)
+    private static function assertSecondNameForBookDocument(Name $name): void
     {
         self::assertNotEmpty($name->getType());
         self::assertEquals('personal', $name->getType());
@@ -180,7 +180,7 @@ private static function assertSecondNameForBookDocument(Name $name)
         self::assertEquals('author', $roleTerms[0]->getValue());
     }
 
-    private static function assertNameForSerialDocument(Name $name)
+    private static function assertNameForSerialDocument(Name $name): void
     {
         self::assertNotEmpty($name->getValue());
 
diff --git a/tests/Mods/Reader/NoteReaderTest.php b/tests/Mods/Reader/NoteReaderTest.php
@@ -156,39 +156,39 @@ public function getNoNotesByQueryForSerialDocument()
         self::assertEmpty($notes);
     }
 
-    private static function assertFirstNoteForBookDocument(Note $note)
+    private static function assertFirstNoteForBookDocument(Note $note): void
     {
         self::assertNotEmpty($note->getValue());
         self::assertEquals('Eric Alterman.', $note->getValue());
         self::assertNotEmpty($note->getType());
         self::assertEquals('statement of responsibility', $note->getType());
     }
 
-    private static function assertSecondNoteForBookDocument(Note $note)
+    private static function assertSecondNoteForBookDocument(Note $note): void
     {
         self::assertNotEmpty($note->getValue());
         self::assertEquals('Includes bibliographical references (p. 291-312) and index.', $note->getValue());
         self::assertNotEmpty($note->getType());
         self::assertEquals('bibliography', $note->getType());
     }
 
-    private static function assertFirstNoteForSerialDocument(Note $note)
+    private static function assertFirstNoteForSerialDocument(Note $note): void
     {
         self::assertNotEmpty($note->getValue());
         self::assertEquals('V. 3, no. 1/2 (winter 2002)-', $note->getValue());
         self::assertNotEmpty($note->getType());
         self::assertEquals('date/sequential designation', $note->getType());
     }
 
-    private static function assertFifthNoteForSerialDocument(Note $note)
+    private static function assertFifthNoteForSerialDocument(Note $note): void
     {
         self::assertNotEmpty($note->getValue());
         self::assertEquals('Mode of access: World Wide Web.', $note->getValue());
         self::assertNotEmpty($note->getType());
         self::assertEquals('system details', $note->getType());
     }
 
-    private static function assertSixthNoteForSerialDocument(Note $note)
+    private static function assertSixthNoteForSerialDocument(Note $note): void
     {
         self::assertNotEmpty($note->getValue());
         self::assertEquals('Electronic serial in HTML format.', $note->getValue());
diff --git a/tests/Mods/Reader/OriginInfoReaderTest.php b/tests/Mods/Reader/OriginInfoReaderTest.php
@@ -120,7 +120,7 @@ public function getNoOriginInfosByQueryForSerialDocument()
         self::assertEmpty($originInfos);
     }
 
-    private static function assertFirstOriginInfoForBookDocument(OriginInfo $originInfo)
+    private static function assertFirstOriginInfoForBookDocument(OriginInfo $originInfo): void
     {
         self::assertNotEmpty($originInfo->getValue());
         self::assertNotEmpty($originInfo->getEventType());
@@ -147,7 +147,7 @@ private static function assertFirstOriginInfoForBookDocument(OriginInfo $originI
         self::assertEquals('monographic', $issuances[0]->getValue());
     }
 
-    private static function assertSecondOriginInfoForBookDocument(OriginInfo $originInfo)
+    private static function assertSecondOriginInfoForBookDocument(OriginInfo $originInfo): void
     {
         self::assertNotEmpty($originInfo->getValue());
         self::assertNotEmpty($originInfo->getEventType());
@@ -171,7 +171,7 @@ private static function assertSecondOriginInfoForBookDocument(OriginInfo $origin
         self::assertEmpty($originInfo->getIssuances());
     }
 
-    private static function assertOriginInfoForSerialDocument(OriginInfo $originInfo)
+    private static function assertOriginInfoForSerialDocument(OriginInfo $originInfo): void
     {
         self::assertNotEmpty($originInfo->getValue());
         self::assertNotEmpty($originInfo->getEventType());
diff --git a/tests/Mods/Reader/PartReaderTest.php b/tests/Mods/Reader/PartReaderTest.php
@@ -96,7 +96,7 @@ public function getNoPartsForSerialDocument()
         self::assertEmpty($parts);
     }
 
-    private static function assertFirstPartForBookDocument(Part $part)
+    private static function assertFirstPartForBookDocument(Part $part): void
     {
         self::assertNotEmpty($part->getValue());
         self::assertNotEmpty($part->getType());
@@ -127,7 +127,7 @@ private static function assertFirstPartForBookDocument(Part $part)
         self::assertEquals('Some random text', $texts[0]->getValue());
     }
 
-    private static function assertSecondPartForBookDocument(Part $part)
+    private static function assertSecondPartForBookDocument(Part $part): void
     {
         self::assertNotEmpty($part->getValue());
         self::assertNotEmpty($part->getType());
diff --git a/tests/Mods/Reader/PhysicalDescriptionReaderTest.php b/tests/Mods/Reader/PhysicalDescriptionReaderTest.php
@@ -123,7 +123,7 @@ public function getNoPhysicalDescriptionsByQueryForSerialDocument()
         self::assertEmpty($physicalDescriptions);
     }
 
-    private static function assertPhysicalDescriptionForBookDocument(PhysicalDescription $physicalDescription)
+    private static function assertPhysicalDescriptionForBookDocument(PhysicalDescription $physicalDescription): void
     {
         self::assertNotEmpty($physicalDescription->getValue());
 
@@ -140,7 +140,7 @@ private static function assertPhysicalDescriptionForBookDocument(PhysicalDescrip
         self::assertEmpty($physicalDescription->getNotes());
     }
 
-    private static function assertPhysicalDescriptionForSerialDocument(PhysicalDescription $physicalDescription)
+    private static function assertPhysicalDescriptionForSerialDocument(PhysicalDescription $physicalDescription): void
     {
         self::assertNotEmpty($physicalDescription->getValue());
         self::assertNotEmpty($physicalDescription->getForms());
diff --git a/tests/Mods/Reader/RecordInfoReaderTest.php b/tests/Mods/Reader/RecordInfoReaderTest.php
@@ -135,7 +135,7 @@ public function getNoRecordInfosByQueryForSerialDocument()
         self::assertEmpty($recordInfos);
     }
 
-    private static function assertRecordInfoForBookDocument(RecordInfo $recordInfo)
+    private static function assertRecordInfoForBookDocument(RecordInfo $recordInfo): void
     {
         self::assertNotEmpty($recordInfo->getValue());
         self::assertNotEmpty($recordInfo->getDescriptionStandards());
@@ -164,7 +164,7 @@ private static function assertRecordInfoForBookDocument(RecordInfo $recordInfo)
         self::assertStringContainsString('Converted from MARCXML to MODS', $recordInfo->getRecordOrigins()[0]->getValue());
     }
 
-    private static function assertRecordInfoForSerialDocument(RecordInfo $recordInfo)
+    private static function assertRecordInfoForSerialDocument(RecordInfo $recordInfo): void
     {
         self::assertNotEmpty($recordInfo->getValue());
         self::assertNotEmpty($recordInfo->getDescriptionStandards());
diff --git a/tests/Mods/Reader/RelatedItemReaderTest.php b/tests/Mods/Reader/RelatedItemReaderTest.php
@@ -96,7 +96,7 @@ public function getNoRelatedItemsByQueryForSerialDocument()
         self::assertEmpty($relatedItems);
     }
 
-    private static function assertRelatedItemForSerialDocument(RelatedItem $relatedItem)
+    private static function assertRelatedItemForSerialDocument(RelatedItem $relatedItem): void
     {
         self::assertNotEmpty($relatedItem->getType());
         self::assertEquals('preceding', $relatedItem->getType());
diff --git a/tests/Mods/Reader/SubjectReaderTest.php b/tests/Mods/Reader/SubjectReaderTest.php
@@ -148,7 +148,7 @@ public function getNoSubjectsByQueryForSerialDocument()
         self::assertEmpty($subjects);
     }
 
-    private static function assertFirstSubjectForBookDocument(Subject $subject)
+    private static function assertFirstSubjectForBookDocument(Subject $subject): void
     {
         self::assertNotEmpty($subject->getValue());
 
@@ -181,7 +181,7 @@ private static function assertFirstSubjectForBookDocument(Subject $subject)
         self::assertEquals('Lake District', $areas[0]->getValue());
     }
 
-    private static function assertSecondSubjectForBookDocument(Subject $subject)
+    private static function assertSecondSubjectForBookDocument(Subject $subject): void
     {
         self::assertNotEmpty($subject->getValue());
 
@@ -191,7 +191,7 @@ private static function assertSecondSubjectForBookDocument(Subject $subject)
         self::assertEquals('n-us---', $geographicCodes[0]->getValue());
     }
 
-    private static function assertFourthSubjectForBookDocument(Subject $subject)
+    private static function assertFourthSubjectForBookDocument(Subject $subject): void
     {
         self::assertNotEmpty($subject->getValue());
         self::assertEquals('lcsh', $subject->getAuthority());
@@ -206,7 +206,7 @@ private static function assertFourthSubjectForBookDocument(Subject $subject)
         self::assertEquals('United States', $geographics[0]->getValue());
     }
 
-    private static function assertEightSubjectForBookDocument(Subject $subject)
+    private static function assertEightSubjectForBookDocument(Subject $subject): void
     {
         self::assertNotEmpty($subject->getValue());
         self::assertEquals('lcsh', $subject->getAuthority());
diff --git a/tests/Mods/Reader/TableOfContentsReaderTest.php b/tests/Mods/Reader/TableOfContentsReaderTest.php
@@ -117,7 +117,7 @@ public function getNoTablesOfContentsForSerialDocument()
         self::assertEmpty($tablesOfContents);
     }
 
-    private static function assertTableOfContentsForBookDocument(TableOfContents $tableOfContents)
+    private static function assertTableOfContentsForBookDocument(TableOfContents $tableOfContents): void
     {
         self::assertNotEmpty($tableOfContents->getValue());
         self::assertEquals('Bluegrass odyssey -- Hills of Tennessee -- Sassafrass -- Muddy river -- Take your shoes off Moses -- Let Smokey Mountain smoke get in your eyes -- Farewell party -- Faded love', $tableOfContents->getValue());
diff --git a/tests/Mods/Reader/TypeOfResourceTest.php b/tests/Mods/Reader/TypeOfResourceTest.php

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ public function getNoAccessConditionsByQueryForSerialDocument()`
`128`	`128`	`self::assertEmpty($accessConditions);`
`129`	`129`	`}`
`130`	`130`
`131`		`- private static function assertAccessConditionForBookDocument(AccessCondition $accessCondition)`
	`131`	`+ private static function assertAccessConditionForBookDocument(AccessCondition $accessCondition): void`
`132`	`132`	`{`
`133`	`133`	`self::assertNotEmpty($accessCondition->getValue());`
`134`	`134`	`self::assertEquals('Use of this public-domain resource is unrestricted.', $accessCondition->getValue());`
`@@ -138,7 +138,7 @@ private static function assertAccessConditionForBookDocument(AccessCondition $ac`
`138`	`138`	`self::assertEmpty($accessCondition->getXlinkHref());`
`139`	`139`	`}`
`140`	`140`
`141`		`- private static function assertAccessConditionForSerialDocument(AccessCondition $accessCondition)`
	`141`	`+ private static function assertAccessConditionForSerialDocument(AccessCondition $accessCondition): void`
`142`	`142`	`{`
`143`	`143`	`self::assertNotEmpty($accessCondition->getValue());`
`144`	`144`	`self::assertEquals('Open Access', $accessCondition->getValue());`
Original file line number	Diff line number	Diff line change
`@@ -117,7 +117,7 @@ public function getNoClassificationsByQueryForSerialDocument()`
`117`	`117`	`self::assertEmpty($classifications);`
`118`	`118`	`}`
`119`	`119`
`120`		`- private static function assertFirstClassificationForBookDocument(Classification $classification)`
	`120`	`+ private static function assertFirstClassificationForBookDocument(Classification $classification): void`
`121`	`121`	`{`
`122`	`122`	`self::assertNotEmpty($classification->getValue());`
`123`	`123`	`self::assertEquals('PN4888.P6 A48 1999', $classification->getValue());`
`@@ -127,7 +127,7 @@ private static function assertFirstClassificationForBookDocument(Classification`
`127`	`127`	`self::assertEmpty($classification->getUsage());`
`128`	`128`	`}`
`129`	`129`
`130`		`- private static function assertSecondClassificationForBookDocument(Classification $classification)`
	`130`	`+ private static function assertSecondClassificationForBookDocument(Classification $classification): void`
`131`	`131`	`{`
`132`	`132`	`self::assertNotEmpty($classification->getValue());`
`133`	`133`	`self::assertEquals('071/.3', $classification->getValue());`
`@@ -137,7 +137,7 @@ private static function assertSecondClassificationForBookDocument(Classification`
`137`	`137`	`self::assertEmpty($classification->getGenerator());`
`138`	`138`	`}`
`139`	`139`
`140`		`- private static function assertClassificationForSerialDocument(Classification $classification)`
	`140`	`+ private static function assertClassificationForSerialDocument(Classification $classification): void`
`141`	`141`	`{`
`142`	`142`	`self::assertNotEmpty($classification->getValue());`
`143`	`143`	`self::assertEquals('027.7/05', $classification->getValue());`
Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ public function getNoGenresByQueryForSerialDocument()`
`156`	`156`	`self::assertEmpty($genres);`
`157`	`157`	`}`
`158`	`158`
`159`		`- private static function assertGenreForBookDocument(Genre $genre)`
	`159`	`+ private static function assertGenreForBookDocument(Genre $genre): void`
`160`	`160`	`{`
`161`	`161`	`self::assertNotEmpty($genre->getValue());`
`162`	`162`	`self::assertEquals('bibliography', $genre->getValue());`
`@@ -166,7 +166,7 @@ private static function assertGenreForBookDocument(Genre $genre)`
`166`	`166`	`self::assertEmpty($genre->getScript());`
`167`	`167`	`}`
`168`	`168`
`169`		`- private static function assertFirstGenreForSerialDocument(Genre $genre)`
	`169`	`+ private static function assertFirstGenreForSerialDocument(Genre $genre): void`
`170`	`170`	`{`
`171`	`171`	`self::assertNotEmpty($genre->getValue());`
`172`	`172`	`self::assertEquals('periodical', $genre->getValue());`
`@@ -176,7 +176,7 @@ private static function assertFirstGenreForSerialDocument(Genre $genre)`
`176`	`176`	`self::assertEmpty($genre->getTransliteration());`
`177`	`177`	`}`
`178`	`178`
`179`		`- private static function assertSecondGenreForSerialDocument(Genre $genre)`
	`179`	`+ private static function assertSecondGenreForSerialDocument(Genre $genre): void`
`180`	`180`	`{`
`181`	`181`	`self::assertNotEmpty($genre->getValue());`
`182`	`182`	`self::assertEquals('series', $genre->getValue());`
Original file line number	Diff line number	Diff line change
`@@ -198,7 +198,7 @@ public function getNoLastIdentifierByQueryForSerialDocument()`
`198`	`198`	`self::assertNull($identifier);`
`199`	`199`	`}`
`200`	`200`
`201`		`- private static function assertFirstIdentifierForBookDocument(Identifier $identifier)`
	`201`	`+ private static function assertFirstIdentifierForBookDocument(Identifier $identifier): void`
`202`	`202`	`{`
`203`	`203`	`self::assertNotEmpty($identifier->getValue());`
`204`	`204`	`self::assertEquals('0801486394 (pbk. : acid-free, recycled paper)', $identifier->getValue());`
`@@ -209,7 +209,7 @@ private static function assertFirstIdentifierForBookDocument(Identifier $identif`
`209`	`209`	`self::assertFalse($identifier->isInvalid());`
`210`	`210`	`}`
`211`	`211`
`212`		`- private static function assertSecondIdentifierForBookDocument(Identifier $identifier)`
	`212`	`+ private static function assertSecondIdentifierForBookDocument(Identifier $identifier): void`
`213`	`213`	`{`
`214`	`214`	`self::assertNotEmpty($identifier->getValue());`
`215`	`215`	`self::assertEquals('99042030', $identifier->getValue());`
`@@ -220,7 +220,7 @@ private static function assertSecondIdentifierForBookDocument(Identifier $identi`
`220`	`220`	`self::assertFalse($identifier->isInvalid());`
`221`	`221`	`}`
`222`	`222`
`223`		`- private static function assertFirstIdentifierForSerialDocument(Identifier $identifier)`
	`223`	`+ private static function assertFirstIdentifierForSerialDocument(Identifier $identifier): void`
`224`	`224`	`{`
`225`	`225`	`self::assertNotEmpty($identifier->getValue());`
`226`	`226`	`self::assertEquals('1704-8532', $identifier->getValue());`
`@@ -231,7 +231,7 @@ private static function assertFirstIdentifierForSerialDocument(Identifier $ident`
`231`	`231`	`self::assertFalse($identifier->isInvalid());`
`232`	`232`	`}`
`233`	`233`
`234`		`- private static function assertSecondIdentifierForSerialDocument(Identifier $identifier)`
	`234`	`+ private static function assertSecondIdentifierForSerialDocument(Identifier $identifier): void`
`235`	`235`	`{`
`236`	`236`	`self::assertNotEmpty($identifier->getValue());`
`237`	`237`	`self::assertEquals('1525-321X', $identifier->getValue());`
`@@ -242,7 +242,7 @@ private static function assertSecondIdentifierForSerialDocument(Identifier $iden`
`242`	`242`	`self::assertTrue($identifier->isInvalid());`
`243`	`243`	`}`
`244`	`244`
`245`		`- private static function assertThirdIdentifierForSerialDocument(Identifier $identifier)`
	`245`	`+ private static function assertThirdIdentifierForSerialDocument(Identifier $identifier): void`
`246`	`246`	`{`
`247`	`247`	`self::assertNotEmpty($identifier->getValue());`
`248`	`248`	`self::assertEquals('cn2002301668', $identifier->getValue());`
`@@ -253,7 +253,7 @@ private static function assertThirdIdentifierForSerialDocument(Identifier $ident`
`253`	`253`	`self::assertFalse($identifier->isInvalid());`
`254`	`254`	`}`
`255`	`255`
`256`		`- private static function assertFourthIdentifierForSerialDocument(Identifier $identifier)`
	`256`	`+ private static function assertFourthIdentifierForSerialDocument(Identifier $identifier): void`
`257`	`257`	`{`
`258`	`258`	`self::assertNotEmpty($identifier->getValue());`
`259`	`259`	`self::assertEquals('ocm51090366', $identifier->getValue());`
Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ public function getNoLanguagesByQueryForSerialDocument()`
`135`	`135`	`self::assertEmpty($languages);`
`136`	`136`	`}`
`137`	`137`
`138`		`- private static function assertFirstLanguageForBookDocument(Language $language)`
	`138`	`+ private static function assertFirstLanguageForBookDocument(Language $language): void`
`139`	`139`	`{`
`140`	`140`	`self::assertEmpty($language->getObjectPart());`
`141`	`141`	`self::assertNotEmpty($language->getValue());`
`@@ -154,7 +154,7 @@ private static function assertFirstLanguageForBookDocument(Language $language)`
`154`	`154`	`self::assertEquals('Latn', $scriptTerms[0]->getValue());`
`155`	`155`	`}`
`156`	`156`
`157`		`- private static function assertSecondLanguageForBookDocument(Language $language)`
	`157`	`+ private static function assertSecondLanguageForBookDocument(Language $language): void`
`158`	`158`	`{`
`159`	`159`	`self::assertNotEmpty($language->getObjectPart());`
`160`	`160`	`self::assertEquals('summary', $language->getObjectPart());`
`@@ -168,13 +168,13 @@ private static function assertSecondLanguageForBookDocument(Language $language)`
`168`	`168`	`self::assertEquals('spa', $languageTerms[0]->getValue());`
`169`	`169`
`170`	`170`	`$scriptTerms = $language->getScriptTerms();`
`171`		`- self::assertNotEmpty($language->getScriptTerms());`
	`171`	`+ self::assertNotEmpty($scriptTerms);`
`172`	`172`	`self::assertEquals('code', $scriptTerms[0]->getType());`
`173`	`173`	`self::assertEquals('iso15924', $scriptTerms[0]->getAuthority());`
`174`	`174`	`self::assertEquals('Latn', $scriptTerms[0]->getValue());`
`175`	`175`	`}`
`176`	`176`
`177`		`- private static function assertLanguageForSerialDocument(Language $language)`
	`177`	`+ private static function assertLanguageForSerialDocument(Language $language): void`
`178`	`178`	`{`
`179`	`179`	`self::assertEmpty($language->getObjectPart());`
`180`	`180`	`self::assertNotEmpty($language->getValue());`
Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ public function getNoLocationsByQueryForSerialDocument()`
`139`	`139`	`self::assertEmpty($locations);`
`140`	`140`	`}`
`141`	`141`
`142`		`- private static function assertFirstLocationForBookDocument(Location $location)`
	`142`	`+ private static function assertFirstLocationForBookDocument(Location $location): void`
`143`	`143`	`{`
`144`	`144`	`self::assertNotEmpty($location->getValue());`
`145`	`145`
`@@ -161,7 +161,7 @@ private static function assertFirstLocationForBookDocument(Location $location)`
`161`	`161`	`self::assertEquals('v.1-v.2 1999-2002', $copyInformation[0]->getEnumerationAndChronologies()[0]->getValue());`
`162`	`162`	`}`
`163`	`163`
`164`		`- private static function assertSecondLocationForBookDocument(Location $location)`
	`164`	`+ private static function assertSecondLocationForBookDocument(Location $location): void`
`165`	`165`	`{`
`166`	`166`	`self::assertNotEmpty($location->getValue());`
`167`	`167`
`@@ -174,7 +174,7 @@ private static function assertSecondLocationForBookDocument(Location $location)`
`174`	`174`	`self::assertEquals('http://www.slub-dresden.de/some-url/SLO-0000', $urls[1]->getValue());`
`175`	`175`	`}`
`176`	`176`
`177`		`- private static function assertLocationForSerialDocument(Location $location)`
	`177`	`+ private static function assertLocationForSerialDocument(Location $location): void`
`178`	`178`	`{`
`179`	`179`	`$urls = $location->getUrls();`
`180`	`180`	`self::assertNotEmpty($urls);`
Original file line number	Diff line number	Diff line change
`@@ -156,39 +156,39 @@ public function getNoNotesByQueryForSerialDocument()`
`156`	`156`	`self::assertEmpty($notes);`
`157`	`157`	`}`
`158`	`158`
`159`		`- private static function assertFirstNoteForBookDocument(Note $note)`
	`159`	`+ private static function assertFirstNoteForBookDocument(Note $note): void`
`160`	`160`	`{`
`161`	`161`	`self::assertNotEmpty($note->getValue());`
`162`	`162`	`self::assertEquals('Eric Alterman.', $note->getValue());`
`163`	`163`	`self::assertNotEmpty($note->getType());`
`164`	`164`	`self::assertEquals('statement of responsibility', $note->getType());`
`165`	`165`	`}`
`166`	`166`
`167`		`- private static function assertSecondNoteForBookDocument(Note $note)`
	`167`	`+ private static function assertSecondNoteForBookDocument(Note $note): void`
`168`	`168`	`{`
`169`	`169`	`self::assertNotEmpty($note->getValue());`
`170`	`170`	`self::assertEquals('Includes bibliographical references (p. 291-312) and index.', $note->getValue());`
`171`	`171`	`self::assertNotEmpty($note->getType());`
`172`	`172`	`self::assertEquals('bibliography', $note->getType());`
`173`	`173`	`}`
`174`	`174`
`175`		`- private static function assertFirstNoteForSerialDocument(Note $note)`
	`175`	`+ private static function assertFirstNoteForSerialDocument(Note $note): void`
`176`	`176`	`{`
`177`	`177`	`self::assertNotEmpty($note->getValue());`
`178`	`178`	`self::assertEquals('V. 3, no. 1/2 (winter 2002)-', $note->getValue());`
`179`	`179`	`self::assertNotEmpty($note->getType());`
`180`	`180`	`self::assertEquals('date/sequential designation', $note->getType());`
`181`	`181`	`}`
`182`	`182`
`183`		`- private static function assertFifthNoteForSerialDocument(Note $note)`
	`183`	`+ private static function assertFifthNoteForSerialDocument(Note $note): void`
`184`	`184`	`{`
`185`	`185`	`self::assertNotEmpty($note->getValue());`
`186`	`186`	`self::assertEquals('Mode of access: World Wide Web.', $note->getValue());`
`187`	`187`	`self::assertNotEmpty($note->getType());`
`188`	`188`	`self::assertEquals('system details', $note->getType());`
`189`	`189`	`}`
`190`	`190`
`191`		`- private static function assertSixthNoteForSerialDocument(Note $note)`
	`191`	`+ private static function assertSixthNoteForSerialDocument(Note $note): void`
`192`	`192`	`{`
`193`	`193`	`self::assertNotEmpty($note->getValue());`
`194`	`194`	`self::assertEquals('Electronic serial in HTML format.', $note->getValue());`
Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ public function getNoOriginInfosByQueryForSerialDocument()`
`120`	`120`	`self::assertEmpty($originInfos);`
`121`	`121`	`}`
`122`	`122`
`123`		`- private static function assertFirstOriginInfoForBookDocument(OriginInfo $originInfo)`
	`123`	`+ private static function assertFirstOriginInfoForBookDocument(OriginInfo $originInfo): void`
`124`	`124`	`{`
`125`	`125`	`self::assertNotEmpty($originInfo->getValue());`
`126`	`126`	`self::assertNotEmpty($originInfo->getEventType());`
`@@ -147,7 +147,7 @@ private static function assertFirstOriginInfoForBookDocument(OriginInfo $originI`
`147`	`147`	`self::assertEquals('monographic', $issuances[0]->getValue());`
`148`	`148`	`}`
`149`	`149`
`150`		`- private static function assertSecondOriginInfoForBookDocument(OriginInfo $originInfo)`
	`150`	`+ private static function assertSecondOriginInfoForBookDocument(OriginInfo $originInfo): void`
`151`	`151`	`{`
`152`	`152`	`self::assertNotEmpty($originInfo->getValue());`
`153`	`153`	`self::assertNotEmpty($originInfo->getEventType());`
`@@ -171,7 +171,7 @@ private static function assertSecondOriginInfoForBookDocument(OriginInfo $origin`
`171`	`171`	`self::assertEmpty($originInfo->getIssuances());`
`172`	`172`	`}`
`173`	`173`
`174`		`- private static function assertOriginInfoForSerialDocument(OriginInfo $originInfo)`
	`174`	`+ private static function assertOriginInfoForSerialDocument(OriginInfo $originInfo): void`
`175`	`175`	`{`
`176`	`176`	`self::assertNotEmpty($originInfo->getValue());`
`177`	`177`	`self::assertNotEmpty($originInfo->getEventType());`
Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ public function getNoPartsForSerialDocument()`
`96`	`96`	`self::assertEmpty($parts);`
`97`	`97`	`}`
`98`	`98`
`99`		`- private static function assertFirstPartForBookDocument(Part $part)`
	`99`	`+ private static function assertFirstPartForBookDocument(Part $part): void`
`100`	`100`	`{`
`101`	`101`	`self::assertNotEmpty($part->getValue());`
`102`	`102`	`self::assertNotEmpty($part->getType());`
`@@ -127,7 +127,7 @@ private static function assertFirstPartForBookDocument(Part $part)`
`127`	`127`	`self::assertEquals('Some random text', $texts[0]->getValue());`
`128`	`128`	`}`
`129`	`129`
`130`		`- private static function assertSecondPartForBookDocument(Part $part)`
	`130`	`+ private static function assertSecondPartForBookDocument(Part $part): void`
`131`	`131`	`{`
`132`	`132`	`self::assertNotEmpty($part->getValue());`
`133`	`133`	`self::assertNotEmpty($part->getType());`