About nil sid in "connect" event callback

[hankbao]

in "connect" event callback, sid of SocketIOClient may be nil in some circumstance. I'm not sure if that's a bug caused by some race conditions or it's designed to work that way. Any information would be appreciated. Thanks.

[nuclearace]

That's weird, I'm not exactly sure what could cause that. I'll try making a small change to master.

[hankbao]

I encountered this issue on one of my iOS projects recently. I close the socket.io client with fast set to true when the app enters background and recreate another one when the app enters foreground and then connect to the server immediately. In the connect event callback, I need to send the client sid to the server. Normally the sid is there. However in some rare condition, it could be nil.

[nuclearace]

@hankbao Have you tried the latest master?

[hankbao]

@nuclearace Could you merge the change onto carthage branch so that I can test it with my project? Thanks.

[nuclearace]

Done

[nuclearace]

Any luck?

[hankbao]

I've seen several related crash reports in previous version of my app. However current version contains the change has just been shipped. I shall feedback a few days later.

[nuclearace]

The sid can still be nil if there is no engine attacked, which should really only happen during a reconnect.

[NachoSoto]

I just encountered this issue. I'm connecting to the server with "forceWebsockets": true, and the server is receiving a nil sid on connection.

This is what I'm doing:

let options: [String: AnyObject!] = [
    "forceWebsockets": true
]

socket = SocketIOClient(socketURL: socketURL, options: options)
socket.connect()

This is all I see in my console before my server detects the missing sid:

SocketClient: Adding handler for event: error
SocketClient: Adding handler for event: connect
SocketClient: Adding engine
SocketEngine: Starting engine
SocketEngine: Handshaking

I'm using version 2.3.8.

[nuclearace]

What do you mean the server is receiving a nil sid? I thought the issue was the client's sid was still nil after connect.

[NachoSoto]

I'm using this socket.io library on the server side, and on connect, this line throws an Exception because the sid is an empty string.

Note that if I don't pass "forceWebsockets": true in options, this is not an issue. So it seems like this may be a problem with the SocketEngine?

Please let me know if I can provide more information!

[nuclearace]

Oh, there was an old issue about netty-socketio I guess this is why. Looking into it.