Commit 044e0de
fix: fire setDirty when pager fetch pipeline drains (closes #298)
When a static camera is combined with on-demand rendering, the
onDirty chain breaks during paged LOD loading because chunk fetches
complete asynchronously — outside any render frame — and nothing
signals the renderer that new data is ready to process.
Fix: call setDirty() at two points in SplatPager:
- when fetchers drains to 0 (all in-flight downloads finished)
- when processFetched() fully empties the fetched queue
The consumeLodTreeUpdates path is intentionally unchanged; SparkRenderer
already calls setDirty() there via the existing lodDirty flow.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>1 parent 5c63bd5 commit 044e0de
7 files changed
Lines changed: 36 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
| 87 | + | |
87 | 88 | | |
88 | 89 | | |
89 | 90 | | |
| |||
96 | 97 | | |
97 | 98 | | |
98 | 99 | | |
| 100 | + | |
99 | 101 | | |
100 | 102 | | |
101 | 103 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1233 | 1233 | | |
1234 | 1234 | | |
1235 | 1235 | | |
| 1236 | + | |
1236 | 1237 | | |
1237 | 1238 | | |
1238 | 1239 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
462 | 462 | | |
463 | 463 | | |
464 | 464 | | |
| 465 | + | |
465 | 466 | | |
466 | 467 | | |
467 | 468 | | |
| |||
478 | 479 | | |
479 | 480 | | |
480 | 481 | | |
| 482 | + | |
481 | 483 | | |
482 | 484 | | |
483 | 485 | | |
| |||
573 | 575 | | |
574 | 576 | | |
575 | 577 | | |
| 578 | + | |
576 | 579 | | |
577 | 580 | | |
578 | 581 | | |
| |||
1277 | 1280 | | |
1278 | 1281 | | |
1279 | 1282 | | |
| 1283 | + | |
1280 | 1284 | | |
1281 | 1285 | | |
1282 | 1286 | | |
| |||
1336 | 1340 | | |
1337 | 1341 | | |
1338 | 1342 | | |
| 1343 | + | |
1339 | 1344 | | |
1340 | 1345 | | |
1341 | 1346 | | |
| 1347 | + | |
1342 | 1348 | | |
1343 | 1349 | | |
| 1350 | + | |
1344 | 1351 | | |
1345 | 1352 | | |
1346 | 1353 | | |
| |||
0 commit comments