Make Symbol Serialisation Thread Safe#2388
Open
philip-paul-mueller wants to merge 6 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a concurrency issue introduced in PR #2366 by replacing a process-global “authoritative symbol dtype” map used during symbolic serialization with a thread-local, stack-based context, making serialization safe when multiple Python threads serialize concurrently (e.g., in GT4Py and DaCe’s own multi-threaded tests).
Changes:
- Replace the global
_SERIALIZATION_SYMBOL_DTYPESdict with athreading.local-backed context object that maintains a per-thread stack of authoritative dtype mappings. - Update
serialization_symbol_dtypes(...)to push/pop the per-thread authority instead of overwriting a global. - Update symbol printing to consult the current thread’s active authority via
_SERIALIZATION_SYMBOL_DTYPES.get().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR#2366 introduced a new global that was used during serialization. However, this fails when multiple threads are active, which is not the default mode of operation (except in GT4Py and the DaCe tests themselves).
This PR made the serialization thread safe.