From 091322a817d603df525bf12cbe308398fc02bed1 Mon Sep 17 00:00:00 2001 From: Ion Nistor Date: Wed, 13 May 2026 16:28:13 +0300 Subject: [PATCH 1/3] fix(chart): remove duplicate app.kubernetes.io/name label MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The label is already emitted by the `generic-device-plugin.labels` helper via `selectorLabels`. Having it set both literally and through the helper produces a duplicate map key in the rendered YAML. Helm tolerates that (last-wins), but strict YAML parsers (Kustomize, Flux v2 postRenderers, kubeconform, ArgoCD with strict parsing) reject the output, blocking GitOps installs that postRender the chart. matchLabels selectors are unchanged — they intentionally rely on the literal value matching what selectorLabels emits. --- charts/generic-device-plugin/templates/daemonset.yaml | 2 -- charts/generic-device-plugin/templates/podmonitor.yaml | 1 - 2 files changed, 3 deletions(-) diff --git a/charts/generic-device-plugin/templates/daemonset.yaml b/charts/generic-device-plugin/templates/daemonset.yaml index 2a8dce21..80fa704a 100644 --- a/charts/generic-device-plugin/templates/daemonset.yaml +++ b/charts/generic-device-plugin/templates/daemonset.yaml @@ -4,7 +4,6 @@ metadata: name: {{ include "generic-device-plugin.fullname" . }} namespace: kube-system labels: - app.kubernetes.io/name: generic-device-plugin {{- include "generic-device-plugin.labels" . | nindent 4 }} spec: selector: @@ -17,7 +16,6 @@ spec: {{- toYaml . | nindent 8 }} {{- end }} labels: - app.kubernetes.io/name: generic-device-plugin {{- include "generic-device-plugin.labels" . | nindent 8 }} {{- with .Values.podLabels }} {{- toYaml . | nindent 8 }} diff --git a/charts/generic-device-plugin/templates/podmonitor.yaml b/charts/generic-device-plugin/templates/podmonitor.yaml index a747d585..7ff833fb 100644 --- a/charts/generic-device-plugin/templates/podmonitor.yaml +++ b/charts/generic-device-plugin/templates/podmonitor.yaml @@ -3,7 +3,6 @@ apiVersion: monitoring.coreos.com/v1 kind: PodMonitor metadata: labels: - app.kubernetes.io/name: generic-device-plugin {{- include "generic-device-plugin.labels" . | nindent 4 }} name: {{ include "generic-device-plugin.fullname" . }} namespace: kube-system From 246cbffd847fd353fc640abdb1e1fc5e8deeed2b Mon Sep 17 00:00:00 2001 From: Ion Nistor Date: Wed, 13 May 2026 17:02:55 +0300 Subject: [PATCH 2/3] chore(chart): bump chart version to 0.1.2 Patch bump for the duplicate-label rendering fix. --- charts/generic-device-plugin/Chart.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/generic-device-plugin/Chart.yaml b/charts/generic-device-plugin/Chart.yaml index 256c1d2b..f2bae8c6 100644 --- a/charts/generic-device-plugin/Chart.yaml +++ b/charts/generic-device-plugin/Chart.yaml @@ -13,7 +13,7 @@ type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. # Versions are expected to follow Semantic Versioning (https://semver.org/) -version: 0.1.1 +version: 0.1.2 # This is the version number of the application being deployed. This version number should be # incremented each time you make changes to the application. Versions are not expected to # follow Semantic Versioning. They should reflect the version the application is using. From aca9ed9521ac502d4ffff827ab1a4cec953a4f3f Mon Sep 17 00:00:00 2001 From: Ion Nistor Date: Wed, 13 May 2026 17:15:25 +0300 Subject: [PATCH 3/3] chore(chart): regenerate README via helm-docs for 0.1.2 --- charts/generic-device-plugin/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/generic-device-plugin/README.md b/charts/generic-device-plugin/README.md index cdd09d63..7803c452 100644 --- a/charts/generic-device-plugin/README.md +++ b/charts/generic-device-plugin/README.md @@ -1,6 +1,6 @@ # generic-device-plugin -![Version: 0.1.1](https://img.shields.io/badge/Version-0.1.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.2.0](https://img.shields.io/badge/AppVersion-0.2.0-informational?style=flat-square) +![Version: 0.1.2](https://img.shields.io/badge/Version-0.1.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.2.0](https://img.shields.io/badge/AppVersion-0.2.0-informational?style=flat-square) A Helm chart for deploying the generic-device-plugin on Kubernetes