Skip to content

Remove duplicate app.kubernetes.io/name label from rendered manifests #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
squat merged 3 commits into from
May 13, 2026
Merged

Remove duplicate app.kubernetes.io/name label from rendered manifests #216

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
091322a
fix(chart): remove duplicate app.kubernetes.io/name label
inistor May 13, 2026
246cbff
chore(chart): bump chart version to 0.1.2
inistor May 13, 2026
aca9ed9
chore(chart): regenerate README via helm-docs for 0.1.2
inistor May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/generic-device-plugin/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.1
version: 0.1.2
# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
Expand Down
2 changes: 0 additions & 2 deletions charts/generic-device-plugin/templates/daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ metadata:
name: {{ include "generic-device-plugin.fullname" . }}
namespace: kube-system
labels:
app.kubernetes.io/name: generic-device-plugin
{{- include "generic-device-plugin.labels" . | nindent 4 }}
spec:
selector:
Expand All @@ -17,7 +16,6 @@ spec:
{{- toYaml . | nindent 8 }}
{{- end }}
labels:
app.kubernetes.io/name: generic-device-plugin
{{- include "generic-device-plugin.labels" . | nindent 8 }}
{{- with .Values.podLabels }}
{{- toYaml . | nindent 8 }}
Expand Down
1 change: 0 additions & 1 deletion charts/generic-device-plugin/templates/podmonitor.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ apiVersion: monitoring.coreos.com/v1
kind: PodMonitor
metadata:
labels:
app.kubernetes.io/name: generic-device-plugin
{{- include "generic-device-plugin.labels" . | nindent 4 }}
name: {{ include "generic-device-plugin.fullname" . }}
namespace: kube-system
Expand Down
Loading