Moved access-operator-api dep to systemtest

[ppatierno]

This PR is a cherry-pick of #11904 into main branch.

In summary, it fixes the issue with Maven Central not allowing -SNAPSHOT dependencies in artifacts being pushed.
For this reason the access operator API dependency (which is 0.2.0-SNAPSHOT) is moved to the systemtest directly which is the only one using it and not pushed to Maven Central.

More details on the above linked PR.

[scholzj]

Should we rather keep it as is and aim for getting rid of it soon by releasing 0.2.0? If we wanna move it, can we move the repository reference with it?

[ppatierno]

Should we rather keep it as is and aim for getting rid of it soon by releasing 0.2.0? If we wanna move it, can we move the repository reference with it?

It's a pity we didn't move the repository within the release-0.48.x PR as well (just for clarity). Anyway, too late and it's not needed.
Regarding not merging this PR, I would be happy not doing it if the access operator 0.2.0 release will be out in a reasonable time before Strimzi 0.49.0, otherwise we are going to hit the same issue. FYI @katheris
Finally, I was just wondering ... if we decide to not merging this ... are we really sure that the access-operator API module should be anyway available to the entire project (to all module via the dependency management) instead of being only where it's used (currently systemtest). Do we envisage other modules where it could be used?

[scholzj]

Finally, I was just wondering ... if we decide to not merging this ... are we really sure that the access-operator API module should be anyway available to the entire project (to all module via the dependency management) instead of being only where it's used (currently systemtest). Do we envisage other modules where it could be used?

I think we have all the other system-test only dependencies in the dependency management. It makes sure they are all aligned, you have nice centralized overview of all the dependencies there, etc. So TBH, I do not see a real reason why not have it there once we get out of the SNAPSHOT mess.

[im-konge]

Also I can have a look if I can just do it without KAO's API module. But it would not be "so nice" and maybe it would be redundant.

[scholzj]

Also I can have a look if I can just do it without KAO's API module. But it would not be "so nice" and maybe it would be redundant.

I guess you can always use the generic custom resource API. But it will probably make it harder to use (no DSL for the resources).

[scholzj]

But IIRC the plan was to do the 0.2.0 release after the JOSDK update. So hopefully it does not take long. And then I do not see any major issue why not have it in the main dependency management.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.55%. Comparing base (eac4148) to head (80d576b).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11905      +/-   ##
============================================
- Coverage     67.57%   67.55%   -0.02%     
+ Complexity     7104     7103       -1     
============================================
  Files           574      574              
  Lines         28181    28181              
  Branches       3201     3201              
============================================
- Hits          19043    19039       -4     
- Misses         7815     7818       +3     
- Partials       1323     1324       +1     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[scholzj]

/azp run regression

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[katheris]

I'm going to do an access operator release once the Strimzi 0.48.0 release is out, so we can revert this then, but I'm happy with this in the interim

[ppatierno]

So given the approvals it seems that we agree to merge this for now. At least it could save surprise if we release 0.49.0 before the access operator 0.2.0 is out. Afterwards we'll change back to the main pom if you want but not using a -SNAPSHOT dependency anymore.