refactor: address comments

felixgateru · felixgateru · commit c2e804c5b1de · 2026-04-29T10:59:24.000+03:00
Signed-off-by: Felix Gateru &lt;felix.gateru@gmail.com&gt;
diff --git a/pkg/integrations/oci/oci.go b/pkg/integrations/oci/oci.go
@@ -255,8 +255,10 @@ func (o *OCI) Cleanup(ctx core.IntegrationCleanupContext) error {
 		}
 	}
 
-	if err := client.DeleteONSTopic(metadata.TopicID); err != nil {
-		ctx.Logger.Warnf("failed to delete ONS topic %q during cleanup: %v", metadata.TopicID, err)
+	if metadata.TopicID != "" {
+		if err := client.DeleteONSTopic(metadata.TopicID); err != nil {
+			ctx.Logger.Warnf("failed to delete ONS topic %q during cleanup: %v", metadata.TopicID, err)
+		}
 	}
 
 	return nil

Original file line number	Diff line number	Diff line change
`@@ -255,8 +255,10 @@ func (o *OCI) Cleanup(ctx core.IntegrationCleanupContext) error {`
`255`	`255`	`}`
`256`	`256`	`}`
`257`	`257`
`258`		`- if err := client.DeleteONSTopic(metadata.TopicID); err != nil {`
`259`		`- ctx.Logger.Warnf("failed to delete ONS topic %q during cleanup: %v", metadata.TopicID, err)`
	`258`	`+ if metadata.TopicID != "" {`
	`259`	`+ if err := client.DeleteONSTopic(metadata.TopicID); err != nil {`
	`260`	`+ ctx.Logger.Warnf("failed to delete ONS topic %q during cleanup: %v", metadata.TopicID, err)`
	`261`	`+ }`
`260`	`262`	`}`
`261`	`263`
`262`	`264`	`return nil`