fix: review comment

Author: waltergalvao

apps/api/src/app/gitProfile/services/git-profile.service.ts

@@ -8,8 +8,6 @@ export const upsertGitProfile = async (
   const data = {
     ...input,
     avatar: input.avatar ?? undefined,
-    bio: input.bio ?? undefined,
-    location: input.location ?? undefined,
   };
 
   return getPrisma().gitProfile.upsert({

apps/api/src/app/github/services/github-installation.service.ts

@@ -32,6 +32,8 @@ export const syncGitHubInstallation = async (
     gitHubUserToGitProfileData({
       nodeId: gitUser.node_id,
       avatarUrl: gitUser.avatar_url,
+      bio: undefined,
+      location: undefined,
       ...gitUser,
     })
   );

apps/api/src/app/github/services/github-user.service.ts

@@ -1,16 +1,20 @@
 import { GitProfile, GitProvider } from "@prisma/client";
 import { GitHubUser } from "./github-user.types";
+import { Optional } from "utility-types";
 
 export const gitHubUserToGitProfileData = (
   gitHubUser: GitHubUser
-): Omit<GitProfile, "id" | "createdAt" | "updatedAt" | "userId"> => {
+): Optional<
+  Omit<GitProfile, "id" | "createdAt" | "updatedAt" | "userId">,
+  "bio" | "location"
+> => {
   return {
     gitProvider: GitProvider.GITHUB,
     gitUserId: gitHubUser.nodeId,
     handle: gitHubUser.login,
     name: gitHubUser.name || gitHubUser.login,
     avatar: gitHubUser.avatarUrl || null,
-    bio: gitHubUser.bio || null,
-    location: gitHubUser.location || null,
+    bio: gitHubUser.bio,
+    location: gitHubUser.location,
   };
 };

apps/api/src/app/github/services/github-user.types.ts

@@ -1,8 +1,8 @@
 export interface GitHubUser {
   nodeId: string;
   login: string;
-  name?: string;
+  name?: string | null;
   avatarUrl?: string;
-  bio?: string;
-  location?: string;
+  bio?: string | null;
+  location?: string | null;
 }