fix: lazy-load redis connection

Author: waltergalvao

apps/api/src/app/authorization.service.ts

@@ -1,5 +1,5 @@
 import { Workspace, Subscription } from "@prisma/client";
-import { redisConnection } from "../bull-mq/redis-connection";
+import { getRedisConnection } from "../bull-mq/redis-connection";
 import { getRandomString } from "../lib/crypto";
 import { isAppSelfHosted } from "../lib/self-host";
 import { getPrisma } from "../prisma";
@@ -31,21 +31,21 @@ export const isActiveCustomer = (
 };
 
 export const preventCSRFAttack = async (nonce: string) => {
-  const keyValue = await redisConnection.get(`oauth:state:${nonce}`);
+  const keyValue = await getRedisConnection().get(`oauth:state:${nonce}`);
 
   if (!keyValue) {
     throw new BusinessRuleException("Could not validate state", {
       severity: "info",
     });
   }
 
-  redisConnection.del(`oauth:state:${nonce}`);
+  getRedisConnection().del(`oauth:state:${nonce}`);
 };
 
 export const getTemporaryNonce = () => {
   const nonce = getRandomString(16);
 
-  redisConnection.setex(`oauth:state:${nonce}`, 60 * 5, nonce);
+  getRedisConnection().setex(`oauth:state:${nonce}`, 60 * 5, nonce);
 
   return nonce;
 };

apps/api/src/app/email/services/send-email.service.ts

@@ -1,6 +1,6 @@
 import { InitialSyncCompleteEmail } from "@sweetr/email-templates";
 import { addJob, SweetQueue } from "../../../bull-mq/queues";
-import { redisConnection } from "../../../bull-mq/redis-connection";
+import { getRedisConnection } from "../../../bull-mq/redis-connection";
 import { env, isProduction } from "../../../env";
 import { EmailOptions, EmailPayload, getEmailClient } from "../../../lib/email";
 import { logger } from "../../../lib/logger";
@@ -54,9 +54,9 @@ export const sendEmail = async (
 };
 
 export const markEmailAsSent = (key: string, expireInSeconds: number) => {
-  return redisConnection.setex(key, expireInSeconds, 1);
+  return getRedisConnection().setex(key, expireInSeconds, 1);
 };
 
 export const hasSentEmail = (key: string) => {
-  return redisConnection.exists(key);
+  return getRedisConnection().exists(key);
 };

apps/api/src/app/github/services/github-rate-limit.service.ts

@@ -1,6 +1,6 @@
 import { DelayedError, Job } from "bullmq";
 import { logger } from "../../../lib/logger";
-import { redisConnection } from "../../../bull-mq/redis-connection";
+import { getRedisConnection } from "../../../bull-mq/redis-connection";
 import { BusinessRuleException } from "../../errors/exceptions/business-rule.exception";
 import { addSeconds, getTime, isPast, fromUnixTime } from "date-fns";
 
@@ -95,7 +95,7 @@ export const withDelayedRetryOnRateLimit = async <T>(
 export const getGitInstallationRateLimitEpochInMs = async (
   installationId: number
 ) => {
-  const rateLimitResetString = await redisConnection.get(
+  const rateLimitResetString = await getRedisConnection().get(
     `github:rate-limit-reset:${installationId}`
   );
 
@@ -114,7 +114,7 @@ export const setGitInstallationRateLimitEpochInMs = async (
   installationId: number,
   rateLimitResetAtInMs: number
 ) => {
-  await redisConnection.set(
+  await getRedisConnection().set(
     `github:rate-limit-reset:${installationId}`,
     rateLimitResetAtInMs,
     // Set key to expire

apps/api/src/app/sync-batch/services/sync-batch.service.ts

@@ -12,7 +12,7 @@ import {
 } from "../../email/services/send-email.service";
 import { BusinessRuleException } from "../../errors/exceptions/business-rule.exception";
 import { findWorkspaceUsers } from "../../workspaces/services/workspace.service";
-import { redisConnection } from "../../../bull-mq/redis-connection";
+import { getRedisConnection } from "../../../bull-mq/redis-connection";
 import { UnknownException } from "../../errors/exceptions/unknown.exception";
 
 export const DEFAULT_SYNC_BATCH_SINCE_DAYS_AGO = 365; // TO-DO: Should be a workspace setting
@@ -45,7 +45,7 @@ export const setSyncBatchProgress = async (syncBatchId: number) => {
   const key = `sync-batch:${syncBatchId}:sync`;
   const sevenDaysInSeconds = 60 * 60 * 24 * 7;
 
-  await redisConnection
+  await getRedisConnection()
     .multi()
     .hset(key, { waiting: 0, done: 0 })
     .expire(key, sevenDaysInSeconds)
@@ -59,12 +59,12 @@ export const incrementSyncBatchProgress = async (
 ) => {
   const key = `sync-batch:${syncBatchId}:sync`;
 
-  await redisConnection.hincrby(key, field, amount);
+  await getRedisConnection().hincrby(key, field, amount);
 };
 
 export const getSyncBatchProgress = async (syncBatchId: number) => {
   try {
-    const progress = await redisConnection.hgetall(
+    const progress = await getRedisConnection().hgetall(
       `sync-batch:${syncBatchId}:sync`
     );
 

apps/api/src/bull-mq/queues.ts

@@ -1,5 +1,5 @@
 import { BulkJobOptions, JobsOptions, Queue } from "bullmq";
-import { redisConnection } from "./redis-connection";
+import { getRedisConnection } from "./redis-connection";
 import { logger } from "../lib/logger";
 import { bullMQErrorHandler } from "./error-handler";
 
@@ -71,7 +71,7 @@ export function initQueues(): Record<SweetQueue, Queue> {
 
   for (const queueName of Object.values(SweetQueue)) {
     const queue = new Queue(queueName, {
-      connection: redisConnection,
+      connection: getRedisConnection(),
       defaultJobOptions: {
         attempts: 3,
         backoff: {

apps/api/src/bull-mq/redis-connection.ts

@@ -1,6 +1,14 @@
 import IORedis from "ioredis";
 import { env } from "../env";
 
-export const redisConnection = new IORedis(env.REDIS_CONNECTION_STRING, {
-  maxRetriesPerRequest: null,
-});
+let redisConnection: IORedis | null = null;
+
+export function getRedisConnection(): IORedis {
+  if (!redisConnection) {
+    redisConnection = new IORedis(env.REDIS_CONNECTION_STRING, {
+      maxRetriesPerRequest: null,
+    });
+  }
+
+  return redisConnection;
+}

apps/api/src/bull-mq/workers.ts

@@ -1,5 +1,5 @@
 import { Processor, Worker, WorkerOptions } from "bullmq";
-import { redisConnection } from "./redis-connection";
+import { getRedisConnection } from "./redis-connection";
 import { SweetQueue } from "./queues";
 import {
   bullMQErrorHandler,
@@ -23,7 +23,7 @@ export const createWorker = (
       return processor(job, token);
     },
     {
-      connection: redisConnection,
+      connection: getRedisConnection(),
       removeOnComplete: { age: 1 },
       removeOnFail: {
         age: 7 * 24 * 3600, // keep up to 7 days

apps/api/src/lib/octokit.ts

@@ -2,7 +2,7 @@ import { createAppAuth, StrategyOptions } from "@octokit/auth-app";
 import { Octokit } from "octokit";
 import { graphql } from "@octokit/graphql";
 import { config } from "../config";
-import { redisConnection } from "../bull-mq/redis-connection";
+import { getRedisConnection } from "../bull-mq/redis-connection";
 
 export const octokit = new Octokit();
 
@@ -19,11 +19,11 @@ export const getAppOctoKit = () =>
 
 const redisCaching: StrategyOptions["cache"] = {
   async get(key: string) {
-    const cachedValue = await redisConnection.get(`github:token:${key}`);
+    const cachedValue = await getRedisConnection().get(`github:token:${key}`);
     return cachedValue || "";
   },
   set(key: string, value: string) {
-    redisConnection.setex(`github:token:${key}`, 3600, value);
+    getRedisConnection().setex(`github:token:${key}`, 3600, value);
   },
 };