Skip to content

Commit e790d3b

Browse files
committed
fix: pr review
1 parent 47ffd8f commit e790d3b

11 files changed

Lines changed: 27 additions & 24 deletions

apps/api/src/app/gitProfile/services/git-profile.service.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1-
import { GitProfile, Prisma } from "@prisma/client";
1+
import { GitProfile } from "@prisma/client";
22
import { getPrisma } from "../../../prisma";
3+
import { UpsertGitProfileInput } from "./git-profile.types";
34

45
export const upsertGitProfile = async (
5-
args: Prisma.GitProfileCreateInput
6+
args: UpsertGitProfileInput
67
): Promise<GitProfile> => {
78
const { gitProvider, gitUserId, handle, name, avatar, bio, location } = args;
89

apps/api/src/app/gitProfile/services/git-profile.types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { GitProvider } from "@prisma/client";
22

3-
export interface UpsertGitProfileArgs {
3+
export interface UpsertGitProfileInput {
44
gitProvider: GitProvider;
55
gitUserId: string;
66
handle: string;

apps/api/src/app/github/services/github-code-review.service.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -128,15 +128,15 @@ const fetchPullRequestReviews = async (
128128
const gitProfiles = new Map<string, GitProfile>();
129129

130130
const getGitProfileId = async (author: GitHubUser) => {
131-
if (gitProfiles.has(author.id.toString())) {
132-
return gitProfiles.get(author.id.toString())!.id;
131+
if (gitProfiles.has(author.nodeId)) {
132+
return gitProfiles.get(author.nodeId)!.id;
133133
}
134134

135135
const gitProfile = await upsertGitProfile(
136136
gitHubUserToGitProfileData(author)
137137
);
138138

139-
gitProfiles.set(author.id.toString(), gitProfile);
139+
gitProfiles.set(author.nodeId, gitProfile);
140140

141141
return gitProfile.id;
142142
};
@@ -341,7 +341,7 @@ const getReviewRequests = (nodes: any[]): ReviewRequestData[] => {
341341
createdAt: new Date(node.createdAt),
342342
deletedAt: null,
343343
author: {
344-
id: reviewerId,
344+
nodeId: reviewerId,
345345
login: node.requestedReviewer.login,
346346
name: node.requestedReviewer.name,
347347
avatarUrl: node.requestedReviewer.avatarUrl,
@@ -363,7 +363,7 @@ const getReviewRequests = (nodes: any[]): ReviewRequestData[] => {
363363
if (reviewRequest) {
364364
reviewRequest.deletedAt = new Date(node.createdAt);
365365
reviewRequest.author = {
366-
id: reviewerId,
366+
nodeId: reviewerId,
367367
login: node.requestedReviewer.login,
368368
name: node.requestedReviewer.name,
369369
avatarUrl: node.requestedReviewer.avatarUrl,

apps/api/src/app/github/services/github-installation.service.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,11 @@ export const syncGitHubInstallation = async (
2929
});
3030

3131
const gitProfile = await upsertGitProfile(
32-
gitHubUserToGitProfileData({ avatarUrl: gitUser.avatar_url, ...gitUser })
32+
gitHubUserToGitProfileData({
33+
nodeId: gitUser.node_id,
34+
avatarUrl: gitUser.avatar_url,
35+
...gitUser,
36+
})
3337
);
3438
const workspace = await upsertWorkspace(gitInstallation, gitProfile);
3539
const installation = await upsertInstallation(gitInstallation, workspace.id);

apps/api/src/app/github/services/github-member.service.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import { gitHubUserToGitProfileData } from "./github-user.service";
1313
import { GitHubUser } from "./github-user.types";
1414

1515
type GitOrganizationMember = {
16-
id: number;
16+
id: string;
1717
login: string;
1818
role: string;
1919
name?: string;
@@ -43,8 +43,8 @@ export const syncOrganizationMembers = async (
4343
);
4444

4545
const membersData: MemberData[] = gitHubMembers.map((member) => ({
46+
nodeId: member.id,
4647
...member,
47-
role: member.role,
4848
}));
4949

5050
const workspaceGitProfiles = await upsertGitProfiles(
@@ -77,8 +77,7 @@ const fetchGitHubOrganizationMembers = async (
7777
gitInstallationId: number,
7878
organizationName: string
7979
): Promise<GitOrganizationMember[]> => {
80-
const fireGraphQLRequest =
81-
await getInstallationGraphQLOctoKit(gitInstallationId);
80+
const fireGraphQLRequest = getInstallationGraphQLOctoKit(gitInstallationId);
8281

8382
const members: any[] = [];
8483
let hasNextPage = true;

apps/api/src/app/github/services/github-pull-request.service.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,10 @@ export const syncPullRequest = async ({
7878
}
7979

8080
const gitProfile = await upsertGitProfile(
81-
gitHubUserToGitProfileData(gitPrData.author)
81+
gitHubUserToGitProfileData({
82+
nodeId: gitPrData.author.id,
83+
...gitPrData.author,
84+
})
8285
);
8386
const repository = await upsertRepository(workspace.id, gitPrData.repository);
8487
const pullRequest = await upsertPullRequest(

apps/api/src/app/github/services/github-repository-pull-requests.service.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,7 @@ const fetchGitHubPullRequests = async (
8181
gitInstallationId: number,
8282
sinceDaysAgo: number | null
8383
) => {
84-
const fireGraphQLRequest =
85-
await getInstallationGraphQLOctoKit(gitInstallationId);
84+
const fireGraphQLRequest = getInstallationGraphQLOctoKit(gitInstallationId);
8685

8786
const pullRequests: any[] = [];
8887
let hasNextPage = true;

apps/api/src/app/github/services/github-repository.service.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,7 @@ export const syncGitHubRepositories = async (
5555
const fetchGitHubRepositories = async (
5656
gitInstallationId: number
5757
): Promise<RepositoryData[]> => {
58-
const fireGraphQLRequest =
59-
await getInstallationGraphQLOctoKit(gitInstallationId);
58+
const fireGraphQLRequest = getInstallationGraphQLOctoKit(gitInstallationId);
6059

6160
const repositories: any[] = [];
6261
let hasNextPage = true;

apps/api/src/app/github/services/github-team.service.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,7 @@ const fetchGitHubOrganizationTeams = async (
109109
gitInstallationId: number,
110110
organizationName: string
111111
): Promise<GitOrganizationTeam[]> => {
112-
const fireGraphQLRequest =
113-
await getInstallationGraphQLOctoKit(gitInstallationId);
112+
const fireGraphQLRequest = getInstallationGraphQLOctoKit(gitInstallationId);
114113

115114
const teams: any[] = [];
116115
let hasNextPage = true;
@@ -193,8 +192,7 @@ const fetchGitHubTeamMembers = async (
193192
teamSlug: string,
194193
startCursor: string | null
195194
): Promise<GitTeamMember[]> => {
196-
const fireGraphQLRequest =
197-
await getInstallationGraphQLOctoKit(gitInstallationId);
195+
const fireGraphQLRequest = getInstallationGraphQLOctoKit(gitInstallationId);
198196

199197
const members: any[] = [];
200198
let hasNextPage = true;

apps/api/src/app/github/services/github-user.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export const gitHubUserToGitProfileData = (
66
): Omit<GitProfile, "id" | "createdAt" | "updatedAt" | "userId"> => {
77
return {
88
gitProvider: GitProvider.GITHUB,
9-
gitUserId: gitHubUser.id.toString(),
9+
gitUserId: gitHubUser.nodeId,
1010
handle: gitHubUser.login,
1111
name: gitHubUser.name || gitHubUser.login,
1212
avatar: gitHubUser.avatarUrl || null,

0 commit comments

Comments
 (0)