Skip to content

Commit 0728576

Browse files
committed
lint fix
Signed-off-by: Magnus Ullberg <magnus@ullberg.us>
1 parent e4441e6 commit 0728576

3 files changed

Lines changed: 9 additions & 2 deletions

File tree

.golangci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ linters:
4040
- dupl
4141
- lll
4242
- errcheck
43+
- unparam
4344
paths:
4445
- third_party$
4546
- builtin$

pkg/controllers/lease_controller.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,12 @@ func (r *LeaseWatcher) handleNamespaceEvents(mgr clientProvider) {
249249
req := controller_runtime.Request{
250250
NamespacedName: client.ObjectKeyFromObject(&obj),
251251
}
252-
go r.Reconcile(context.Background(), req)
252+
go func(req controller_runtime.Request) {
253+
ctx := context.Background()
254+
if _, err := r.Reconcile(ctx, req); err != nil {
255+
logger.FromContext(ctx).Error(err, "Reconcile failed", "object", req.NamespacedName)
256+
}
257+
}(req)
253258
}
254259
}
255260
}

pkg/util/tracker.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package util
22

33
import (
4+
"log"
45
"sync"
56
)
67

@@ -83,7 +84,7 @@ func (t *NamespaceTracker) notifyListeners(event NamespaceChangeEvent) {
8384
select {
8485
case ch <- event:
8586
default:
86-
// skip if channel is full
87+
log.Printf("NamespaceTracker: dropped event for namespace %q (change: %v) because listener channel is full", event.Namespace, event.Change)
8788
}
8889
}
8990
}

0 commit comments

Comments
 (0)