fix: lint issues

Signed-off-by: Magnus Ullberg <magnus@ullberg.us>

Author: ullbergm

.devcontainer/Dockerfile

@@ -6,6 +6,14 @@ ENV PYTHONDONTWRITEBYTECODE=1 \
 # update PATH for local pip installs
 ENV PATH="$PATH:~/.local/bin"
 
+# Install golangci-lint
+RUN apt-get update && apt-get install -y --no-install-recommends ca-certificates curl git xz-utils && rm -rf /var/lib/apt/lists/* \
+    && GOLANGCI_LINT_VERSION=2.6.2 \
+    && curl -sSLO "https://github.com/golangci/golangci-lint/releases/download/v${GOLANGCI_LINT_VERSION}/golangci-lint-${GOLANGCI_LINT_VERSION}-linux-amd64.tar.gz" \
+    && tar -xzf golangci-lint-${GOLANGCI_LINT_VERSION}-linux-amd64.tar.gz -C /tmp \
+    && mv /tmp/golangci-lint-${GOLANGCI_LINT_VERSION}-linux-amd64/golangci-lint /usr/local/bin/golangci-lint \
+    && rm -rf /tmp/golangci-lint-${GOLANGCI_LINT_VERSION}-linux-amd64* golangci-lint-${GOLANGCI_LINT_VERSION}-linux-amd64.tar.gz
+
 CMD sleep infinity
 
 ENTRYPOINT []

.devcontainer/post-install.sh

@@ -3,3 +3,15 @@ set -eux
 
 # initialize pre-commit
 git config --global --add safe.directory /workspaces
+
+# Install golangci-lint if not present (useful when devcontainer not rebuilt)
+if ! command -v golangci-lint >/dev/null 2>&1; then
+	echo "golangci-lint not found, installing v2 via github release tarball"
+	apt-get update && apt-get install -y --no-install-recommends ca-certificates curl xz-utils || true
+	GOLANGCI_LINT_VERSION=2.6.2
+	curl -sSLO "https://github.com/golangci/golangci-lint/releases/download/v${GOLANGCI_LINT_VERSION}/golangci-lint-${GOLANGCI_LINT_VERSION}-linux-amd64.tar.gz" || true
+	tar -xzf golangci-lint-${GOLANGCI_LINT_VERSION}-linux-amd64.tar.gz -C /tmp || true
+	mv /tmp/golangci-lint-${GOLANGCI_LINT_VERSION}-linux-amd64/golangci-lint /usr/local/bin/golangci-lint || true
+	rm -rf /tmp/golangci-lint-${GOLANGCI_LINT_VERSION}-linux-amd64* golangci-lint-${GOLANGCI_LINT_VERSION}-linux-amd64.tar.gz || true
+	echo "golangci-lint installed"
+fi

Makefile

@@ -36,6 +36,10 @@ fmt: ## Format Go code
 vet: ## Vet Go code
 	go vet ./...
 
+.PHONY: lint
+lint: ## Run golangci-lint (requires golangci-lint installed)
+	golangci-lint run
+
 .PHONY: test
 test: tidy fmt vet ## Run tests with coverage
 	go test ./... -race -coverprofile=coverage.out

pkg/util/cleanup_job_test.go

@@ -392,9 +392,9 @@ func TestWaitForJobCompletion_Success(t *testing.T) {
 		},
 	}
 
-	client := fake.NewClientBuilder().WithScheme(scheme).WithObjects(job).Build()
+	cl := fake.NewClientBuilder().WithScheme(scheme).WithObjects(job).Build()
 
-	err := WaitForJobCompletion(context.Background(), client, job, 10*time.Second)
+	err := WaitForJobCompletion(context.Background(), cl, job, 10*time.Second)
 	if err != nil {
 		t.Errorf("Expected no error, got %v", err)
 	}
@@ -414,9 +414,9 @@ func TestWaitForJobCompletion_Timeout(t *testing.T) {
 		},
 	}
 
-	client := fake.NewClientBuilder().WithScheme(scheme).WithObjects(job).Build()
+	cl := fake.NewClientBuilder().WithScheme(scheme).WithObjects(job).Build()
 
-	err := WaitForJobCompletion(context.Background(), client, job, 1*time.Second)
+	err := WaitForJobCompletion(context.Background(), cl, job, 1*time.Second)
 	if err == nil {
 		t.Errorf("Expected timeout error, got nil")
 	}
@@ -442,9 +442,9 @@ func TestWaitForJobCompletion_Failed(t *testing.T) {
 		},
 	}
 
-	client := fake.NewClientBuilder().WithScheme(scheme).WithObjects(job).Build()
+	cl := fake.NewClientBuilder().WithScheme(scheme).WithObjects(job).Build()
 
-	err := WaitForJobCompletion(context.Background(), client, job, 10*time.Second)
+	err := WaitForJobCompletion(context.Background(), cl, job, 10*time.Second)
 	if err == nil {
 		t.Errorf("Expected job failed error, got nil")
 	}