Skip to content

Commit fd00a0a

Browse files
committed
ci: Adjust signing
1 parent 5df33dd commit fd00a0a

3 files changed

Lines changed: 29 additions & 25 deletions

File tree

.azure-pipelines.yml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -70,12 +70,15 @@ steps:
7070
inputs:
7171
filePath: build/Sign-Package.ps1
7272
env:
73-
SignClientUser: $(SignClientUser)
74-
SignClientSecret: $(SignClientSecret)
75-
SignPackageName: "Uno.PackageDiff"
76-
SignPackageDescription: "Uno.PackageDiff"
73+
VaultSignTenantId: $(VaultSignTenantId)
74+
VaultSignClientId: $(VaultSignClientId)
75+
VaultSignClientSecret: $(VaultSignClientSecret)
76+
VaultSignCertificate: $(VaultSignCertificate)
77+
VaultSignUrl: $(VaultSignUrl)
78+
SignPackageName: "Uno.Core"
79+
SignPackageDescription: "Uno.Core"
7780
ArtifactDirectory: $(build.artifactstagingdirectory)
78-
condition: and(succeeded(), not(eq(variables['build.reason'], 'PullRequest')), not(eq(variables['SignClientSecret'], '')), not(eq(variables['SignClientUser'], '')))
81+
condition: and(succeeded(), not(eq(variables['build.reason'], 'PullRequest')), not(eq(variables['VaultSignClientSecret'], '')), not(eq(variables['VaultSignClientId'], '')))
7982

8083
- task: PublishBuildArtifacts@1
8184
inputs:

build/SignClient.json

Lines changed: 0 additions & 13 deletions
This file was deleted.

build/sign-package.ps1

Lines changed: 21 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,35 @@
11
$currentDirectory = split-path $MyInvocation.MyCommand.Definition
22

33
# See if we have the ClientSecret available
4-
if ([string]::IsNullOrEmpty($env:SignClientSecret)) {
4+
if ([string]::IsNullOrEmpty($env:VaultSignClientSecret)) {
55
Write-Host "Client Secret not found, not signing packages"
66
return;
77
}
88

9-
dotnet tool install --tool-path . SignClient
9+
dotnet tool install --tool-path . sign --version 0.9.1-beta.25278.1
1010

11-
# Setup Variables we need to pass into the sign client tool
12-
$appSettings = "$currentDirectory\SignClient.json"
13-
14-
$filesToSign = Get-ChildItem -Recurse $Env:ArtifactDirectory\* -Include *.nupkg,*.vsix | Select-Object -ExpandProperty FullName
11+
$filesToSign = Get-ChildItem -Recurse $Env:ArtifactDirectory\* -Include *.nupkg | Select-Object -ExpandProperty FullName
1512

1613
foreach ($fileToSign in $filesToSign) {
1714
Write-Host "Submitting $fileToSign for signing"
18-
.\SignClient 'sign' -c $appSettings -i $fileToSign -r $env:SignClientUser -s $env:SignClientSecret -n "$env:SignPackageName" -d "$env:SignPackageDescription" -u "$env:build_repository_uri"
15+
16+
.\sign code azure-key-vault `
17+
$fileToSign `
18+
--publisher-name "$env:SignPackageName" `
19+
--description "$env:SignPackageDescription" `
20+
--description-url "$env:build_repository_uri" `
21+
--azure-key-vault-tenant-id "$env:VaultSignTenantId" `
22+
--azure-key-vault-client-id "$env:VaultSignClientId" `
23+
--azure-key-vault-client-secret "$env:VaultSignClientSecret" `
24+
--azure-key-vault-certificate "$env:VaultSignCertificate" `
25+
--azure-key-vault-url "$env:VaultSignUrl" `
26+
--verbosity information
27+
28+
if ($LASTEXITCODE -ne 0) {
29+
Write-Error "Failed to sign $fileToSign"
30+
exit $LASTEXITCODE
31+
}
32+
1933
Write-Host "Finished signing $fileToSign"
2034
}
2135

0 commit comments

Comments
 (0)