chore: Refactor wasm detection

Author: jeromelaban

specs/001-wasm-compat/spec.md

@@ -363,18 +363,24 @@ The following are explicitly **not** included in this specification:
    - Caches machine ID to avoid repeated JavaScript calls
    - No reflection, no eval, CSP-compliant
 
+5. **`src/Uno.DevTools.Telemetry/PlatformDetection.cs`**
+   - Shared utility class for platform detection
+   - Centralizes WASM/Browser detection logic
+   - Used by both Telemetry.cs and TelemetryCommonProperties.cs
+   - Eliminates code duplication and provides single source of truth
+
 ### Files Modified
 
 1. **`src/Uno.DevTools.Telemetry/Telemetry.cs`**
-   - Added `IsWasmBrowser` static field for runtime detection
+   - Uses `PlatformDetection.IsWasmBrowser` for runtime detection
    - Added `_wasmSender` field for WASM HTTP sender
    - Modified `InitializeTelemetry()` to branch on WASM vs non-WASM
    - Modified `TrackEventTask()` to use WasmHttpSender on WASM
    - Modified `TrackExceptionTask()` to use WasmHttpSender on WASM
    - Fixed `Thread.Yield()` calls to skip on WASM
 
 2. **`src/Uno.DevTools.Telemetry/TelemetryCommonProperties.cs`**
-   - Added `IsWasmBrowser` static field
+   - Uses `PlatformDetection.IsWasmBrowser` for runtime detection
    - Modified `GetMachineId()` to use WasmMachineIdHelper for persistent machine ID on WASM
    - Bypasses file I/O and NetworkInterface enumeration on WASM
 

src/Uno.DevTools.Telemetry/PlatformDetection.cs

@@ -0,0 +1,35 @@
+// Copyright (c) .NET Foundation and contributors. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+using System;
+using System.Runtime.InteropServices;
+
+namespace Uno.DevTools.Telemetry
+{
+    /// <summary>
+    /// Provides platform detection utilities for telemetry.
+    /// </summary>
+    internal static class PlatformDetection
+    {
+        /// <summary>
+        /// Cached result of WASM/Browser platform detection.
+        /// </summary>
+        public static readonly bool IsWasmBrowser = DetectWasmBrowser();
+
+        /// <summary>
+        /// Detects if the current platform is WebAssembly/Browser.
+        /// </summary>
+        private static bool DetectWasmBrowser()
+        {
+#if NET5_0_OR_GREATER
+            return OperatingSystem.IsBrowser() || OperatingSystem.IsWasi();
+#else
+            // For netstandard2.0, check RuntimeInformation.OSDescription
+            var osDescription = RuntimeInformation.OSDescription;
+            return osDescription.Contains("Browser", StringComparison.OrdinalIgnoreCase) ||
+                   osDescription.Contains("WebAssembly", StringComparison.OrdinalIgnoreCase) ||
+                   osDescription.Contains("WASI", StringComparison.OrdinalIgnoreCase);
+#endif
+        }
+    }
+}

src/Uno.DevTools.Telemetry/Telemetry.cs

@@ -18,20 +18,7 @@ namespace Uno.DevTools.Telemetry
 {
     public sealed class Telemetry : ITelemetry
     {
-        private static readonly bool IsWasmBrowser = DetectWasmBrowser();
-
-        private static bool DetectWasmBrowser()
-        {
-#if NET5_0_OR_GREATER
-            return OperatingSystem.IsBrowser() || OperatingSystem.IsWasi();
-#else
-            // For netstandard2.0, check RuntimeInformation.OSDescription
-            var osDescription = System.Runtime.InteropServices.RuntimeInformation.OSDescription;
-            return osDescription.Contains("Browser", StringComparison.OrdinalIgnoreCase) ||
-                   osDescription.Contains("WebAssembly", StringComparison.OrdinalIgnoreCase) ||
-                   osDescription.Contains("WASI", StringComparison.OrdinalIgnoreCase);
-#endif
-        }
+        private static readonly bool IsWasmBrowser = PlatformDetection.IsWasmBrowser;
 
         private readonly string? _currentSessionId;
         private TelemetryClient? _client;

src/Uno.DevTools.Telemetry/TelemetryCommonProperties.cs

@@ -28,20 +28,7 @@ namespace Uno.DevTools.Telemetry
 {
     internal sealed class TelemetryCommonProperties
     {
-        private static readonly bool IsWasmBrowser = DetectWasmBrowser();
-
-        private static bool DetectWasmBrowser()
-        {
-#if NET5_0_OR_GREATER
-            return OperatingSystem.IsBrowser() || OperatingSystem.IsWasi();
-#else
-            // For netstandard2.0, check RuntimeInformation.OSDescription
-            var osDescription = RuntimeInformation.OSDescription;
-            return osDescription.Contains("Browser", StringComparison.OrdinalIgnoreCase) ||
-                   osDescription.Contains("WebAssembly", StringComparison.OrdinalIgnoreCase) ||
-                   osDescription.Contains("WASI", StringComparison.OrdinalIgnoreCase);
-#endif
-        }
+        private static readonly bool IsWasmBrowser = PlatformDetection.IsWasmBrowser;
 
         public TelemetryCommonProperties(
             string storageDirectoryPath,