fix(modules): adds clean-up after before module deletion (#481)

Updates module removal to use an action which deletes input links before a module's removal

Author: 2xAA

src/application/worker/store/modules/modules.js

@@ -475,6 +475,36 @@ const actions = {
     }
 
     return;
+  },
+
+  async removeActiveModule({ commit }, { moduleId, writeToSwap }) {
+    const writeTo = writeToSwap ? swap : state;
+
+    const module = writeTo.active[moduleId];
+    const { meta } = module;
+
+    if (!module) {
+      throw new Error(`No module with id "${moduleId}" found`);
+    }
+
+    const metaInputIds = [
+      meta.alphaInputId,
+      meta.compositeOperationInputId,
+      meta.enabledInputId
+    ];
+    const moduleProperties = Object.values(module.$props).map(prop => prop.id);
+    const inputIds = [...moduleProperties, ...metaInputIds];
+
+    for (let i = 0, len = inputIds.length; i < len; i++) {
+      const inputId = inputIds[i];
+
+      await store.dispatch("inputs/removeInputLink", {
+        inputId,
+        writeToSwap
+      });
+    }
+
+    commit("REMOVE_ACTIVE_MODULE", { moduleId, writeToSwap });
   }
 };
 

src/components/GalleryItem.vue

@@ -77,10 +77,11 @@ export default {
     window.dispatchEvent(new Event("resize"));
   },
 
-  beforeDestroy() {
-    this.$modV.store.commit("modules/REMOVE_ACTIVE_MODULE", {
+  async beforeDestroy() {
+    await this.$modV.store.dispatch("modules/removeActiveModule", {
       moduleId: this.id
     });
+
     this.$modV.store.commit("outputs/REMOVE_AUXILLARY", this.outputId);
     this.$modV.store.commit("groups/REMOVE_MODULE_FROM_GROUP", {
       groupId: this.groupId,

src/components/Group.vue

@@ -478,7 +478,7 @@ export default {
         groupId
       });
 
-      this.$modV.store.commit("modules/REMOVE_ACTIVE_MODULE", {
+      this.$modV.store.dispatch("modules/removeActiveModule", {
         moduleId
       });
     },