More tests added

Author: vincentlaucsb

.github/workflows/coverage.yml

@@ -47,7 +47,7 @@ jobs:
         lcov --capture \
           --directory build \
           --output-file coverage.info \
-          --ignore-errors mismatch,source,empty,unused \
+          --ignore-errors mismatch,source,empty,unused,negative \
           --rc lcov_branch_coverage=1
         # Strip system headers, external deps, Catch2, and test files
         lcov --remove coverage.info \

CMakeLists.txt

@@ -34,7 +34,9 @@ else()
 
 	if(ENABLE_CODE_COVERAGE)
 		message("Code coverage instrumentation enabled")
-		set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} --coverage -Og")
+		# -fprofile-update=atomic prevents negative counter corruption when
+		# background reader threads write to the same .gcda file concurrently.
+		set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} --coverage -Og -fprofile-update=atomic")
 	endif()
 endif(MSVC)
 

tests/CLAUDE.md

@@ -61,6 +61,11 @@ Tests use RAII cleanup via [FileGuard](shared/file_guard.hpp) — see the **Shar
 
 ### Test Files
 
+> **Rule**: Every `test_*.cpp` file in `tests/` **must** appear in `target_sources()` in `tests/CMakeLists.txt`.
+> Files not listed there are silently never compiled or run.
+> When adding a new test file, add it to CMakeLists.txt in the same commit.
+> When asked to audit this, compare `ls tests/test_*.cpp` against the `target_sources()` list.
+
 - **test_error_handling.cpp**: Exception propagation from PR #282
   - Validates worker thread exceptions reach main thread
   - Tests chunk boundary corruption detection

tests/CMakeLists.txt

@@ -23,25 +23,26 @@ target_sources(csv_test
     PRIVATE
         ${CSV_INCLUDE_DIR}/csv.hpp
         main.cpp
+        test_csv_delimiter.cpp
         test_csv_field.cpp
         test_csv_field_array.cpp
         test_csv_format.cpp
         test_csv_iterator.cpp
+        test_csv_ranges.cpp
         test_csv_row.cpp
         test_csv_row_json.cpp
         test_csv_stat.cpp
+        test_data_frame.cpp
+        test_data_type.cpp
+        test_edge_cases_large_rows.cpp
+        test_error_handling.cpp
         test_guess_csv.cpp
+        test_raw_csv_data.cpp
         test_read_csv.cpp
         test_read_csv_file.cpp
-        test_write_csv.cpp
-        test_data_type.cpp
-        test_raw_csv_data.cpp
         test_round_trip.cpp
-        test_csv_delimeter.cpp
-        test_csv_ranges.cpp
-        test_error_handling.cpp
-        test_data_frame.cpp
-        test_edge_cases_large_rows.cpp
+        test_stream_sources.cpp
+        test_write_csv.cpp
     )
 target_link_libraries(csv_test csv)
 target_link_libraries(csv_test Catch2::Catch2WithMain)

tests/test_csv_delimeter.cpp tests/test_csv_delimiter.cpptests/test_csv_delimeter.cpp renamed to tests/test_csv_delimiter.cpp

@@ -93,17 +93,19 @@ TEST_CASE("Third-party stream compatibility", "[stream_sources][issue_259]") {
         REQUIRE(row_count == 2);
     }
 
-    SECTION("Non-copyable stream created in place") {
-        // Create CSVReader directly with temporary non-copyable stream
-        // This tests that the reference binding works correctly
-        CSVReader reader(NonCopyableStream("ID,Value\n1,100\n2,200\n"));
-        
+    SECTION("Non-copyable stream passed without explicit copy") {
+        // Confirms that CSVReader stores the stream by reference (not by value),
+        // so a non-copyable stream can be passed as a named lvalue.
+        // Before the fix for issue #259, this would fail to compile because
+        // the parser tried to copy the stream object internally.
+        NonCopyableStream stream("ID,Value\n1,100\n2,200\n");
+        CSVReader reader(stream);
+
         int row_count = 0;
         for (auto& row : reader) {
+            (void)row;
             row_count++;
         }
-        // Note: With temporary stream, this may not work as expected
-        // because the temporary goes out of scope. But the important
-        // thing is that it compiles without "use of deleted function" error.
+        REQUIRE(row_count == 2);
     }
 }