fix: explicitly delete CSVReader move assignment operator (contains std::mutex) (#292)

* fix: explicitly delete CSVReader move assignment (contains std::mutex)

CSVReader holds a std::mutex member (read_csv_exception_lock), which has
a deleted move assignment operator. Declaring operator=(CSVReader&&) as
= default therefore causes the function to be implicitly deleted, which
triggers -Wdefaulted-function-deleted on Clang (Apple clang 17 / LLVM).

Replace the misleading = default with an explicit = delete so the intent
is clear and the compiler diagnostic is resolved.

Fixes build warning:
  warning: explicitly defaulted move assignment operator is implicitly
  deleted [-Wdefaulted-function-deleted]

* Add clang to build matrix

---------

Co-authored-by: Vincent La <vincela9@gmail.com>

Author: digimap2000

.github/workflows/cmake-multi-platform.yml

@@ -25,7 +25,7 @@ jobs:
       matrix:
         os: [windows-latest, ubuntu-latest]
         build_type: [Release]
-        c_compiler: [gcc, cl]
+        c_compiler: [gcc, cl, clang]
         cxx_standard: [17, 20]
         include:
           - os: windows-latest
@@ -34,9 +34,14 @@ jobs:
           - os: ubuntu-latest
             c_compiler: gcc
             cpp_compiler: g++
+          - os: ubuntu-latest
+            c_compiler: clang
+            cpp_compiler: clang++
         exclude:
           - os: windows-latest
             c_compiler: gcc
+          - os: windows-latest
+            c_compiler: clang
           - os: ubuntu-latest
             c_compiler: cl
 

CMakeLists.txt

@@ -76,7 +76,7 @@ if (CSV_DEVELOPER)
     endif()
 
     # More error messages, treat warnings as errors.
-    if (UNIX)
+    if (CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang|AppleClang")
       set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} \
         -Wall -Wextra -Wpedantic -Wsign-compare \
         -Wwrite-strings -Wpointer-arith -Winit-self \

include/internal/csv_reader.hpp

@@ -205,10 +205,10 @@ namespace csv {
         }
         ///@}
 
-        CSVReader(const CSVReader&) = delete; // No copy constructor
-        CSVReader(CSVReader&&) = default;     // Move constructor
-        CSVReader& operator=(const CSVReader&) = delete; // No copy assignment
-        CSVReader& operator=(CSVReader&& other) = default;
+        CSVReader(const CSVReader&) = delete;             ///< Not copyable
+        CSVReader(CSVReader&&) = delete;                  ///< Not movable: contains std::mutex
+        CSVReader& operator=(const CSVReader&) = delete;  ///< Not copyable
+        CSVReader& operator=(CSVReader&&) = delete;       ///< Not movable: contains std::mutex
         ~CSVReader() {
             if (this->read_csv_worker.joinable()) {
                 this->read_csv_worker.join();

single_include/csv.hpp

@@ -5317,10 +5317,10 @@ namespace csv {
         }
         ///@}
 
-        CSVReader(const CSVReader&) = delete; // No copy constructor
-        CSVReader(CSVReader&&) = default;     // Move constructor
-        CSVReader& operator=(const CSVReader&) = delete; // No copy assignment
-        CSVReader& operator=(CSVReader&& other) = default;
+        CSVReader(const CSVReader&) = delete;             ///< Not copyable
+        CSVReader(CSVReader&&) = delete;                  ///< Not movable: contains std::mutex
+        CSVReader& operator=(const CSVReader&) = delete;  ///< Not copyable
+        CSVReader& operator=(CSVReader&&) = delete;       ///< Not movable: contains std::mutex
         ~CSVReader() {
             if (this->read_csv_worker.joinable()) {
                 this->read_csv_worker.join();

single_include_test/csv.hpp

@@ -5317,10 +5317,10 @@ namespace csv {
         }
         ///@}
 
-        CSVReader(const CSVReader&) = delete; // No copy constructor
-        CSVReader(CSVReader&&) = default;     // Move constructor
-        CSVReader& operator=(const CSVReader&) = delete; // No copy assignment
-        CSVReader& operator=(CSVReader&& other) = default;
+        CSVReader(const CSVReader&) = delete;             ///< Not copyable
+        CSVReader(CSVReader&&) = delete;                  ///< Not movable: contains std::mutex
+        CSVReader& operator=(const CSVReader&) = delete;  ///< Not copyable
+        CSVReader& operator=(CSVReader&&) = delete;       ///< Not movable: contains std::mutex
         ~CSVReader() {
             if (this->read_csv_worker.joinable()) {
                 this->read_csv_worker.join();