Skip to content

Commit eb02674

Browse files
committed
Update test_error_handling.cpp
1 parent 13085fd commit eb02674

1 file changed

Lines changed: 3 additions & 5 deletions

File tree

tests/test_error_handling.cpp

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,6 @@ TEST_CASE("Worker thread exceptions propagate to main thread", "[error_handling]
8888
}
8989

9090
SECTION("Exception during iteration is catchable") {
91-
bool caught = false;
92-
9391
try {
9492
// Create empty stringstream - will hit EOF immediately
9593
std::stringstream ss("");
@@ -102,7 +100,6 @@ TEST_CASE("Worker thread exceptions propagate to main thread", "[error_handling]
102100
}
103101
catch (const std::exception& e) {
104102
(void)e; // Suppress unused variable warning
105-
caught = true;
106103
}
107104

108105
// Either catches exception or completes successfully - should NOT terminate
@@ -122,9 +119,9 @@ TEST_CASE("Fields at chunk boundaries are not corrupted", "[chunking][data_integ
122119
std::ofstream out(test_file);
123120
out << "id,name,value,timestamp\n";
124121

125-
// Write enough data to cross at least one chunk boundary
122+
// Write enough data to cross two chunk boundaries
126123
// Approximate: 50 bytes per row = ~200K rows for 10MB
127-
const size_t rows_to_write = 250000;
124+
const size_t rows_to_write = 420000;
128125

129126
for (size_t i = 0; i < rows_to_write; i++) {
130127
out << i << ",name" << i << ",value" << i << "," << (1000000 + i) << "\n";
@@ -192,6 +189,7 @@ TEST_CASE("Fields at chunk boundaries are not corrupted", "[chunking][data_integ
192189

193190
// Verify we found critical rows (they weren't lost due to corruption)
194191
REQUIRE(found_critical_200k);
192+
REQUIRE(found_critical_400k);
195193

196194
// Verify we read all rows
197195
REQUIRE(row_count >= 200000);

0 commit comments

Comments
 (0)