refactor(core): centralize mock bucket names in constants module

Author: vooradis

config/constants.py

@@ -0,0 +1,5 @@
+# config/constants.py
+# Constants for mock configurations
+MOCK_BUCKET_AWS = "demo-s3"
+MOCK_BUCKET_GCP = "demo-gcp"
+MOCK_CONTAINER_AZURE = "demo-container"

main.py

@@ -17,6 +17,7 @@
 from clients.azure_client import list_blob_objects
 from tools.mock_fill import fill_s3_bucket, fill_azure_container, fill_gcp_bucket
 from tools.cleanup import cleanup_s3, cleanup_azure, cleanup_gcp
+from config.constants import MOCK_BUCKET_AWS, MOCK_BUCKET_GCP, MOCK_CONTAINER_AZURE
 
 logging.basicConfig(filename="audit.log", level=logging.INFO)
 
@@ -73,18 +74,18 @@ def audit(config):
 @click.option('--connection_string', default='UseDevelopmentStorage=true', help='Azure connection string')
 def fill(profile, connection_string):
     """Populate buckets with mock audit objects"""
-    fill_s3_bucket("demo-s3", profile=profile)
-    fill_azure_container("demo-container", connection_string=connection_string)
-    fill_gcp_bucket("demo-gcp")
+    fill_s3_bucket(MOCK_BUCKET_AWS, profile=profile)
+    fill_azure_container(MOCK_CONTAINER_AZURE, connection_string=connection_string)
+    fill_gcp_bucket(MOCK_BUCKET_GCP)
 
 @cli.command()
 @click.option('--profile', default='auditor', help='AWS profile name')
 @click.option('--connection_string', default='UseDevelopmentStorage=true', help='Azure connection string')
 def clean(profile, connection_string):
     """Remove all mock objects from buckets and containers"""
-    cleanup_s3("demo-s3", profile=profile)
-    cleanup_azure("demo-container", connection_string=connection_string)
-    cleanup_gcp("demo-gcp")
+    cleanup_s3(MOCK_BUCKET_AWS, profile=profile)
+    cleanup_azure(MOCK_CONTAINER_AZURE, connection_string=connection_string)
+    cleanup_gcp(MOCK_BUCKET_GCP)
 
 if __name__ == '__main__':
-    cli()
+    cli()

tools/cleanup.py

@@ -2,8 +2,13 @@
 from azure.storage.blob import BlobServiceClient
 from google.cloud import storage
 
+# Shared constants for mock buckets
+MOCK_BUCKET_AWS = "demo-s3"
+MOCK_CONTAINER_AZURE = "demo-container"
+MOCK_BUCKET_GCP = "demo-gcp"
+
 # 🧹 AWS S3: Remove all objects from a bucket
-def cleanup_s3(bucket: str, profile: str = "auditor") -> None:
+def cleanup_s3(bucket: str = MOCK_BUCKET_AWS, profile: str = "auditor") -> None:
     session = boto3.Session(profile_name=profile)
     s3 = session.client("s3")
     try:
@@ -15,7 +20,7 @@ def cleanup_s3(bucket: str, profile: str = "auditor") -> None:
         print(f"[ERROR] AWS cleanup failed: {e}")
 
 # 🧹 Azure Blob: Remove all blobs from a container
-def cleanup_azure(container: str, connection_string: str) -> None:
+def cleanup_azure(container: str = MOCK_CONTAINER_AZURE, connection_string: str = "UseDevelopmentStorage=true") -> None:
     try:
         client = BlobServiceClient.from_connection_string(connection_string)
         container_client = client.get_container_client(container)
@@ -27,7 +32,7 @@ def cleanup_azure(container: str, connection_string: str) -> None:
         print(f"[ERROR] Azure cleanup failed: {e}")
 
 # 🧹 GCP GCS: Remove all blobs from a bucket
-def cleanup_gcp(bucket_name: str) -> None:
+def cleanup_gcp(bucket_name: str = MOCK_BUCKET_GCP) -> None:
     try:
         client = storage.Client()
         bucket = client.get_bucket(bucket_name)
@@ -36,4 +41,4 @@ def cleanup_gcp(bucket_name: str) -> None:
             blob.delete()
         print(f"[CLEANUP] GCP → Cleared {len(blobs)} blobs from {bucket_name}")
     except Exception as e:
-        print(f"[ERROR] GCP cleanup failed: {e}")
+        print(f"[ERROR] GCP cleanup failed: {e}")

tools/mock_fill.py

@@ -2,8 +2,13 @@
 from azure.storage.blob import BlobServiceClient
 from google.cloud import storage
 
+# Shared constants for mock buckets
+MOCK_BUCKET_AWS = "demo-s3"
+MOCK_CONTAINER_AZURE = "demo-container"
+MOCK_BUCKET_GCP = "demo-gcp"
+
 # AWS S3: Upload demo object
-def fill_s3_bucket(bucket: str, profile: str = "auditor"):
+def fill_s3_bucket(bucket: str = MOCK_BUCKET_AWS, profile: str = "auditor"):
     session = boto3.Session(profile_name=profile)
     s3 = session.client("s3")
     s3.put_object(
@@ -14,16 +19,16 @@ def fill_s3_bucket(bucket: str, profile: str = "auditor"):
     print(f"[MOCK] S3 → Added demo-config.json to {bucket}")
 
 # Azure Blob: Upload demo blob
-def fill_azure_container(container: str, connection_string: str):
+def fill_azure_container(container: str = MOCK_CONTAINER_AZURE, connection_string: str = "UseDevelopmentStorage=true"):
     client = BlobServiceClient.from_connection_string(connection_string)
     blob_client = client.get_blob_client(container=container, blob="demo.json")
     blob_client.upload_blob('{"azure":"mock"}', overwrite=True)
     print(f"[MOCK] Azure → Added demo.json to {container}")
 
 # GCP GCS: Upload demo blob
-def fill_gcp_bucket(bucket_name: str):
+def fill_gcp_bucket(bucket_name: str = MOCK_BUCKET_GCP):
     client = storage.Client()
     bucket = client.get_bucket(bucket_name)
     blob = bucket.blob("demo.json")
     blob.upload_from_string('{"gcp":"mock"}')
-    print(f"[MOCK] GCP → Added demo.json to {bucket_name}")
+    print(f"[MOCK] GCP → Added demo.json to {bucket_name}")