Skip to content

Commit 1262adb

Browse files
committed
fix build on mac
1 parent 40a5d65 commit 1262adb

2 files changed

Lines changed: 8 additions & 25 deletions

File tree

.github/workflows/macos-p7zip-CI.yml

Lines changed: 3 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -13,34 +13,15 @@ jobs:
1313

1414
steps:
1515
- uses: actions/checkout@v3
16-
- name: Setup tmate session
17-
uses: mxschmitt/action-tmate@v3
1816
- name: build 7za & check
1917
run: |
20-
brew install patchelf
21-
patchelf --version
2218
mkdir macos-p7zip
2319
mkdir macos-p7zip/bin
2420
mkdir macos-p7zip/lib
2521
export PROJECT_ROOT=`pwd`
2622
cd CPP/7zip/Bundles/Alone
2723
make -f makefile.gcc
2824
INSTALL_PREFIX=$PROJECT_ROOT/macos-p7zip make -f makefile.gcc install
29-
# git clone https://github.com/jinfeihan57/p7zip_test_utils.git
30-
# cd p7zip_test_utils/check
31-
# bash check_7za.sh $PROJECT_ROOT/macos-p7zip/bin/7za
32-
# - name: build 7zz & check
33-
# run: |
34-
# export PROJECT_ROOT=`pwd`
35-
# cd CPP/7zip/Bundles/Alone2
36-
# make -f makefile.gcc
37-
# INSTALL_PREFIX=$PROJECT_ROOT/macos-p7zip make -f makefile.gcc install
38-
# git clone https://github.com/jinfeihan57/p7zip_test_utils.git
39-
# cd p7zip_test_utils/check
40-
# bash check.sh $PROJECT_ROOT/macos-p7zip/bin/7zz
41-
# - name: build 7z.so
42-
# run: |
43-
# export PROJECT_ROOT=`pwd`
44-
# cd CPP/7zip/Bundles/Format7zF
45-
# make -f makefile.gcc
46-
# INSTALL_PREFIX=$PROJECT_ROOT/macos-p7zip make -f makefile.gcc install
25+
git clone https://github.com/jinfeihan57/p7zip_test_utils.git
26+
cd p7zip_test_utils/check
27+
bash check_7za.sh $PROJECT_ROOT/macos-p7zip/bin/7za

CPP/7zip/7zip_gcc.mak

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,10 @@ CD = cd
115115

116116
ifeq ($(shell uname),Darwin)
117117
CP = cp -rf
118+
SET_RPATH = install_name_tool -add_rpath
118119
else
119120
CP = cp -drf
121+
SET_RPATH = patchelf --force-rpath --set-rpath
120122
endif
121123
MAKE = make
122124
# CFLAGS_BASE := $(CFLAGS_BASE) -D_7ZIP_ST
@@ -1367,8 +1369,8 @@ $O/libbrotlicommon.$(DYSUFFIX) $O/libbrotlienc.$(DYSUFFIX) $O/libbrotlidec.$(DYS
13671369
$(CP) brotli_build/libbrotlicommon.$(DYSUFFIX)* $O/$(7z_LIB)/$(7Z_ADDON_CODEC)
13681370
$(CP) brotli_build/libbrotlidec.$(DYSUFFIX)* $O/$(7z_LIB)/$(7Z_ADDON_CODEC)
13691371
$(CP) brotli_build/libbrotlienc.$(DYSUFFIX)* $O/$(7z_LIB)/$(7Z_ADDON_CODEC)
1370-
patchelf --force-rpath --set-rpath '$$ORIGIN/' $O/$(7z_LIB)/$(7Z_ADDON_CODEC)/libbrotlidec.$(DYSUFFIX)*
1371-
patchelf --force-rpath --set-rpath '$$ORIGIN/' $O/$(7z_LIB)/$(7Z_ADDON_CODEC)/libbrotlienc.$(DYSUFFIX)*
1372+
$(SET_RPATH) '$$ORIGIN/' $O/$(7z_LIB)/$(7Z_ADDON_CODEC)/libbrotlidec.$(DYSUFFIX)*
1373+
$(SET_RPATH) '$$ORIGIN/' $O/$(7z_LIB)/$(7Z_ADDON_CODEC)/libbrotlienc.$(DYSUFFIX)*
13721374

13731375
# Compile brotli method and Handler
13741376
$O/BrotliDecoder.o: ../../Compress/BrotliDecoder.cpp
@@ -1419,7 +1421,7 @@ $O/liblzhamdll.$(DYSUFFIX) $O/liblzhamcomp.$(DYSUFFIX) $O/liblzhamdecomp.$(DYSUF
14191421
$(CP) lzham_build/lzhamcomp/liblzhamcomp.$(DYSUFFIX)* $O/$(7z_LIB)/$(7Z_ADDON_CODEC)
14201422
$(CP) lzham_build/lzhamdecomp/liblzhamdecomp.$(DYSUFFIX)* $O/$(7z_LIB)/$(7Z_ADDON_CODEC)
14211423
$(CP) lzham_build/lzhamdll/liblzhamdll.$(DYSUFFIX)* $O/$(7z_LIB)/$(7Z_ADDON_CODEC)
1422-
patchelf --force-rpath --set-rpath '$$ORIGIN/' $O/$(7z_LIB)/$(7Z_ADDON_CODEC)/liblzhamdll.$(DYSUFFIX)*
1424+
$(SET_RPATH) '$$ORIGIN/' $O/$(7z_LIB)/$(7Z_ADDON_CODEC)/liblzhamdll.$(DYSUFFIX)*
14231425

14241426
# Compile lzham register
14251427
$O/LzhamRegister.o: ../../Compress/LzhamRegister.cpp

0 commit comments

Comments
 (0)