integrating pkgcheck fixes

Author: werkstattcodes

.github/.gitignore

@@ -0,0 +1 @@
+*.html

.github/CONTRIBUTING.md

@@ -0,0 +1,47 @@
+# Contributing to risAT
+
+This outlines how to propose a change to risAT.
+For a detailed discussion on contributing to this and other tidyverse packages, please see the [development contributing guide](https://rstd.io/tidy-contrib) and our [code review principles](https://code-review.tidyverse.org/).
+
+## Fixing typos
+
+You can fix typos, spelling mistakes, or grammatical errors in the documentation directly using the GitHub web interface, as long as the changes are made in the _source_ file. 
+This generally means you'll need to edit [roxygen2 comments](https://roxygen2.r-lib.org/articles/roxygen2.html) in an `.R`, not a `.Rd` file. 
+You can find the `.R` file that generates the `.Rd` by reading the comment in the first line.
+
+## Bigger changes
+
+If you want to make a bigger change, it's a good idea to first file an issue and make sure someone from the team agrees that it’s needed. 
+If you’ve found a bug, please file an issue that illustrates the bug with a minimal 
+[reprex](https://www.tidyverse.org/help/#reprex) (this will also help you write a unit test, if needed).
+See our guide on [how to create a great issue](https://code-review.tidyverse.org/issues/) for more advice.
+
+### Pull request process
+
+*   Fork the package and clone onto your computer. If you haven't done this before, we recommend using `usethis::create_from_github("werkstattcodes/risAT", fork = TRUE)`.
+
+*   Install all development dependencies with `devtools::install_dev_deps()`, and then make sure the package passes R CMD check by running `devtools::check()`. 
+    If R CMD check doesn't pass cleanly, it's a good idea to ask for help before continuing. 
+*   Create a Git branch for your pull request (PR). We recommend using `usethis::pr_init("brief-description-of-change")`.
+
+*   Make your changes, commit to git, and then create a PR by running `usethis::pr_push()`, and following the prompts in your browser.
+    The title of your PR should briefly describe the change.
+    The body of your PR should contain `Fixes #issue-number`.
+
+*  For user-facing changes, add a bullet to the top of `NEWS.md` (i.e. just below the first header). Follow the style described in <https://style.tidyverse.org/news.html>.
+
+### Code style
+
+*   New code should follow the tidyverse [style guide](https://style.tidyverse.org). 
+    You can use [Air](https://posit-dev.github.io/air/) to apply this style, but please don't restyle code that has nothing to do with your PR.  
+
+*  We use [roxygen2](https://cran.r-project.org/package=roxygen2), with [Markdown syntax](https://cran.r-project.org/web/packages/roxygen2/vignettes/rd-formatting.html), for documentation.  
+
+*  We use [testthat](https://cran.r-project.org/package=testthat) for unit tests. 
+   Contributions with test cases included are easier to accept.  
+
+## Code of Conduct
+
+Please note that the risAT project is released with a
+[Contributor Code of Conduct](CODE_OF_CONDUCT.md). By contributing to this
+project you agree to abide by its terms.

NAMESPACE

@@ -1,3 +1,4 @@
+importFrom(rlang,"%||%")
 export(ris_parse_search)
 export(ris_perform_case_law)
 export(ris_req_case_law)

R/ris_case_law_utils.R

@@ -242,7 +242,7 @@ ris_build_case_law_params <- function(
     # -- Sorting, filtering, and pagination --
     ImRisSeit = ris_normalize_named_interval(in_ris_since),
     SortierungSortDirection = ris_normalize_sort_direction(sort_direction),
-    SortierungSortedByColumn = sort_by,
+    SortierungSortedByColumn = ris_normalize_case_law_sort_by(application_code, sort_by),
     # The API expects "true" (lowercase string) for these boolean flags, or
     # the parameter should be absent entirely (not "false").
     # These are compound parameters under "Dokumenttyp" — the API requires

R/ris_parse_search.R

@@ -10,6 +10,7 @@
 #'
 #' @return A tibble parsed from one RIS response payload.
 #'   Includes list-columns `content_urls` and `app_metadata`.
+#' @importFrom rlang %||%
 #' @export
 #'
 #' @examples
@@ -71,7 +72,7 @@ ris_parse_search <- function(
 
   rows <- purrr::map(
     document_refs,
-    ~ ris_reference_to_tibble_row(.x, response_meta)
+    \(doc) ris_reference_to_tibble_row(doc, response_meta)
   )
 
   ris_bind_rows_harmonized(rows)
@@ -339,10 +340,6 @@ ris_to_snake_case <- function(x) {
     stringr::str_replace_all("^_+|_+$", "")
 }
 
-`%||%` <- function(x, y) {
-  if (is.null(x)) y else x
-}
-
 # ============================================================================
 # Column name translation: German snake_case -> English
 # ============================================================================

_internal/tryOut.r

@@ -0,0 +1,3 @@
+climateChange <- risAT::ris_search_vfgh(query="Folter", echo = T, search_decision_text = T)
+
+

tests/testthat/test-ris_parse_search.R

@@ -55,7 +55,7 @@ test_that("ris_parse_search returns tibble with required list-columns", {
   expect_true("content_urls" %in% names(out))
   expect_true("app_metadata" %in% names(out))
   expect_type(out$content_urls[[1]], "character")
-  expect_equal(length(out$content_urls[[1]]), 2L)
+  expect_length(out$content_urls[[1]], 2)
   expect_type(out$app_metadata[[1]], "list")
   expect_true("id" %in% names(out))
   expect_true("document_url" %in% names(out))