feat: sharpen planner and compare launch states (#93)

xiaojiou176 · web-flow · commit 1a1d0ffd1b82 · 2026-04-13T10:43:27.000-07:00
* feat: sharpen planner and compare launch states

* fix: bump pytest security patch
diff --git a/apps/dashboard/app/globals.feature.part04.css b/apps/dashboard/app/globals.feature.part04.css
@@ -332,6 +332,63 @@
   gap: var(--space-5);
 }
 
+.planner-empty-shell {
+  display: grid;
+  grid-template-columns: minmax(0, 0.92fr) minmax(0, 1.18fr);
+  gap: var(--space-4);
+  align-items: start;
+}
+
+.planner-empty-brief {
+  display: grid;
+  gap: var(--space-3);
+}
+
+.planner-empty-title {
+  font-size: var(--text-lg);
+  line-height: 1.2;
+  letter-spacing: -0.02em;
+}
+
+.planner-empty-summary {
+  color: var(--color-text-secondary);
+  font-size: var(--text-sm);
+  line-height: 1.65;
+}
+
+.planner-empty-checklist {
+  display: grid;
+  gap: var(--space-2);
+}
+
+.planner-empty-check {
+  display: grid;
+  grid-template-columns: auto minmax(0, 1fr);
+  gap: var(--space-3);
+  padding: var(--space-3) 0;
+  border-top: 1px solid var(--color-border-subtle);
+}
+
+.planner-empty-check:first-child {
+  border-top: 0;
+  padding-top: 0;
+}
+
+.planner-empty-check-body {
+  display: grid;
+  gap: var(--space-1);
+}
+
+.planner-empty-check-body strong {
+  font-size: var(--text-sm);
+}
+
+.planner-empty-check-body span {
+  color: var(--color-text-muted);
+  font-size: var(--text-xs);
+  line-height: 1.55;
+}
+
 .planner-empty-grid {
   display: grid;
   grid-template-columns: repeat(3, minmax(0, 1fr));
@@ -359,6 +416,7 @@
 
 .planner-empty-card strong {
   font-size: var(--text-base);
+  line-height: 1.3;
 }
 
 .planner-empty-card span:last-child {
@@ -438,6 +496,7 @@
 @media (max-width: 1040px) {
   .home-briefing-shell,
   .planner-hero-shell,
+  .planner-empty-shell,
   .compare-room-shell,
   .compare-primary-grid {
     grid-template-columns: 1fr;
diff --git a/apps/dashboard/app/planner/page.tsx b/apps/dashboard/app/planner/page.tsx
@@ -350,6 +350,36 @@ export default async function PlannerPage() {
   const totalUnblockTasks = rows.reduce((sum, row) => sum + row.unblockTasks.length, 0);
   const wakeAnchoredRuns = rows.filter((row) => Boolean(row.wavePlan?.wake_policy_ref)).length;
   const priority = plannerPriorityState(text, sortedRows);
+  const emptyChecklist =
+    locale === "zh-CN"
+      ? [
+          {
+            title: "锁定目标和验收口径",
+            desc: "先在 PM 入口把 objective、constraints 和 done signal 讲清楚，planner 才能开始工作。",
+          },
+          {
+            title: "把第一条 wave 送进系统",
+            desc: "没有真实 wave plan，就不会有 triage queue，也不会有 planner 的优先级排序。",
+          },
+          {
+            title: "回到 planner 做 dispatch",
+            desc: "等 planning artifact 出现后，再回来决定是去 tower、workflow case，还是 proof & replay。",
+          },
+        ]
+      : [
+          {
+            title: "Lock the objective and the done signal",
+            desc: "Write the objective, constraints, and acceptance bar in PM intake before you expect the planner to triage anything.",
+          },
+          {
+            title: "Send the first wave into the system",
+            desc: "Without a real wave plan there is no triage queue, no worker-contract posture, and no planner priority order.",
+          },
+          {
+            title: "Return here for dispatch",
+            desc: "Once the planning artifacts exist, come back here to choose whether the next move belongs in tower, workflow cases, or proof.",
+          },
+        ];
 
   return (
     <main className="grid" aria-labelledby="planner-page-title">
@@ -424,26 +454,42 @@ export default async function PlannerPage() {
 
       {rows.length === 0 ? (
         <Card className="planner-empty-stage">
-          <div className="empty-state-stack">
-            <span className="muted">{text.empty}</span>
-            <span className="mono muted">{text.note}</span>
-          </div>
-          <div className="planner-empty-grid">
-            <Link href="/pm" className="planner-empty-card">
-              <span className="cell-sub mono muted">01</span>
+          <div className="planner-empty-shell">
+            <div className="planner-empty-brief">
+              <span className="cell-sub mono muted">Planner launch checklist</span>
+              <strong className="planner-empty-title">
+                {locale === "zh-CN" ? "先把第一条规划 wave 发车，再回来做真正的 triage。" : "Start the first planning wave, then come back for real triage."}
+              </strong>
+              <p className="planner-empty-summary">{text.note}</p>
+              <div className="planner-empty-checklist" aria-label="Planner launch checklist">
+                {emptyChecklist.map((item, index) => (
+                  <div key={item.title} className="planner-empty-check">
+                    <span className="cell-sub mono muted">{String(index + 1).padStart(2, "0")}</span>
+                    <div className="planner-empty-check-body">
+                      <strong>{item.title}</strong>
+                      <span>{item.desc}</span>
+                    </div>
+                  </div>
+                ))}
+              </div>
+            </div>
+            <div className="planner-empty-grid">
+              <Link href="/pm" className="planner-empty-card">
+                <span className="cell-sub mono muted">DISPATCH · 01</span>
               <strong>{text.openPm}</strong>
               <span>{text.title === "规划桌" ? "先把第一条目标、约束和验收口径写清，再回来让 planner desk 真正开机。" : "Start the first wave from PM intake, then return here once the planning surface exists."}</span>
-            </Link>
-            <Link href="/command-tower" className="planner-empty-card">
-              <span className="cell-sub mono muted">02</span>
+              </Link>
+              <Link href="/command-tower" className="planner-empty-card">
+                <span className="cell-sub mono muted">OBSERVE · 02</span>
               <strong>{text.openTower}</strong>
               <span>{text.title === "规划桌" ? "如果系统已经在跑，只是规划产物还没挂出来，就先回 tower 看当前谁在动。" : "If work is already running but planning artifacts are missing, scan the tower before you dispatch anything else."}</span>
-            </Link>
-            <Link href="/workflows" className="planner-empty-card">
-              <span className="cell-sub mono muted">03</span>
+              </Link>
+              <Link href="/workflows" className="planner-empty-card">
+                <span className="cell-sub mono muted">RESUME · 03</span>
               <strong>{text.openWorkflow}</strong>
               <span>{text.title === "规划桌" ? "Workflow Case 是 durable state，不是首页解释文；当 planning row 出现后，回这里继续追。" : "Workflow Cases keep the durable state once the planner row becomes real."}</span>
-            </Link>
+              </Link>
+            </div>
           </div>
         </Card>
       ) : (
diff --git a/apps/dashboard/app/runs/[id]/compare/page.tsx b/apps/dashboard/app/runs/[id]/compare/page.tsx
@@ -77,6 +77,23 @@ function compareDecision(copy: Record<string, unknown>): {
   };
 }
 
+function observationSignalCards(): Array<{ label: string; value: string }> {
+  return [
+    { label: "Compare report", value: "Missing" },
+    { label: "Evidence posture", value: "Unavailable" },
+    { label: "Next move", value: "Replay compare" },
+  ];
+}
+
+function observationDeltaRows(): Array<{ label: string; value: string }> {
+  return [
+    { label: "Compare posture", value: "Awaiting report" },
+    { label: "Evidence chain", value: "Unavailable" },
+    { label: "LLM params", value: "Unavailable" },
+    { label: "LLM snapshot", value: "Unavailable" },
+  ];
+}
+
 export default async function RunComparePage({
   params,
 }: {
@@ -93,6 +110,16 @@ export default async function RunComparePage({
   const compareSummary = asRecord(runCompareReport.compare_summary);
   const decision = compareDecision(compareSummary);
   const hasCompareReport = Object.keys(runCompareReport).length > 0;
+  const signalCards = hasCompareReport
+    ? [
+        { label: "Hash deltas", value: compareSummary.mismatched_count },
+        { label: "Artifact gaps", value: compareSummary.missing_count },
+        { label: "Unexpected extras", value: compareSummary.extra_count },
+        { label: "Report gaps", value: compareSummary.missing_reports_count },
+        { label: "Check failures", value: compareSummary.failed_report_checks_count },
+      ]
+    : observationSignalCards();
+  const deltaRows = hasCompareReport ? decision.keyDeltas : observationDeltaRows();
   const evidenceStatus = hasCompareReport ? (asBoolean(compareSummary.evidence_ok) ? "OK" : "Needs review") : "Unavailable";
   const llmParamsStatus = hasCompareReport ? (asBoolean(compareSummary.llm_params_ok) ? "OK" : "Changed") : "Unavailable";
   const llmSnapshotStatus = hasCompareReport ? (asBoolean(compareSummary.llm_snapshot_ok) ? "OK" : "Changed") : "Unavailable";
@@ -146,16 +173,10 @@ export default async function RunComparePage({
             <h2 className="section-title">Decision summary</h2>
             <p>{displaySummary}</p>
             <div className="compare-signal-grid" aria-label="Compare signal highlights">
-              {[
-                { label: "Hash deltas", value: compareSummary.mismatched_count },
-                { label: "Artifact gaps", value: compareSummary.missing_count },
-                { label: "Unexpected extras", value: compareSummary.extra_count },
-                { label: "Report gaps", value: compareSummary.missing_reports_count },
-                { label: "Check failures", value: compareSummary.failed_report_checks_count },
-              ].map((item) => (
+              {signalCards.map((item) => (
                 <div key={item.label} className="compare-signal-card">
                   <span className="cell-sub mono muted">{item.label}</span>
-                  <strong>{String(item.value ?? 0)}</strong>
+                  <strong>{String(item.value)}</strong>
                 </div>
               ))}
             </div>
@@ -185,7 +206,7 @@ export default async function RunComparePage({
           <Card className="compare-delta-card">
             <h3>Key deltas</h3>
             <div className="data-list">
-              {decision.keyDeltas.map((item) => (
+              {deltaRows.map((item) => (
                 <div key={item.label} className="data-list-row">
                   <span className="data-list-label">{item.label}</span>
                   <span className="data-list-value mono">{String(item.value)}</span>
diff --git a/apps/dashboard/tests/planner_page.test.tsx b/apps/dashboard/tests/planner_page.test.tsx
@@ -116,7 +116,9 @@ describe("planner page", () => {
     render(await PlannerPage());
 
     expect(screen.getByText("Seed the first planning wave")).toBeInTheDocument();
-    expect(screen.getByText("No planning artifacts are visible yet.")).toBeInTheDocument();
+    expect(screen.getByText("Planner launch checklist")).toBeInTheDocument();
+    expect(screen.getByText("Start the first planning wave, then come back for real triage.")).toBeInTheDocument();
+    expect(screen.getByText("Lock the objective and the done signal")).toBeInTheDocument();
     expect(screen.getByRole("link", { name: "Open PM intake" })).toHaveAttribute("href", "/pm");
     expect(screen.getByRole("link", { name: "Open Command Tower" })).toHaveAttribute("href", "/command-tower");
     expect(screen.getByRole("link", { name: "Open Workflow Cases" })).toHaveAttribute("href", "/workflows");
diff --git a/apps/dashboard/tests/run_compare_page.test.tsx b/apps/dashboard/tests/run_compare_page.test.tsx
@@ -138,5 +138,9 @@ describe("run compare decision surface", () => {
     expect(screen.getAllByText(/run replay compare, and refresh this page/i).length).toBeGreaterThan(0);
     expect(screen.getByText("Operator choreography")).toBeInTheDocument();
     expect(screen.getByText(/Evidence chain: Unavailable/i)).toBeInTheDocument();
+    expect(screen.getByText("Compare posture")).toBeInTheDocument();
+    expect(screen.getByText("Awaiting report")).toBeInTheDocument();
+    expect(screen.getByText("Compare report")).toBeInTheDocument();
+    expect(screen.getByText("Replay compare")).toBeInTheDocument();
   });
 });
diff --git a/apps/desktop/src/pages/RunComparePage.tsx b/apps/desktop/src/pages/RunComparePage.tsx
@@ -27,6 +27,23 @@ function asBoolean(value: JsonValue | undefined): boolean {
   return value === true;
 }
 
+function observationSignalCards() {
+  return [
+    { label: "Compare report", value: "Missing" },
+    { label: "Evidence posture", value: "Unavailable" },
+    { label: "Next move", value: "Replay compare" },
+  ];
+}
+
+function observationDeltaRows() {
+  return [
+    { label: "Compare posture", value: "Awaiting report" },
+    { label: "Evidence chain", value: "Unavailable" },
+    { label: "LLM params", value: "Unavailable" },
+    { label: "LLM snapshot", value: "Unavailable" },
+  ];
+}
+
 export function RunComparePage({ runId, onBack }: Props) {
   const [run, setRun] = useState<RunDetailPayload | null>(null);
   const [reports, setReports] = useState<ReportRecord[]>([]);
@@ -101,6 +118,25 @@ export function RunComparePage({ runId, onBack }: Props) {
   const evidenceStatus = hasCompareReport ? (evidenceOk ? "OK" : "Needs review") : "Unavailable";
   const llmParamsStatus = hasCompareReport ? (llmParamsOk ? "OK" : "Changed") : "Unavailable";
   const llmSnapshotStatus = hasCompareReport ? (llmSnapshotOk ? "OK" : "Changed") : "Unavailable";
+  const signalCards = hasCompareReport
+    ? [
+        { label: "Mismatched hashes", value: String(mismatchedCount) },
+        { label: "Missing artifacts", value: String(missingCount) },
+        { label: "Failed report checks", value: String(failedChecksCount) },
+      ]
+    : observationSignalCards();
+  const deltaRows = hasCompareReport
+    ? [
+        { label: "Mismatched", value: String(mismatchedCount) },
+        { label: "Missing", value: String(missingCount) },
+        { label: "Extra", value: String(extraCount) },
+        { label: "Missing reports", value: String(missingReportsCount) },
+        { label: "Failed checks", value: String(failedChecksCount) },
+        { label: "Evidence chain", value: evidenceStatus },
+        { label: "LLM params", value: llmParamsStatus },
+        { label: "LLM snapshot", value: llmSnapshotStatus },
+      ]
+    : observationDeltaRows();
 
   if (loading) {
     return <div className="content"><div className="skeleton-stack-lg"><div className="skeleton skeleton-row" /></div></div>;
@@ -153,18 +189,12 @@ export function RunComparePage({ runId, onBack }: Props) {
               <p>{displaySummary}</p>
               <p className="muted">{displayNextAction}</p>
               <div className="compare-signal-grid">
-                <div className="compare-signal-card">
-                  <span className="cell-sub mono muted">Mismatched hashes</span>
-                  <strong>{mismatchedCount}</strong>
-                </div>
-                <div className="compare-signal-card">
-                  <span className="cell-sub mono muted">Missing artifacts</span>
-                  <strong>{missingCount}</strong>
-                </div>
-                <div className="compare-signal-card">
-                  <span className="cell-sub mono muted">Failed report checks</span>
-                  <strong>{failedChecksCount}</strong>
-                </div>
+                {signalCards.map((item) => (
+                  <div key={item.label} className="compare-signal-card">
+                    <span className="cell-sub mono muted">{item.label}</span>
+                    <strong>{item.value}</strong>
+                  </div>
+                ))}
               </div>
             </div>
           </CardBody>
@@ -173,14 +203,12 @@ export function RunComparePage({ runId, onBack }: Props) {
           <CardHeader><CardTitle>Key deltas</CardTitle></CardHeader>
           <CardBody>
             <div className="data-list">
-              <div className="data-list-row"><span className="data-list-label">Mismatched</span><span className="data-list-value mono">{mismatchedCount}</span></div>
-              <div className="data-list-row"><span className="data-list-label">Missing</span><span className="data-list-value mono">{missingCount}</span></div>
-              <div className="data-list-row"><span className="data-list-label">Extra</span><span className="data-list-value mono">{extraCount}</span></div>
-              <div className="data-list-row"><span className="data-list-label">Missing reports</span><span className="data-list-value mono">{missingReportsCount}</span></div>
-              <div className="data-list-row"><span className="data-list-label">Failed checks</span><span className="data-list-value mono">{failedChecksCount}</span></div>
-              <div className="data-list-row"><span className="data-list-label">Evidence chain</span><span className="data-list-value mono">{evidenceStatus}</span></div>
-              <div className="data-list-row"><span className="data-list-label">LLM params</span><span className="data-list-value mono">{llmParamsStatus}</span></div>
-              <div className="data-list-row"><span className="data-list-label">LLM snapshot</span><span className="data-list-value mono">{llmSnapshotStatus}</span></div>
+              {deltaRows.map((item) => (
+                <div key={item.label} className="data-list-row">
+                  <span className="data-list-label">{item.label}</span>
+                  <span className="data-list-value mono">{item.value}</span>
+                </div>
+              ))}
             </div>
             {incidentPack.summary ? <p className="muted mt-2">Incident: {String(incidentPack.summary)}</p> : null}
             {proofPack.summary ? <p className="muted">Proof: {String(proofPack.summary)}</p> : null}
diff --git a/apps/orchestrator/requirements.txt b/apps/orchestrator/requirements.txt
@@ -10,7 +10,7 @@ pydantic==2.12.5
 jsonschema==4.26.0
 typer==0.21.1
 rich==14.3.3
-pytest==9.0.2
+pytest==9.0.3
 fastapi==0.128.1
 uvicorn==0.42.0
 python-dotenv==1.2.1
diff --git a/apps/orchestrator/uv.lock b/apps/orchestrator/uv.lock
diff --git a/design-system/pages/desktop-run-compare.md b/design-system/pages/desktop-run-compare.md
@@ -16,6 +16,7 @@ Preserve the same decision language as web compare while taking advantage of des
 - The verdict card and the key-delta card should feel like one operator panel, not unrelated cards.
 - Back navigation belongs in chrome, not as the loudest action on the page.
 - Bring `evidence chain`, `LLM params`, and `LLM snapshot` into the desktop view so parity does not drift.
+- Observation mode must stay honest. Missing compare data should read as `Missing` or `Unavailable`, not as a false negative.
 
 ## Avoid
 
diff --git a/design-system/pages/planner.md b/design-system/pages/planner.md
@@ -16,6 +16,7 @@ Make the operator understand, in one glance:
 - Metrics are supporting instrumentation, not the hero.
 - `worker contracts`, `unblock tasks`, and `wake policy` must read like planning posture, not like raw artifact counts.
 - Empty state should still feel operational: show the next three moves, not a blank warehouse.
+- Empty state should read like a launch checklist on the left and dispatch routes on the right, not three equal empty cards floating in space.
 - Inspection archive is second-layer only; it may deepen the planning picture, but it must never repeat the triage row one-to-one.
 
 ## Avoid
diff --git a/design-system/pages/run-compare.md b/design-system/pages/run-compare.md
