fix(wmpt): register collapsed routing node on createdChan (prevents dangling prune)#34
Open
guruhubb wants to merge 1 commit into
Open
fix(wmpt): register collapsed routing node on createdChan (prevents dangling prune)#34guruhubb wants to merge 1 commit into
guruhubb wants to merge 1 commit into
Conversation
…dangling prune A routingNode collapsed at collapseLevel was Save()d but never sent to createdChan, so collectDeleteAndCreated could not remove it from the deferred delete set; DeleteNodes() then pruned a node the new root still references, surfacing as 'pebble: not found' on GetPath/referencepath after delete churn. Add createdChan <- n.Hash() in the collapse branch. Adds regression test TestCommitCollapsePruneDangling (fails pre-fix, passes post-fix).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collapsed routing node at collapseLevel was Save()d but never sent to createdChan, so collectDeleteAndCreated couldn't drop it from the deferred-delete set; DeleteNodes() then pruned a node the new root still references -> 'pebble: not found' on GetPath/referencepath after delete churn (StorageV2 blobbers). One-line fix + regression test TestCommitCollapsePruneDangling (fails pre-fix, passes post-fix). Diagnosis: 0chain/blobber docs/wmpt-collapse-prune-dangling.md.