Skip to content

feat: add tracing support for StateSyncTx #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
milando12 wants to merge 36 commits into from

fix lint and tests

d8cb4ab
Select commit
Loading
Failed to load commit list.
Closed

feat: add tracing support for StateSyncTx #2062

fix lint and tests
d8cb4ab
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 30, 2026 in 1m 3s

Quality Gate failed

Failed conditions
8.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Annotations

Check failure on line 1152 in eth/tracers/api.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 26 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ0FjmTktb3XeQK5Le0n&open=AZ0FjmTktb3XeQK5Le0n&pullRequest=2062

Check failure on line 284 in eth/tracers/api_statesync_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "block %d not found" 3 times. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ0wMu_rhIRfcnuOKqAF&open=AZ0wMu_rhIRfcnuOKqAF&pullRequest=2062

Check failure on line 311 in eth/tracers/api_statesync_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "failed to unmarshal state-sync trace: %v" 3 times. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ0wMu_rhIRfcnuOKqAJ&open=AZ0wMu_rhIRfcnuOKqAJ&pullRequest=2062

Check warning on line 37 in eth/tracers/api_statesync_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ0wMu_rhIRfcnuOKqAD&open=AZ0wMu_rhIRfcnuOKqAD&pullRequest=2062

Check failure on line 312 in eth/tracers/api_statesync_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "state-sync trace has no struct logs — EVM code was not executed" 3 times. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ0wMu_rhIRfcnuOKqAH&open=AZ0wMu_rhIRfcnuOKqAH&pullRequest=2062

Check warning on line 61 in consensus/bor/span_mock.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 8 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZz4JXIUxJW5TZIf3v90&open=AZz4JXIUxJW5TZIf3v90&pullRequest=2062

Check warning on line 70 in consensus/bor/bor_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 8 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZxwqNXtwy9t3N92pKRj&open=AZxwqNXtwy9t3N92pKRj&pullRequest=2062

Check failure on line 302 in eth/tracers/api_statesync_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "expected json.RawMessage for state-sync trace result, got %T" 3 times. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ0wMu_rhIRfcnuOKqAG&open=AZ0wMu_rhIRfcnuOKqAG&pullRequest=2062

Check warning on line 276 in eth/tracers/api_statesync_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "TestTraceBlockByNumber_WithStateSyncTx" to match the regular expression ^(_|[a-zA-Z0-9]+)$ 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ0wMu_rhIRfcnuOKqAM&open=AZ0wMu_rhIRfcnuOKqAM&pullRequest=2062

Check warning on line 1152 in eth/tracers/api.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 8 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ0FjmTktb3XeQK5Le0o&open=AZ0FjmTktb3XeQK5Le0o&pullRequest=2062

Check warning on line 388 in eth/tracers/api_statesync_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "TestTraceChain_WithStateSyncTx" to match the regular expression ^(_|[a-zA-Z0-9]+)$ 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ0wMu_rhIRfcnuOKqAO&open=AZ0wMu_rhIRfcnuOKqAO&pullRequest=2062

Check warning on line 674 in eth/tracers/api.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unnecessary variable declaration and use the expression directly in the condition. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ0FjmTktb3XeQK5Le0p&open=AZ0FjmTktb3XeQK5Le0p&pullRequest=2062

Check warning on line 450 in eth/tracers/api_statesync_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "TestIntermediateRoots_WithStateSyncTx" to match the regular expression ^(_|[a-zA-Z0-9]+)$ 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ0wMu_rhIRfcnuOKqAP&open=AZ0wMu_rhIRfcnuOKqAP&pullRequest=2062

Check failure on line 294 in eth/tracers/api_statesync_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "expected %d trace results, got: %d" 3 times. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ0wMu_rhIRfcnuOKqAK&open=AZ0wMu_rhIRfcnuOKqAK&pullRequest=2062

Check warning on line 332 in eth/tracers/api_statesync_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename function "TestTraceBlockByHash_WithStateSyncTx" to match the regular expression ^(_|[a-zA-Z0-9]+)$ 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ0wMu_rhIRfcnuOKqAN&open=AZ0wMu_rhIRfcnuOKqAN&pullRequest=2062

Check failure on line 286 in eth/tracers/api_statesync_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "expected %d transactions in block body, got %d" 3 times. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ0wMu_rhIRfcnuOKqAL&open=AZ0wMu_rhIRfcnuOKqAL&pullRequest=2062

Check failure on line 715 in eth/tracers/api.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 22 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ0FjmTktb3XeQK5Le0m&open=AZ0FjmTktb3XeQK5Le0m&pullRequest=2062

Check warning on line 294 in consensus/bor/heimdall/span/spanner.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 8 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZxwqNWOwy9t3N92pKRg&open=AZxwqNWOwy9t3N92pKRg&pullRequest=2062

Check warning on line 53 in consensus/bor/span_mock.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 8 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZz4JXIUxJW5TZIf3v9z&open=AZz4JXIUxJW5TZIf3v9z&pullRequest=2062

Check failure on line 396 in eth/tracers/api_statesync_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "failed to get block: %d, err: %v" 3 times. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ0wMu_rhIRfcnuOKqAE&open=AZ0wMu_rhIRfcnuOKqAE&pullRequest=2062

Check failure on line 325 in eth/tracers/api_statesync_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define a constant instead of duplicating this literal "expected 2 LOG0 opcodes (one per bridge event forwarded to target), got %d" 3 times. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ0wMu_rhIRfcnuOKqAI&open=AZ0wMu_rhIRfcnuOKqAI&pullRequest=2062
View more details on SonarQubeCloud