Skip to content

(feat): tracing support for state-sync transactions #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
manav2401 wants to merge 18 commits into
base: develop
Choose a base branch
from

address claude comments

065186b
Select commit
Loading
Failed to load commit list.
Draft

(feat): tracing support for state-sync transactions #2172

address claude comments
065186b
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Apr 3, 2026 in 37m 24s

Code review found 1 important issue

Found 5 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 1
🟡 Nit 0
🟣 Pre-existing 0
Severity File:Line Issue
🔴 Important eth/state_accessor.go:268-270 Resource leak: release() not called in new bounds check error path

Annotations

Check failure on line 270 in eth/state_accessor.go

See this annotation in the file changed.

@claude claude / Claude Code Review

Resource leak: release() not called in new bounds check error path 

The new bounds check at `eth/state_accessor.go:268-270` returns an error without calling `release()`, leaking the historical statedb resources acquired by the prior `stateAtBlock` call. Any caller that passes an out-of-bounds `txIndex` (e.g. `TraceTransaction` with a bad index) will hold live trie node references open indefinitely. Fix: add `release()` before the error return on line 269.
View more details on Claude