Deterministic state syncs #2177
Open
Claude / Claude Code Review
completed
Apr 6, 2026 in 29m 13s
Code review found 1 potential issue
Found 5 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | consensus/bor/heimdall/failover_client_test.go:1419-1441 |
Misleading timeout test uses non-production attemptTimeout to fake 1-minute deadline propagation |
Annotations
Check warning on line 1441 in consensus/bor/heimdall/failover_client_test.go
claude / Claude Code Review
Misleading timeout test uses non-production attemptTimeout to fake 1-minute deadline propagation
The test `TestMultiFailover_StateSyncEventsByTime_CapsAttemptTimeoutWithGlobalPaginationDeadline` only passes because it artificially sets `fc.attemptTimeout = 2 * time.Minute` — a non-production value. With this override, `callWithFailover` creates `subCtx = context.WithTimeout(ctx_1min, 2min)`, so the lambda receives the parent 1-minute deadline, making `remaining > 55s` pass. In production with `defaultAttemptTimeout = 30s`, the same code path creates `subCtx = context.WithTimeout(ctx_1min, 3
Loading