Skip to content

templates: replace dead witnessprotocol with witness.enable hint #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apetro2 wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

templates: replace dead witnessprotocol with witness.enable hint #2204

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f40e5a5
templates: replace dead witnessprotocol with witness.enable hint
apetro2 Apr 29, 2026
1c63194
ci: stabilize codecov/diffguard and skip fork-only e2e constraints
apetro2 May 2, 2026
a803327
templates: move witness hint and drop workflow edits
apetro2 May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,8 @@ jobs:
path: cover.out

codecov:
if: (github.event.action != 'closed' || github.event.pull_request.merged == true)
Copy link
Copy Markdown
Member

@pratikspatil024 pratikspatil024 May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these changes are irrelevant to the PR, please merge/rebase the latest develop

# Fork PRs do not receive CODECOV_TOKEN, so skip this job in untrusted contexts.
if: (github.event.action != 'closed' || github.event.pull_request.merged == true) && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.fork == false)
strategy:
matrix:
os: [ubuntu-22.04] # List of OS: https://github.com/actions/virtual-environments
Expand All @@ -163,9 +164,9 @@ jobs:
- name: Checkout
uses: actions/checkout@v5
- name: Download artifacts
uses: actions/download-artifact@v6.0.0
uses: actions/download-artifact@v7
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v6
with:
token: ${{ secrets.CODECOV_TOKEN }}
fail_ci_if_error: true
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/diffguard.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ jobs:
restore-keys: ${{ runner.os }}-diffguard-

- name: Install diffguard
run: go install github.com/0xPolygon/diffguard/cmd/diffguard@latest
# Pin to a known-good commit; @latest can break when the upstream repo force-pushes.
run: go install github.com/0xPolygon/diffguard/cmd/diffguard@cbf402dd181b7e1afc850de2e06357807a052317

- name: Run diffguard
id: diffguard
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/kurtosis-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ env:

jobs:
build-bor:
# Fork PRs cannot get OIDC tokens/secrets required by setup, so skip early.
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.fork == false
runs-on: ubuntu-latest
timeout-minutes: 20
steps:
Expand All @@ -41,6 +43,8 @@ jobs:
retention-days: 1

build-heimdall-v2:
# Fork PRs cannot get OIDC tokens/secrets required by setup, so skip early.
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.fork == false
runs-on: ubuntu-latest
timeout-minutes: 20
steps:
Expand All @@ -64,6 +68,8 @@ jobs:
retention-days: 1

e2e-tests:
# Fork PRs cannot get OIDC tokens/secrets required by setup, so skip early.
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.fork == false
needs:
- build-bor
- build-heimdall-v2
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/kurtosis-stateless-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ env:

jobs:
build-bor:
# Fork PRs cannot get OIDC tokens/secrets required by setup, so skip early.
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.fork == false
runs-on: ubuntu-latest
timeout-minutes: 20
steps:
Expand All @@ -41,6 +43,8 @@ jobs:
retention-days: 1

build-heimdall-v2:
# Fork PRs cannot get OIDC tokens/secrets required by setup, so skip early.
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.fork == false
runs-on: ubuntu-latest
timeout-minutes: 20
steps:
Expand All @@ -64,6 +68,8 @@ jobs:
retention-days: 1

e2e-tests:
# Fork PRs cannot get OIDC tokens/secrets required by setup, so skip early.
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.fork == false
needs:
- build-bor
- build-heimdall-v2
Expand Down
3 changes: 2 additions & 1 deletion builder/files/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ syncmode = "full"
# snapshot = true
# "bor.logs" = false
# ethstats = ""
# witnessprotocol = false
Copy link
Copy Markdown
Member

@pratikspatil024 pratikspatil024 May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to remove it from here and add it in it's original place somewhere below in the config. bor dumpconfig command will help

# [witness]
# enable = false
# devfakeauthor = false
# ["eth.requiredblocks"]

Expand Down
3 changes: 2 additions & 1 deletion packaging/templates/mainnet-v1/sentry/sentry/bor/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ syncmode = "full"
# gcmode = "full"
# snapshot = true
# ethstats = ""
# witnessprotocol = false
# [witness]
# enable = false
# devfakeauthor = false

# ["eth.requiredblocks"]
Expand Down
3 changes: 2 additions & 1 deletion packaging/templates/mainnet-v1/sentry/sentry/bor/pbss_config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ syncmode = "full"
# gcmode = "full"
# snapshot = true
# ethstats = ""
# witnessprotocol = false
# [witness]
# enable = false
# devfakeauthor = false

# ["eth.requiredblocks"]
Expand Down
3 changes: 2 additions & 1 deletion packaging/templates/mainnet-v1/sentry/validator/bor/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ syncmode = "full"
# gcmode = "full"
# snapshot = true
# ethstats = ""
# witnessprotocol = false
# [witness]
# enable = false
# devfakeauthor = false

# ["eth.requiredblocks"]
Expand Down
3 changes: 2 additions & 1 deletion packaging/templates/mainnet-v1/sentry/validator/bor/pbss_config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ syncmode = "full"
# gcmode = "full"
# snapshot = true
# ethstats = ""
# witnessprotocol = false
# [witness]
# enable = false
# devfakeauthor = false

# ["eth.requiredblocks"]
Expand Down
3 changes: 2 additions & 1 deletion packaging/templates/mainnet-v1/without-sentry/bor/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ syncmode = "full"
# gcmode = "full"
# snapshot = true
# ethstats = ""
# witnessprotocol = false
# [witness]
# enable = false
# devfakeauthor = false

# ["eth.requiredblocks"]
Expand Down
3 changes: 2 additions & 1 deletion packaging/templates/mainnet-v1/without-sentry/bor/pbss_config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ syncmode = "full"
# gcmode = "full"
# snapshot = true
# ethstats = ""
# witnessprotocol = false
# [witness]
# enable = false
# devfakeauthor = false

# ["eth.requiredblocks"]
Expand Down
3 changes: 2 additions & 1 deletion packaging/templates/testnet-amoy/sentry/sentry/bor/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ syncmode = "full"
# gcmode = "full"
# snapshot = true
# ethstats = ""
# witnessprotocol = false
# [witness]
# enable = false
# devfakeauthor = false

# ["eth.requiredblocks"]
Expand Down
3 changes: 2 additions & 1 deletion packaging/templates/testnet-amoy/sentry/validator/bor/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ syncmode = "full"
# gcmode = "full"
# snapshot = true
# ethstats = ""
# witnessprotocol = false
# [witness]
# enable = false
# devfakeauthor = false

# ["eth.requiredblocks"]
Expand Down
3 changes: 2 additions & 1 deletion packaging/templates/testnet-amoy/without-sentry/bor/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ syncmode = "full"
# gcmode = "full"
# snapshot = true
# ethstats = ""
# witnessprotocol = false
# [witness]
# enable = false
# devfakeauthor = false

# ["eth.requiredblocks"]
Expand Down