Skip to content

miner: disable tracer in vm.Config to prevent conflicts during block synchronization#2206

Open
maoueh wants to merge 4 commits into0xPolygon:developfrom
maoueh:fix/miner-no-live-tracing
Open

miner: disable tracer in vm.Config to prevent conflicts during block synchronization#2206
maoueh wants to merge 4 commits into0xPolygon:developfrom
maoueh:fix/miner-no-live-tracing

Conversation

@maoueh
Copy link
Copy Markdown
Contributor

@maoueh maoueh commented Apr 29, 2026

Description

If running bor with live tracing enabled, once reaching live, miner starts to also call the live tracing hooks causing problems because only the block synchronization should call the live tracer.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Breaking changes

None

Nodes audience

People running Live Tracing + bor

Testing

  • I have tested this code manually on Mainnet

Copilot AI review requested due to automatic review settings April 29, 2026 16:30
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prevents mining-time EVM execution from invoking the chain-level vm.Config.Tracer hooks, avoiding conflicts when “live tracing” is enabled during block synchronization.

Changes:

  • In miner/worker.go, explicitly clears vm.Config.Tracer in the miner’s derived VM config to ensure tracing hooks don’t run during block production.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread miner/worker.go Outdated
Comment thread miner/worker.go
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 30, 2026 14:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread miner/worker.go
Copilot AI review requested due to automatic review settings May 4, 2026 14:39
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adamdossa adamdossa requested review from manav2401 May 5, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants