Skip to content

core, blockstm, state: add BlockSTM v2 parallel transaction execution #2210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cffls wants to merge 7 commits into
base: develop
Choose a base branch
from

core, blockstm: address inline PR review comments

4c688e4
Select commit
Loading
Failed to load commit list.
Open

core, blockstm, state: add BlockSTM v2 parallel transaction execution #2210

core, blockstm: address inline PR review comments
4c688e4
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed May 5, 2026 in 1m 9s

Quality Gate failed

Failed conditions
3.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 1170 in core/parallel_state_processor.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 8 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ32n4vqQTy0jLCvpuEA&open=AZ32n4vqQTy0jLCvpuEA&pullRequest=2210

Check failure on line 743 in core/parallel_state_processor.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 22 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ32n4vqQTy0jLCvpuD6&open=AZ32n4vqQTy0jLCvpuD6&pullRequest=2210

Check warning on line 632 in core/parallel_state_processor.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 8 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ32n4vqQTy0jLCvpuD4&open=AZ32n4vqQTy0jLCvpuD4&pullRequest=2210

Check failure on line 1107 in core/state/statedb.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ32n4r-QTy0jLCvpuDh&open=AZ32n4r-QTy0jLCvpuDh&pullRequest=2210

Check failure on line 788 in core/mainnet_witness_benchmark_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 25 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ32n4vQQTy0jLCvpuDt&open=AZ32n4vQQTy0jLCvpuDt&pullRequest=2210

Check warning on line 315 in core/parallel_state_processor.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 9 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ32n4vqQTy0jLCvpuD2&open=AZ32n4vqQTy0jLCvpuD2&pullRequest=2210

Check warning on line 858 in core/state/parallel_statedb_coverage_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 8 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ32n4pvQTy0jLCvpuDX&open=AZ32n4pvQTy0jLCvpuDX&pullRequest=2210

Check failure on line 1227 in core/mainnet_witness_benchmark_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 19 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ32n4vQQTy0jLCvpuDw&open=AZ32n4vQQTy0jLCvpuDw&pullRequest=2210

Check warning on line 1127 in core/state/parallel_statedb_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 8 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ32n4sSQTy0jLCvpuDj&open=AZ32n4sSQTy0jLCvpuDj&pullRequest=2210

Check failure on line 2167 in core/state/statedb_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 59 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ32n4qgQTy0jLCvpuDa&open=AZ32n4qgQTy0jLCvpuDa&pullRequest=2210

Check warning on line 133 in core/blockstm/v2_executor.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this 'context.Context' field and pass context as a parameter to methods that need it. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ32n4s8QTy0jLCvpuDo&open=AZ32n4s8QTy0jLCvpuDo&pullRequest=2210

Check warning on line 946 in core/parallel_state_processor.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 8 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ32n4vqQTy0jLCvpuD-&open=AZ32n4vqQTy0jLCvpuD-&pullRequest=2210

Check warning on line 1616 in core/state/parallel_statedb_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 8 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ32n4sSQTy0jLCvpuDk&open=AZ32n4sSQTy0jLCvpuDk&pullRequest=2210

Check failure on line 1111 in core/state/parallel_statedb.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this function is empty or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ32n4q5QTy0jLCvpuDc&open=AZ32n4q5QTy0jLCvpuDc&pullRequest=2210

Check failure on line 1688 in core/mainnet_witness_benchmark_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 35 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ32n4vQQTy0jLCvpuD0&open=AZ32n4vQQTy0jLCvpuD0&pullRequest=2210

Check failure on line 21 in core/blockstm/invariants_off.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this function is empty or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ32n4tEQTy0jLCvpuDq&open=AZ32n4tEQTy0jLCvpuDq&pullRequest=2210

Check warning on line 643 in core/parallel_state_processor.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 8 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ32n4vqQTy0jLCvpuD5&open=AZ32n4vqQTy0jLCvpuD5&pullRequest=2210

Check failure on line 1167 in core/mainnet_witness_benchmark_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ32n4vQQTy0jLCvpuDv&open=AZ32n4vQQTy0jLCvpuDv&pullRequest=2210

Check warning on line 743 in core/parallel_state_processor.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 13 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ32n4vqQTy0jLCvpuD7&open=AZ32n4vqQTy0jLCvpuD7&pullRequest=2210

Check warning on line 236 in core/state/parallel_statedb_coverage_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unnecessary variable declaration and use the expression directly in the condition. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ32n4pvQTy0jLCvpuDZ&open=AZ32n4pvQTy0jLCvpuDZ&pullRequest=2210

Check warning on line 932 in core/state/parallel_statedb_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 8 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ32n4sSQTy0jLCvpuDi&open=AZ32n4sSQTy0jLCvpuDi&pullRequest=2210

Check failure on line 106 in core/parallel_state_processor_fork_parity_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 20 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ32n4v0QTy0jLCvpuEB&open=AZ32n4v0QTy0jLCvpuEB&pullRequest=2210

Check warning on line 394 in core/state/parallel_statedb.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this parameter to match the regular expression "^(_|[a-zA-Z0-9]+)$". 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ32n4q5QTy0jLCvpuDd&open=AZ32n4q5QTy0jLCvpuDd&pullRequest=2210

Check warning on line 904 in core/parallel_state_processor.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function has 12 parameters, which is greater than the 7 authorized. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ32n4vqQTy0jLCvpuD9&open=AZ32n4vqQTy0jLCvpuD9&pullRequest=2210

Check failure on line 66 in core/state/v2_fuzz_test.go

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 55 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=0xPolygon_bor&issues=AZ32n4nMQTy0jLCvpuDW&open=AZ32n4nMQTy0jLCvpuDW&pullRequest=2210
View more details on SonarQubeCloud