Modernize examples#574
Merged
Merged
Conversation
Contributor
kant2002
commented
May 1, 2026
kant2002
commented
- Use .NET 10, since .NET 6 is not by default on new computer anymore and it's not supported
- You cannot save to drive C: in Windows 11 by default. Maybe just my computer, who knowns. Anyway, that make examples Windows only, which is unnecessary
- Example3 crashed, since invariant changed, and you should pass empty string as locale.
- Use .NET 10, since .NET 6 is not by default on new computer anymore and it's not supported - You cannot save to drive C: in Windows 11 by default. Maybe just my computer, who knowns. Anyway, that make examples Windows only, which is unnecessary - Example3 crashed, since invariant changed, and you should pass empty string as locale.
Contributor
Author
|
@ElektroKill can you take a look? |
Contributor
Changes look good to me, the rest is dependent on @wtfsck. Since .NET 6 is out of support updating dnlib to target |
Contributor
|
Thanks, I merged it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.