Adding A3mega Llama3.1-70b recipe with trtllm#221
Draft
Priya-Quad wants to merge 6 commits intoAI-Hypercomputer:mainfrom
Draft
Adding A3mega Llama3.1-70b recipe with trtllm#221Priya-Quad wants to merge 6 commits intoAI-Hypercomputer:mainfrom
Priya-Quad wants to merge 6 commits intoAI-Hypercomputer:mainfrom
Conversation
depksingh
reviewed
May 7, 2026
Comment on lines
+1
to
+3
| # Copyright 2025 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); |
Collaborator
There was a problem hiding this comment.
Please remove the template if we already have the trt-inference folder
depksingh
reviewed
May 7, 2026
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: "{{ .Release.Name }}-config" |
Collaborator
There was a problem hiding this comment.
Please update it with the same format that vllm configs have and all the other files
depksingh
reviewed
May 7, 2026
| configFile: serving-args.yaml | ||
| configPath: /workload/configs | ||
| envs: | ||
| - name: LAUNCHER_SCRIPT |
Collaborator
There was a problem hiding this comment.
Move these to the launcher or some other file, which have the env variables
depksingh
reviewed
May 7, 2026
| pp_size=${SERVING_CONFIG_DICT["pp_size"]:=1} | ||
| ep_size=${SERVING_CONFIG_DICT["ep_size"]:=1} | ||
| backend=${SERVING_CONFIG_DICT["backend"]:="tensorrt"} | ||
| backend="tensorrt" |
Collaborator
There was a problem hiding this comment.
Please remove the hardcoding, the file is already right, as its being used by multiple models. Please debug the issue
depksingh
reviewed
May 7, 2026
| # If custom_dataset is not set, generate a textual dataset with tokens sampled in normal distribution | ||
| if [ -z "$dataset_file" ]; then | ||
| dataset_file="/ssd/token-norm-dist_${model_name##*/}_${isl}_${osl}_tp${tp_size}.json" | ||
| dataset_file="/scratch/token-norm-dist_${model_name##*/}_${isl}_${osl}_tp${tp_size}.json" |
Collaborator
There was a problem hiding this comment.
make changes in your added files instead of changing this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.