Add UsdUVTexture v2.3 variant with vector4 scale and bias#2944
Open
ld-kerley wants to merge 3 commits into
Open
Add UsdUVTexture v2.3 variant with vector4 scale and bias#2944ld-kerley wants to merge 3 commits into
ld-kerley wants to merge 3 commits into
Conversation
kwokcb
approved these changes
May 21, 2026
kwokcb
left a comment
kwokcb
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Maybe add an instance of this variant to the existing usd or image sample test files.so can be used for mtlx and usd testing.
Introduces ND_UsdUVTexture_23_vector4 nodedef and IMP_UsdUVTexture_23_vector4 nodegraph implementation, where the `scale` and `bias` inputs are typed as vector4 instead of the original color4-derived behavior. The prior variant is retained for now and may be removed in a future MaterialX release via an upgrade function.
… the nodedefs with the new version can be selected
ld-kerley
force-pushed
the
usduvtexture-vector4-type-bias-scale
branch
from
fb1c1bc to
b3d765b
Compare
Contributor
Author
|
added unit test - now we have a test that tests UsdUVTexture and also the new typed scale and bias. |
kwokcb
reviewed
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2895
Introduces
ND_UsdUVTexture_23_vector4nodedef and IMP_UsdUVTexture_23_vector4nodegraph implementation, where thescaleandbiasinputs are typed as vector4 instead of the original color4-derived behavior. The prior variant is retained for now for compatibility but could be removed in a future MaterialX release via an upgrade function.