feat(GUI): add customizable temperature-curve fan control mode#67
Open
3Mker wants to merge 1 commit into
Open
Conversation
Owner
|
Hi! Thank you very much for the contribution! Very nice feature, putting your PR on my task list. |
Owner
|
A few problems:
Recording.2025-05-24.143333.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new “Curve” mode that lets users draw and apply custom GPU/CPU temperature-to-fan-speed curves:
• In [AppGUI.py]
– Embed a TemperatureCurve widget with a selector to switch between GPU and CPU curves
– Show/hide the curve editor when entering/exiting Curve mode
– Persist curve points in QSettings (serialize/deserialize)
– On each update tick or mode switch, look up the current temperature on the drawn curve and set the fan speed accordingly
• In TemperatureCurve.py
– Expose APIs to render an interactive point-editing chart
– Provide get_fan_speed_for_temp() to map a temperature value to a fan-speed percentage
• In SettingsKey enum
– Add keys for storing GPUCurvePoints and CPUCurvePoints
No existing fan-control logic was removed—Curve mode simply augments the Custom mode path. All new code is covered by manual verification and preserves backward compatibility with existing modes.