fix request slots not accepting ghost items from EMI#63
Merged
Conversation
rlnt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ME Requester stopped accepting drag-and-drop from ghost items from EMI.
Changes in Applied Energistics 2 Add native EMI support for Forge 1.20.1. (#8659) seems to be the culprit.
I've isolated the issue to the
canSetFilterToandsetFilterTomethods seen athttps://github.com/AppliedEnergistics/Applied-Energistics-2/blob/forge/1.20.1/src/main/java/appeng/menu/slot/FakeSlot.java#L65
Proposed Changes
Update the
aeVersiondependency to release 15.4.10 and add simple overrides toFakeSlotmethods inRequestSlot.This should fix drag-and-drop ghost item stacks from EMI being ignored.
Additional Context
I targeted 1.20.1-forge here because that is the version I need for the pack I play.
I saw you were willing to do critical bug fixes, so hopefully you can include this fix as well.
Thank you!!