Antalya 26.3: Fix condition for using parquet metadata cache#1751
Open
zvonand wants to merge 3 commits intoantalya-26.3from
Open
Antalya 26.3: Fix condition for using parquet metadata cache#1751zvonand wants to merge 3 commits intoantalya-26.3from
zvonand wants to merge 3 commits intoantalya-26.3from
Conversation
zvonand
added
releasy
…next commit) --- Original cherry-pick message follows: Merge pull request #1631 from Altinity/arthurpassos-patch-11 Fix condition for using parquet metadata cache # Conflicts: # src/Storages/ObjectStorage/StorageObjectStorageSource.cpp # tests/integration/test_storage_iceberg_with_spark/test_read_constant_columns_optimization.py
zvonand
force-pushed
the
feature/antalya-26.3/pr-1631
branch
from
98cefd0 to
304b298
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix apache iceberg queries not hitting the parquet metadata cache (#1631 by @arthurpassos).
CI/CD Options
Exclude tests:
Regression jobs to run:
Cherry-picked from #1631.
Apache Iceberg queries were not htiting the parquet metadata cache because
object_info->getFileFormat()resolves toIcebergDataObjectInfo::getFileFormat, which gets its return value fromIcebergObjectSerializableInfo. This field is filled with the value from Apache Iceberg manifest file, and it is upper case by default, which then fails clickhouse check for parquet metadata cache usage.Documentation entry for user-facing changes
...