feat: embed ACVP wrapper and public-scope reproducibility flow#1364
Open
vzakaznikov wants to merge 2 commits intoAltinity:masterfrom
Open
feat: embed ACVP wrapper and public-scope reproducibility flow#1364vzakaznikov wants to merge 2 commits intoAltinity:masterfrom
vzakaznikov wants to merge 2 commits intoAltinity:masterfrom
Conversation
Add ACVP wrapper entrypoints to clickhouse-backup and package the acvp symlink so the shipped binary can be exercised by acvptool. Add a tracked public-API-only ACVP config, reproducibility script, and documentation with pinned upstream references while aligning advertised wrapper capabilities with the supported public Go crypto scope. Co-authored-by: Cursor <cursoragent@cursor.com>
vzakaznikov
force-pushed
the
feat/acvp-wrapper-public-repro
branch
from
bc467e1 to
a434d4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clickhouse-backupbinary with two entry points: argv0 dispatch viaclickhouse-backup-acvpand CLI dispatch viaclickhouse-backup acvp.pkg/acvpwrapperimplementation plus tests, and package theclickhouse-backup-acvpsymlink in Linux package builds so the wrapper can be exercised withacvptoolagainst the same binary artifact.pkg/acvpwrapper/acvp_test_fips140v1.26.public.config.json,run.sh,README.md) with pinned upstream references and reproduction guidance.getConfigcapabilities.Test plan
docker run --rm -v "$PWD:/work" -w /work golang:1.26-alpine sh -lc 'export PATH=$PATH:/usr/local/go/bin && go test ./...'bash pkg/acvpwrapper/run.sh(expected output includes38 ACVP tests matched expectations)Made with Cursor